New issue
Advanced search Search tips

Issue 619069 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Cloud Print] Open printer list in a new tab

Project Member Reported by tbuck...@chromium.org, Jun 10 2016

Issue description

Currently the printer list (chrome://devices) clobbers the Settings page when clicking "Manage Cloud Print devices". This should act like selecting a theme and open chrome://devices in a separate tab.
 

Comment 3 by dbeam@chromium.org, Jun 14 2016

Cc: -dbeam@chromium.org tbuck...@chromium.org
Labels: OS-Chrome OS-Linux OS-Mac OS-Windows
Owner: dbeam@chromium.org
Status: Started (was: Available)
I think I asked this question while implementing and you guys said "just do whatever the old settings does" -> which is clobber

I'll make it not clobber
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aabe8b3dfbd28c9b2a017b97de7008c1ccc3fe9e

commit aabe8b3dfbd28c9b2a017b97de7008c1ccc3fe9e
Author: dbeam <dbeam@chromium.org>
Date: Wed Jun 15 04:38:58 2016

MD Settings: make devices open in a new tab rather than clobber current one

R=groby@chromium.org
BUG= 619069 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2062163004
Cr-Commit-Position: refs/heads/master@{#399841}

[modify] https://crrev.com/aabe8b3dfbd28c9b2a017b97de7008c1ccc3fe9e/chrome/browser/resources/settings/printing_page/printing_page.js

This is the exception that proves the rule... :-)

Thanks for fixing this, it's always been a challenge to send the user to chrome://devices and try to make it feel connected.

Comment 6 by dbeam@chromium.org, Jun 15 2016

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment