New issue
Advanced search Search tips

Issue 619065 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

run-webkit-tests prints confusing summary (no list following colon).

Project Member Reported by cbiesin...@chromium.org, Jun 10 2016

Issue description

$ run-webkit-tests -t Debuggn --no-new-test-results --nocheck-sys-deps -f css3/flexbox
[...snipped lots of output...]

Retrying 18 unexpected failures, attempt 1 of 3...
                                                                       
151 tests ran as expected, 18 didn't:

$

There is no list of these 18 failures. I assume that's because they passed on retry. But this output looks wrong.

Tree as of:
commit 2a27d74512f152b818ed929876a2f87413ce074a
Author: bcwhite <bcwhite@chromium.org>
Date:   Fri Jun 10 11:47:05 2016

 
Should it be updated to something like "18 failed initially but passed when retried"?
Status: WontFix (was: Unconfirmed)
Summary: run-webkit-tests produces strange output (was: run-webkit-tests produces strange output)
I'm not finding an easy way to reproduce this; will close this for now but please re-open if you see this again.
Cc: qyears...@chromium.org
Status: Available (was: WontFix)
Just find a flaky test and run it. For example, remove the TestExpections line for imported/csswg-test/css-flexbox-1/css-flexbox-height-animation-stretch.html and do:

run-webkit-tests -t Debuggn --no-new-test-results --nocheck-sys-deps -f --retry-failures imported/csswg-test/css-flexbox-1/css-flexbox-height-animation-stretch.html

And you'll find the output is still the same:

Retrying 1 unexpected failure, attempt 1 of 3...
                          
0 tests ran as expected, 1 didn't:

cbiesinger@cbiesinger07:~/chromium/src/third_party/WebKit/LayoutTests$ 


Summary: run-webkit-tests prints confusing summary (no list following colon). (was: run-webkit-tests produces strange output )
Ah, thanks :-)

This will likely be a change in layout_tests/views/printing.py (https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing.py?package:chromium&l=282)
Labels: -OS-Linux Hotlist-GoodFirstBug
Project Member

Comment 6 by sheriffbot@chromium.org, Apr 12 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by ajuma@chromium.org, Apr 20 2018

Status: Available (was: Untriaged)
I had removed some related code in https://chromium.googlesource.com/chromium/src/+/5a9ed2818ad4cf1a3f551dfd9713a44cc1a2815c in 2017, which may be related although this bug appears to be from before that change.
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b42b7c5848ae96af6882b8688ea56d64f7bdf94

commit 2b42b7c5848ae96af6882b8688ea56d64f7bdf94
Author: Dirk Pranke <dpranke@chromium.org>
Date: Wed Apr 25 00:53:28 2018

Remove a bunch of logging from run-webkit-tests.

Long, long ago we added a bunch of diagnostic logging to
run-webkit-tests to identify slow tests and slow directories.

I'm willing to bet no one has looked at that output in 6+ years,
but it still clogs up every run.

This CL removes all of that, and also restores the list of
failed tests at the end of the run that was removed in
r494598 (though this is a much simpler version of that).

R=qyearsley@chromium.org
BUG=619065

Change-Id: Idb81192f848a307cdf4bcc834199156d2fd2d563
Reviewed-on: https://chromium-review.googlesource.com/1023053
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553400}
[modify] https://crrev.com/2b42b7c5848ae96af6882b8688ea56d64f7bdf94/third_party/blink/tools/blinkpy/web_tests/views/printing.py
[modify] https://crrev.com/2b42b7c5848ae96af6882b8688ea56d64f7bdf94/third_party/blink/tools/blinkpy/web_tests/views/printing_unittest.py

Sign in to add a comment