New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 619063 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Mac BookmarkBarController triggering resize to wrong renderer process

Project Member Reported by kenrb@chromium.org, Jun 10 2016

Issue description

This is a follow up bug to  issue 612606 . I am landing a patch to fix the crash in the renderer, but I think the browser-side behavior is buggy also. In this case a main frame navigation is committing and the BookmarkBarController gets notified via Browser::DidNavigateMainFramePostCommit(), a resize message is getting sent to the RenderViewImpl for the page that is being navigated *away from* (which has a swapped out main frame). This doesn't seem right.

Here is what the stack looks like when that happens:

4   Chromium Framework                  0x0000000118f9d268 _ZN7content20RenderWidgetHostImpl10WasResizedEv + 744

5   Chromium Framework                  0x0000000118fe7351 -[RenderWidgetHostViewCocoa setFrameSize:] + 817

6   AppKit                              0x00007fff8b1cea11 -[NSView setFrame:] + 476

7   Chromium Framework                  0x000000011942ad7a -[WebContentsViewCocoa resizeSubviewsWithOldSize:] + 474

8   AppKit                              0x00007fff8b1b661b -[NSView setFrameSize:] + 1755

9   AppKit                              0x00007fff8b1cea11 -[NSView setFrame:] + 476

10  Chromium Framework                  0x000000011763972f -[TabContentsContainerView resizeSubviewsWithOldSize:] + 463

11  AppKit                              0x00007fff8b1b661b -[NSView setFrameSize:] + 1755

12  AppKit                              0x00007fff8b1cea11 -[NSView setFrame:] + 476

13  AppKit                              0x00007fff8b1db321 -[NSView resizeWithOldSuperviewSize:] + 1185

14  AppKit                              0x00007fff8b1da9ad -[NSView resizeSubviewsWithOldSize:] + 318

15  AppKit                              0x00007fff8b1b661b -[NSView setFrameSize:] + 1755

16  AppKit                              0x00007fff8b1cea11 -[NSView setFrame:] + 476

17  AppKit                              0x00007fff8b1db321 -[NSView resizeWithOldSuperviewSize:] + 1185

18  AppKit                              0x00007fff8b1da9ad -[NSView resizeSubviewsWithOldSize:] + 318

19  AppKit                              0x00007fff8b1b661b -[NSView setFrameSize:] + 1755

20  AppKit                              0x00007fff8b1cea11 -[NSView setFrame:] + 476

21  Chromium Framework                  0x000000011748b4b7 -[DevToolsContainerView adjustSubviews] + 583

22  Chromium Framework                  0x000000011748b1eb -[DevToolsContainerView resizeSubviewsWithOldSize:] + 59

23  AppKit                              0x00007fff8b1b661b -[NSView setFrameSize:] + 1755

24  AppKit                              0x00007fff8b1cea11 -[NSView setFrame:] + 476

25  AppKit                              0x00007fff8b1db321 -[NSView resizeWithOldSuperviewSize:] + 1185

26  AppKit                              0x00007fff8b1da9ad -[NSView resizeSubviewsWithOldSize:] + 318

27  AppKit                              0x00007fff8b1b661b -[NSView setFrameSize:] + 1755

28  AppKit                              0x00007fff8b1cea11 -[NSView setFrame:] + 476

29  Chromium Framework                  0x0000000117440ef4 -[BrowserWindowController(Private) layoutTabContentArea:] + 260

30  Chromium Framework                  0x0000000117445e0d -[BrowserWindowController(Private) applyLayout:] + 1549

31  Chromium Framework                  0x00000001174406e0 -[BrowserWindowController(Private) layoutSubviews] + 432

32  Chromium Framework                  0x000000011742e18f -[BrowserWindowController resizeView:newHeight:] + 2591

33  Chromium Framework                  0x000000011736ed1b -[AnimatableView setHeight:] + 91

34  Chromium Framework                  0x00000001173d28e5 -[BookmarkBarController showBookmarkBarWithAnimation:] + 181

35  Chromium Framework                  0x00000001173cfb73 -[BookmarkBarController updateVisibility] + 51

36  Chromium Framework                  0x00000001173d606e -[BookmarkBarController finalizeState] + 158

37  Chromium Framework                  0x00000001173d5f07 -[BookmarkBarController moveToState:withAnimation:] + 535

38  Chromium Framework                  0x00000001173d5fa0 -[BookmarkBarController updateState:changeType:] + 112

39  Chromium Framework                  0x00000001174227ab _ZN18BrowserWindowCocoa23BookmarkBarStateChangedEN11BookmarkBar17AnimateChangeTypeE + 91

40  Chromium Framework                  0x0000000117771b23 _ZN7Browser22UpdateBookmarkBarStateENS_28BookmarkBarStateChangeReasonE + 1091

41  Chromium Framework                  0x0000000117782a53 _ZN7Browser30DidNavigateMainFramePostCommitEPN7content11WebContentsE + 115
 

Comment 1 by tapted@chromium.org, Jun 15 2016

Cc: tapted@chromium.org
Owner: spqc...@chromium.org
Status: Assigned (was: Untriaged)
[mac triage] semi randomly picking spqchan to investigate
Owner: ----
Status: Untriaged (was: Assigned)
Cc: -a...@chromium.org
Labels: Hotlist-CocoaBrowser
Owner: a...@chromium.org
Status: Assigned (was: Untriaged)
Mac triage: assigning to avi@, but I think this is Pri-3.
Labels: Hotlist-DesktopUIChecked Hotlist-DesktopUIToolingRequired
***UI Mass Triage ***
Adding labels for expert review.

Sign in to add a comment