New issue
Advanced search Search tips

Issue 619060 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 625836



Sign in to add a comment

Some gpuBenchmarking seem to create leaks in layout tests

Project Member Reported by nzolghadr@chromium.org, Jun 10 2016

Issue description

Particularly this tests for example seem to have leaks:

imported/wpt/pointerevents/pointerevent_change-touch-action-onpointerdown_touch-manual.html
 
Cc: battre@chromium.org
Cc: nzolghadr@chromium.org
Owner: lanwei@chromium.org
This is the related change that skipped these tests.
https://codereview.chromium.org/2053653002

Blocking: 625836
Labels: -Pri-3 Pri-2
In principle, we should not land a CL causing new leaks. Please revert such CL next time when you find this causes new leaks.

Labels: -Pri-2 Pri-1
Raising the priority to P1.

Cc: -nzolghadr@chromium.org lanwei@chromium.org
Owner: nzolghadr@chromium.org
Status: Started (was: Assigned)
The CL was the test itself and no other change. That is why we didn't revert it in the first place until we find the problem. I'm working on a workaround for it right now.
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62234589a64896729acb4a53c874e775aefb3daf

commit 62234589a64896729acb4a53c874e775aefb3daf
Author: nzolghadr <nzolghadr@chromium.org>
Date: Thu Sep 01 19:51:50 2016

Make tests wait until automation is done to prevent leaks

Adding an umbrella test that waits on the promise returned
by inject_input method so that it makes sure the input
automation is done before the whole test passes and
finishes the test. This prevent the leak that was
happening before as the result of closing the test
early.

BUG= 619060 

Review-Url: https://codereview.chromium.org/2300623004
Cr-Commit-Position: refs/heads/master@{#416025}

[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/LeakExpectations
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/1dbd4c9de403122e7cdb78d361b5785b85249b0b/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_button_attribute_mouse-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_capture_mouse-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_capture_suppressing_mouse-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_change-touch-action-onpointerdown_touch-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_common_input.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_gotpointercapture_before_first_pointerevent-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_lostpointercapture_for_disconnected_node-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_lostpointercapture_is_first-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointercancel_touch-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerdown-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerenter-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerenter_does_not_bubble-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerenter_nohover-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerleave_after_pointercancel_touch-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerleave_after_pointerup_nohover-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerleave_descendant_over-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerleave_does_not_bubble-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerleave_mouse-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerleave_pen-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerleave_touch-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointermove-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointermove_isprimary_same_as_pointerdown-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointermove_pointertype-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerout-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerout_after_pointercancel_touch-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerout_after_pointerup_nohover-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerout_pen-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerout_received_once-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerover-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointertype_mouse-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointertype_pen-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointertype_touch-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerup-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerup_isprimary_same_as_pointerdown-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerup_pointertype-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_releasepointercapture_events_to_original_target-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_releasepointercapture_invalid_pointerid-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_releasepointercapture_onpointercancel_touch-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_releasepointercapture_onpointerup_mouse-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_setpointercapture_disconnected-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_setpointercapture_inactive_button_mouse-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_setpointercapture_invalid_pointerid-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_setpointercapture_relatedtarget-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-auto-css_touch-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-inherit_highest-parent-none_touch-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-keyboard-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-mouse-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-none-css_touch-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-pan-x-css_touch-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-pan-x-pan-y_touch-manual-automation.js
[modify] https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-pan-y-css_touch-manual-automation.js

Status: Fixed (was: Started)
Labels: PointerEvent

Sign in to add a comment