New issue
Advanced search Search tips

Issue 619059 link

Starred by 1 user
Status: Fixed
Owner:
rtoy@chromium.org
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Oscillator.frequency.minValue is incorrect

Project Member Reported by rtoy@chromium.org, Jun 10 2016 

OS: All

What steps will reproduce the problem?
(1) In Chrome canary, run

c = new AudioContext()
o = c.createOscillator()
o.frequency.minValue


What is the expected output?
o.frequency.minValue = -o.frequency.maxValue

What do you see instead?
o.frequency.minValue = 0

This is a very recent change in the webaudio spec.  The min frequency value for an oscillator has changed from 0 to - Nyquist.

See issue https://github.com/WebAudio/web-audio-api/issues/813
See fix https://github.com/WebAudio/web-audio-api/pull/838

Comment 1 by rtoy@chromium.org, Jun 10 2016

Owner: rtoy@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5221add5997d445349f6eb3f5b88dc99a79af3f

commit a5221add5997d445349f6eb3f5b88dc99a79af3f
Author: rtoy <rtoy@chromium.org>
Date: Wed Jun 15 18:30:43 2016

Use correct value for Oscillator.frequency.minValue

The minimum value for the Oscillator.frequency parameter is -Nyquist,
not 0.

See issue: https://github.com/WebAudio/web-audio-api/issues/813
Resolved in: https://github.com/WebAudio/web-audio-api/pull/838

BUG= 619059 
TEST=osc-negative-freq.html, updated audioparam-nominal-range.html

Review-Url: https://codereview.chromium.org/2059823002
Cr-Commit-Position: refs/heads/master@{#399965}

[modify] https://crrev.com/a5221add5997d445349f6eb3f5b88dc99a79af3f/third_party/WebKit/LayoutTests/webaudio/audioparam-nominal-range-expected.txt
[modify] https://crrev.com/a5221add5997d445349f6eb3f5b88dc99a79af3f/third_party/WebKit/LayoutTests/webaudio/audioparam-nominal-range.html
[modify] https://crrev.com/a5221add5997d445349f6eb3f5b88dc99a79af3f/third_party/WebKit/LayoutTests/webaudio/osc-custom-sweep-snr-expected.txt
[add] https://crrev.com/a5221add5997d445349f6eb3f5b88dc99a79af3f/third_party/WebKit/LayoutTests/webaudio/osc-negative-freq-expected.txt
[add] https://crrev.com/a5221add5997d445349f6eb3f5b88dc99a79af3f/third_party/WebKit/LayoutTests/webaudio/osc-negative-freq.html
[modify] https://crrev.com/a5221add5997d445349f6eb3f5b88dc99a79af3f/third_party/WebKit/LayoutTests/webaudio/osc-sawtooth-sweep-snr-expected.txt
[modify] https://crrev.com/a5221add5997d445349f6eb3f5b88dc99a79af3f/third_party/WebKit/LayoutTests/webaudio/osc-sine-sweep-snr-expected.txt
[modify] https://crrev.com/a5221add5997d445349f6eb3f5b88dc99a79af3f/third_party/WebKit/LayoutTests/webaudio/osc-square-sweep-snr-expected.txt
[modify] https://crrev.com/a5221add5997d445349f6eb3f5b88dc99a79af3f/third_party/WebKit/LayoutTests/webaudio/osc-triangle-sweep-snr-expected.txt
[modify] https://crrev.com/a5221add5997d445349f6eb3f5b88dc99a79af3f/third_party/WebKit/LayoutTests/webaudio/periodicwave-contexts-expected.txt
[modify] https://crrev.com/a5221add5997d445349f6eb3f5b88dc99a79af3f/third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp

Comment 3 by rtoy@chromium.org, Jun 17 2016

Status: Fixed (was: Started)
►

Sign in to add a comment