New issue
Advanced search Search tips

Issue 619055 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature

Blocked on:
issue 648222

Blocking:
issue 617655



Sign in to add a comment

Implement @RetryOnFailure

Project Member Reported by jbudorick@chromium.org, Jun 10 2016

Issue description

@RetryOnFailure will be a java annotation that signals the test runner that a test should be retried twice on failure. Tests without this annotation will not be retried. See https://docs.google.com/a/google.com/document/d/188AQGAEvqPSLnyYqy7TC7_UeVxSWgHZ5YyV_BjZq4F4/edit?usp=sharing for more background.
 

Comment 1 by boliu@chromium.org, Jun 10 2016

That doc is not meant to be public. I'll post a public version soon.
I didn't change the ACLs on it, so it's still not public.

Comment 3 by boliu@chromium.org, Jun 10 2016

That comment was for the non-google person who asked for access :p
Labels: -Type-Bug Type-Feature

Comment 6 by boliu@chromium.org, Jun 22 2016

Ok, we should work out a policy to decide which existing tests need to be marked with.

I want to limit to only checking bots that affect the main waterfall and cq. So those are would be:
chromium.linux:Android Tests
chromium.linux:Android Tests (dbg)
chromium.android:Android Swarm Builder

I also see "chromium.android:Android N5X Swarm Builder" now. Is that going to be promoted to cq soon too? Should I take that into account as well?

For policy, how about: any red/grey box on the flakiness dashboard means the test needs to be marked RetryOnFailure. I'd like some better criteria like "no flake in last 100 runs", but I don't know how flakiness dashboard tracks number of runs, when it drops old data etc..

Is there any way I can get this raw data? Manually parsing flakiness dashboard is kinda.. manual.
The suites we should care about looking at for now would be:
 - android_webview_test_apk
 - blimp_test_apk
 - chrome_public_test_apk
 - chrome_sync_shell_test_apk
 - content_shell_test_apk

We may have to do some dremel work for the raw data.

Comment 8 by boliu@chromium.org, Jun 23 2016

err, got hints in how to start investigating that dremel work?
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1dd26c8c1c6ffc149f46483b56d20ff71cd35732

commit 1dd26c8c1c6ffc149f46483b56d20ff71cd35732
Author: boliu <boliu@chromium.org>
Date: Sat Jun 25 00:49:17 2016

android: Add RetryOnFailure test annotation

Note this annotation does not do anything yet without script changes.

BUG= 619055 

Review-Url: https://codereview.chromium.org/2088093003
Cr-Commit-Position: refs/heads/master@{#402030}

[modify] https://crrev.com/1dd26c8c1c6ffc149f46483b56d20ff71cd35732/base/BUILD.gn
[add] https://crrev.com/1dd26c8c1c6ffc149f46483b56d20ff71cd35732/base/test/android/javatests/src/org/chromium/base/test/util/RetryOnFailure.java

List of tests that's going to be marked @RetryOnFailure:
https://docs.google.com/spreadsheets/d/1oj7uFiYycBZ464QBe4T7P3mzHMko2ttg4HHiGWKvkpE/edit?usp=sharing

There's a lot :/
Project Member

Comment 13 by bugdroid1@chromium.org, Sep 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0aff1eac5fa6f1de74aba0e77e86eefd29bf20e6

commit 0aff1eac5fa6f1de74aba0e77e86eefd29bf20e6
Author: boliu <boliu@chromium.org>
Date: Fri Sep 09 18:16:11 2016

base: Allow RetryOnFailure to apply to a class

There are classes where all the tests are flaky.

BUG= 619055 

Review-Url: https://codereview.chromium.org/2327843002
Cr-Commit-Position: refs/heads/master@{#417636}

[modify] https://crrev.com/0aff1eac5fa6f1de74aba0e77e86eefd29bf20e6/base/test/android/javatests/src/org/chromium/base/test/util/RetryOnFailure.java

Project Member

Comment 14 by bugdroid1@chromium.org, Sep 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3fe3ee3160bae8f17a1e56d60310465eb6b281c

commit a3fe3ee3160bae8f17a1e56d60310465eb6b281c
Author: boliu <boliu@chromium.org>
Date: Fri Sep 09 19:09:28 2016

Mark flaky chrome_public tests with @RetryOnFailure Batch 1

BUG= 619055 

Review-Url: https://codereview.chromium.org/2327673002
Cr-Commit-Position: refs/heads/master@{#417658}

[modify] https://crrev.com/a3fe3ee3160bae8f17a1e56d60310465eb6b281c/chrome/android/javatests/src/org/chromium/chrome/browser/BackgroundSyncLauncherTest.java
[modify] https://crrev.com/a3fe3ee3160bae8f17a1e56d60310465eb6b281c/chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java
[modify] https://crrev.com/a3fe3ee3160bae8f17a1e56d60310465eb6b281c/chrome/android/javatests/src/org/chromium/chrome/browser/BluetoothChooserDialogTest.java
[modify] https://crrev.com/a3fe3ee3160bae8f17a1e56d60310465eb6b281c/chrome/android/javatests/src/org/chromium/chrome/browser/ChromeActivityTest.java
[modify] https://crrev.com/a3fe3ee3160bae8f17a1e56d60310465eb6b281c/chrome/android/javatests/src/org/chromium/chrome/browser/ChromeBackgroundServiceTest.java
[modify] https://crrev.com/a3fe3ee3160bae8f17a1e56d60310465eb6b281c/chrome/android/javatests/src/org/chromium/chrome/browser/appmenu/AppMenuTest.java
[modify] https://crrev.com/a3fe3ee3160bae8f17a1e56d60310465eb6b281c/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryTest.java
[modify] https://crrev.com/a3fe3ee3160bae8f17a1e56d60310465eb6b281c/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java
[modify] https://crrev.com/a3fe3ee3160bae8f17a1e56d60310465eb6b281c/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupWithKeyboardTest.java
[modify] https://crrev.com/a3fe3ee3160bae8f17a1e56d60310465eb6b281c/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTest.java
[modify] https://crrev.com/a3fe3ee3160bae8f17a1e56d60310465eb6b281c/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java
[modify] https://crrev.com/a3fe3ee3160bae8f17a1e56d60310465eb6b281c/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
[modify] https://crrev.com/a3fe3ee3160bae8f17a1e56d60310465eb6b281c/chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java
[modify] https://crrev.com/a3fe3ee3160bae8f17a1e56d60310465eb6b281c/chrome/android/javatests/src/org/chromium/chrome/browser/bookmarks/BookmarkTest.java
[modify] https://crrev.com/a3fe3ee3160bae8f17a1e56d60310465eb6b281c/chrome/android/javatests/src/org/chromium/chrome/browser/browsing_data/BrowsingDataRemoverIntegrationTest.java
[modify] https://crrev.com/a3fe3ee3160bae8f17a1e56d60310465eb6b281c/chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java
[modify] https://crrev.com/a3fe3ee3160bae8f17a1e56d60310465eb6b281c/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
[modify] https://crrev.com/a3fe3ee3160bae8f17a1e56d60310465eb6b281c/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicyTest.java
[modify] https://crrev.com/a3fe3ee3160bae8f17a1e56d60310465eb6b281c/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchRequestTest.java
[modify] https://crrev.com/a3fe3ee3160bae8f17a1e56d60310465eb6b281c/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java

Project Member

Comment 15 by bugdroid1@chromium.org, Sep 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ae2b8a7f9013369f944b24935c8b6bfb9ea13f4

commit 5ae2b8a7f9013369f944b24935c8b6bfb9ea13f4
Author: boliu <boliu@chromium.org>
Date: Fri Sep 09 19:19:43 2016

Mark flaky content tests with @RetryOnFailure

BUG= 619055 

Review-Url: https://codereview.chromium.org/2323993002
Cr-Commit-Position: refs/heads/master@{#417662}

[modify] https://crrev.com/5ae2b8a7f9013369f944b24935c8b6bfb9ea13f4/content/public/android/javatests/src/org/chromium/content/browser/AddressDetectionTest.java
[modify] https://crrev.com/5ae2b8a7f9013369f944b24935c8b6bfb9ea13f4/content/public/android/javatests/src/org/chromium/content/browser/ClickListenerTest.java
[modify] https://crrev.com/5ae2b8a7f9013369f944b24935c8b6bfb9ea13f4/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java
[modify] https://crrev.com/5ae2b8a7f9013369f944b24935c8b6bfb9ea13f4/content/public/android/javatests/src/org/chromium/content/browser/ContentViewPopupZoomerTest.java
[modify] https://crrev.com/5ae2b8a7f9013369f944b24935c8b6bfb9ea13f4/content/public/android/javatests/src/org/chromium/content/browser/ContentViewScrollingTest.java
[modify] https://crrev.com/5ae2b8a7f9013369f944b24935c8b6bfb9ea13f4/content/public/android/javatests/src/org/chromium/content/browser/GestureDetectorResetTest.java
[modify] https://crrev.com/5ae2b8a7f9013369f944b24935c8b6bfb9ea13f4/content/public/android/javatests/src/org/chromium/content/browser/InterfaceRegistryTest.java
[modify] https://crrev.com/5ae2b8a7f9013369f944b24935c8b6bfb9ea13f4/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeChildFrameTest.java
[modify] https://crrev.com/5ae2b8a7f9013369f944b24935c8b6bfb9ea13f4/content/public/android/javatests/src/org/chromium/content/browser/MediaSessionTest.java
[modify] https://crrev.com/5ae2b8a7f9013369f944b24935c8b6bfb9ea13f4/content/public/android/javatests/src/org/chromium/content/browser/PhoneNumberDetectionTest.java
[modify] https://crrev.com/5ae2b8a7f9013369f944b24935c8b6bfb9ea13f4/content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationListenerTest.java
[modify] https://crrev.com/5ae2b8a7f9013369f944b24935c8b6bfb9ea13f4/content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationProviderTest.java
[modify] https://crrev.com/5ae2b8a7f9013369f944b24935c8b6bfb9ea13f4/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
[modify] https://crrev.com/5ae2b8a7f9013369f944b24935c8b6bfb9ea13f4/content/public/android/javatests/src/org/chromium/content/browser/input/SelectPopupTest.java
[modify] https://crrev.com/5ae2b8a7f9013369f944b24935c8b6bfb9ea13f4/content/shell/android/javatests/src/org/chromium/content_shell_apk/ContentShellShellManagementTest.java

Project Member

Comment 16 by bugdroid1@chromium.org, Sep 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f4e2da985ec09fcd00f25a42ede6d4ca25d2727

commit 0f4e2da985ec09fcd00f25a42ede6d4ca25d2727
Author: boliu <boliu@chromium.org>
Date: Fri Sep 09 23:27:16 2016

Mark flaky chrome_public tests with @RetryOnFailure Batch 2

BUG= 619055 
TBR=tedchoc

Review-Url: https://codereview.chromium.org/2331533002
Cr-Commit-Position: refs/heads/master@{#417761}

[modify] https://crrev.com/0f4e2da985ec09fcd00f25a42ede6d4ca25d2727/chrome/android/javatests/src/org/chromium/chrome/browser/GeolocationTest.java
[modify] https://crrev.com/0f4e2da985ec09fcd00f25a42ede6d4ca25d2727/chrome/android/javatests/src/org/chromium/chrome/browser/HistoryUITest.java
[modify] https://crrev.com/0f4e2da985ec09fcd00f25a42ede6d4ca25d2727/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/ClientManagerTest.java
[modify] https://crrev.com/0f4e2da985ec09fcd00f25a42ede6d4ca25d2727/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
[modify] https://crrev.com/0f4e2da985ec09fcd00f25a42ede6d4ca25d2727/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabExternalNavigationTest.java
[modify] https://crrev.com/0f4e2da985ec09fcd00f25a42ede6d4ca25d2727/chrome/android/javatests/src/org/chromium/chrome/browser/document/LauncherActivityTest.java
[modify] https://crrev.com/0f4e2da985ec09fcd00f25a42ede6d4ca25d2727/chrome/android/javatests/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManagerTest.java
[modify] https://crrev.com/0f4e2da985ec09fcd00f25a42ede6d4ca25d2727/chrome/android/javatests/src/org/chromium/chrome/browser/download/ChromeDownloadDelegateTest.java
[modify] https://crrev.com/0f4e2da985ec09fcd00f25a42ede6d4ca25d2727/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java
[modify] https://crrev.com/0f4e2da985ec09fcd00f25a42ede6d4ca25d2727/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadTest.java
[modify] https://crrev.com/0f4e2da985ec09fcd00f25a42ede6d4ca25d2727/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImplTest.java
[modify] https://crrev.com/0f4e2da985ec09fcd00f25a42ede6d4ca25d2727/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java
[modify] https://crrev.com/0f4e2da985ec09fcd00f25a42ede6d4ca25d2727/chrome/android/javatests/src/org/chromium/chrome/browser/feedback/FeedbackCollectorTest.java
[modify] https://crrev.com/0f4e2da985ec09fcd00f25a42ede6d4ca25d2727/chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationTest.java
[modify] https://crrev.com/0f4e2da985ec09fcd00f25a42ede6d4ca25d2727/chrome/android/javatests/src/org/chromium/chrome/browser/fullscreen/FullscreenManagerTest.java
[modify] https://crrev.com/0f4e2da985ec09fcd00f25a42ede6d4ca25d2727/chrome/android/javatests/src/org/chromium/chrome/browser/hardware_acceleration/CustomTabActivityHWATest.java
[modify] https://crrev.com/0f4e2da985ec09fcd00f25a42ede6d4ca25d2727/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarContainerTest.java
[modify] https://crrev.com/0f4e2da985ec09fcd00f25a42ede6d4ca25d2727/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarTest.java

Project Member

Comment 17 by bugdroid1@chromium.org, Sep 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7532546c368710e3b5c8b935151d3e60599ca6e

commit d7532546c368710e3b5c8b935151d3e60599ca6e
Author: boliu <boliu@chromium.org>
Date: Mon Sep 12 18:16:09 2016

Mark all chrome sync tests with @RetryOnFailure

Current theory is all chrome sync tests are flaky due to
 crbug.com/637448 . So mark all of them as requiring retry.

BUG= 619055 ,  637448 

Review-Url: https://codereview.chromium.org/2319863004
Cr-Commit-Position: refs/heads/master@{#417974}

[modify] https://crrev.com/d7532546c368710e3b5c8b935151d3e60599ca6e/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/AutofillTest.java
[modify] https://crrev.com/d7532546c368710e3b5c8b935151d3e60599ca6e/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/BookmarksTest.java
[modify] https://crrev.com/d7532546c368710e3b5c8b935151d3e60599ca6e/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/FirstRunTest.java
[modify] https://crrev.com/d7532546c368710e3b5c8b935151d3e60599ca6e/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/GmsCoreSyncListenerTest.java
[modify] https://crrev.com/d7532546c368710e3b5c8b935151d3e60599ca6e/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/OpenTabsTest.java
[modify] https://crrev.com/d7532546c368710e3b5c8b935151d3e60599ca6e/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncCustomizationFragmentTest.java
[modify] https://crrev.com/d7532546c368710e3b5c8b935151d3e60599ca6e/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java
[modify] https://crrev.com/d7532546c368710e3b5c8b935151d3e60599ca6e/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/TypedUrlsTest.java
[modify] https://crrev.com/d7532546c368710e3b5c8b935151d3e60599ca6e/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/ui/PassphraseTypeDialogFragmentTest.java

Project Member

Comment 18 by bugdroid1@chromium.org, Sep 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4821dc8727a2dd9554e01adceea465edd5b7fb87

commit 4821dc8727a2dd9554e01adceea465edd5b7fb87
Author: boliu <boliu@chromium.org>
Date: Mon Sep 12 19:21:43 2016

Mark flaky chrome_public tests with @RetryOnFailure Batch 3

BUG= 619055 
TBR=tedchoc@chromium.org

Review-Url: https://codereview.chromium.org/2332063002
Cr-Commit-Position: refs/heads/master@{#417997}

[modify] https://crrev.com/4821dc8727a2dd9554e01adceea465edd5b7fb87/chrome/android/javatests/src/org/chromium/chrome/browser/ItemChooserDialogTest.java
[modify] https://crrev.com/4821dc8727a2dd9554e01adceea465edd5b7fb87/chrome/android/javatests/src/org/chromium/chrome/browser/JavaScriptEvalChromeTest.java
[modify] https://crrev.com/4821dc8727a2dd9554e01adceea465edd5b7fb87/chrome/android/javatests/src/org/chromium/chrome/browser/MainActivityWithURLTest.java
[modify] https://crrev.com/4821dc8727a2dd9554e01adceea465edd5b7fb87/chrome/android/javatests/src/org/chromium/chrome/browser/ModalDialogTest.java
[modify] https://crrev.com/4821dc8727a2dd9554e01adceea465edd5b7fb87/chrome/android/javatests/src/org/chromium/chrome/browser/NavigateTest.java
[modify] https://crrev.com/4821dc8727a2dd9554e01adceea465edd5b7fb87/chrome/android/javatests/src/org/chromium/chrome/browser/NavigationPopupTest.java
[modify] https://crrev.com/4821dc8727a2dd9554e01adceea465edd5b7fb87/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java
[modify] https://crrev.com/4821dc8727a2dd9554e01adceea465edd5b7fb87/chrome/android/javatests/src/org/chromium/chrome/browser/invalidation/ChromeBrowserSyncAdapterTest.java
[modify] https://crrev.com/4821dc8727a2dd9554e01adceea465edd5b7fb87/chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastNotificationTest.java
[modify] https://crrev.com/4821dc8727a2dd9554e01adceea465edd5b7fb87/chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastPositionTransferTest.java
[modify] https://crrev.com/4821dc8727a2dd9554e01adceea465edd5b7fb87/chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastStartStopTest.java
[modify] https://crrev.com/4821dc8727a2dd9554e01adceea465edd5b7fb87/chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastVideoControlsTest.java
[modify] https://crrev.com/4821dc8727a2dd9554e01adceea465edd5b7fb87/chrome/android/javatests/src/org/chromium/chrome/browser/media/router/MediaRouterIntegrationTest.java
[modify] https://crrev.com/4821dc8727a2dd9554e01adceea465edd5b7fb87/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java
[modify] https://crrev.com/4821dc8727a2dd9554e01adceea465edd5b7fb87/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/PauseOnHeadsetUnplugTest.java
[modify] https://crrev.com/4821dc8727a2dd9554e01adceea465edd5b7fb87/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeIntentTest.java
[modify] https://crrev.com/4821dc8727a2dd9554e01adceea465edd5b7fb87/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeTest.java
[modify] https://crrev.com/4821dc8727a2dd9554e01adceea465edd5b7fb87/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageNavigationTest.java
[modify] https://crrev.com/4821dc8727a2dd9554e01adceea465edd5b7fb87/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java
[modify] https://crrev.com/4821dc8727a2dd9554e01adceea465edd5b7fb87/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java
[modify] https://crrev.com/4821dc8727a2dd9554e01adceea465edd5b7fb87/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
[modify] https://crrev.com/4821dc8727a2dd9554e01adceea465edd5b7fb87/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageRequestTest.java
[modify] https://crrev.com/4821dc8727a2dd9554e01adceea465edd5b7fb87/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java
[modify] https://crrev.com/4821dc8727a2dd9554e01adceea465edd5b7fb87/chrome/android/javatests/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelperTest.java
[modify] https://crrev.com/4821dc8727a2dd9554e01adceea465edd5b7fb87/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java
[modify] https://crrev.com/4821dc8727a2dd9554e01adceea465edd5b7fb87/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/UrlBarTest.java

Project Member

Comment 19 by bugdroid1@chromium.org, Sep 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3900bc1881115521246c66d6c14bd30f31fb200

commit a3900bc1881115521246c66d6c14bd30f31fb200
Author: boliu <boliu@chromium.org>
Date: Tue Sep 13 19:04:33 2016

Mark flaky chrome_public tests with @RetryOnFailure Batch 4

BUG= 619055 
TBR=tedchoc@chromium.org

Review-Url: https://codereview.chromium.org/2334133003
Cr-Commit-Position: refs/heads/master@{#418323}

[modify] https://crrev.com/a3900bc1881115521246c66d6c14bd30f31fb200/chrome/android/javatests/src/org/chromium/chrome/browser/OSKOverscrollTest.java
[modify] https://crrev.com/a3900bc1881115521246c66d6c14bd30f31fb200/chrome/android/javatests/src/org/chromium/chrome/browser/PopupTest.java
[modify] https://crrev.com/a3900bc1881115521246c66d6c14bd30f31fb200/chrome/android/javatests/src/org/chromium/chrome/browser/PowerBroadcastReceiverTest.java
[modify] https://crrev.com/a3900bc1881115521246c66d6c14bd30f31fb200/chrome/android/javatests/src/org/chromium/chrome/browser/partnercustomizations/PartnerDisableIncognitoModeIntegrationTest.java
[modify] https://crrev.com/a3900bc1881115521246c66d6c14bd30f31fb200/chrome/android/javatests/src/org/chromium/chrome/browser/partnercustomizations/PartnerHomepageIntegrationTest.java
[modify] https://crrev.com/a3900bc1881115521246c66d6c14bd30f31fb200/chrome/android/javatests/src/org/chromium/chrome/browser/partnercustomizations/PartnerHomepageUnitTest.java
[modify] https://crrev.com/a3900bc1881115521246c66d6c14bd30f31fb200/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestAbortTest.java
[modify] https://crrev.com/a3900bc1881115521246c66d6c14bd30f31fb200/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsAndFreeShippingTest.java
[modify] https://crrev.com/a3900bc1881115521246c66d6c14bd30f31fb200/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java
[modify] https://crrev.com/a3900bc1881115521246c66d6c14bd30f31fb200/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDynamicShippingMultipleAddressesTest.java
[modify] https://crrev.com/a3900bc1881115521246c66d6c14bd30f31fb200/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDynamicShippingSingleAddressTest.java
[modify] https://crrev.com/a3900bc1881115521246c66d6c14bd30f31fb200/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmailAndFreeShippingTest.java
[modify] https://crrev.com/a3900bc1881115521246c66d6c14bd30f31fb200/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmailTest.java
[modify] https://crrev.com/a3900bc1881115521246c66d6c14bd30f31fb200/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFailCompleteTest.java
[modify] https://crrev.com/a3900bc1881115521246c66d6c14bd30f31fb200/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java
[modify] https://crrev.com/a3900bc1881115521246c66d6c14bd30f31fb200/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteContactDetailsTest.java
[modify] https://crrev.com/a3900bc1881115521246c66d6c14bd30f31fb200/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteEmailTest.java
[modify] https://crrev.com/a3900bc1881115521246c66d6c14bd30f31fb200/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompletePhoneTest.java
[modify] https://crrev.com/a3900bc1881115521246c66d6c14bd30f31fb200/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteServerCardTest.java
[modify] https://crrev.com/a3900bc1881115521246c66d6c14bd30f31fb200/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java
[modify] https://crrev.com/a3900bc1881115521246c66d6c14bd30f31fb200/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMultipleContactDetailsTest.java
[modify] https://crrev.com/a3900bc1881115521246c66d6c14bd30f31fb200/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java
[modify] https://crrev.com/a3900bc1881115521246c66d6c14bd30f31fb200/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppAndCardsTest.java
[modify] https://crrev.com/a3900bc1881115521246c66d6c14bd30f31fb200/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppTest.java
[modify] https://crrev.com/a3900bc1881115521246c66d6c14bd30f31fb200/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPhoneAndFreeShippingTest.java
[modify] https://crrev.com/a3900bc1881115521246c66d6c14bd30f31fb200/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPhoneTest.java
[modify] https://crrev.com/a3900bc1881115521246c66d6c14bd30f31fb200/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestRemoveBillingAddressTest.java
[modify] https://crrev.com/a3900bc1881115521246c66d6c14bd30f31fb200/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestServerCardTest.java
[modify] https://crrev.com/a3900bc1881115521246c66d6c14bd30f31fb200/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShowTwiceTest.java
[modify] https://crrev.com/a3900bc1881115521246c66d6c14bd30f31fb200/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestUseStatsTest.java
[modify] https://crrev.com/a3900bc1881115521246c66d6c14bd30f31fb200/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivityTest.java
[modify] https://crrev.com/a3900bc1881115521246c66d6c14bd30f31fb200/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java
[modify] https://crrev.com/a3900bc1881115521246c66d6c14bd30f31fb200/chrome/android/javatests/src/org/chromium/chrome/browser/policy/CombinedPolicyProviderTest.java
[modify] https://crrev.com/a3900bc1881115521246c66d6c14bd30f31fb200/chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheUMATest.java
[modify] https://crrev.com/a3900bc1881115521246c66d6c14bd30f31fb200/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java
[modify] https://crrev.com/a3900bc1881115521246c66d6c14bd30f31fb200/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/website/ManageSpaceActivityTest.java
[modify] https://crrev.com/a3900bc1881115521246c66d6c14bd30f31fb200/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferencesTest.java

Project Member

Comment 20 by bugdroid1@chromium.org, Sep 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a2a1fcd1bf0255476368cc331b27c619f6fd2f6

commit 2a2a1fcd1bf0255476368cc331b27c619f6fd2f6
Author: boliu <boliu@chromium.org>
Date: Wed Sep 14 18:55:55 2016

Mark flaky chrome_public tests with @RetryOnFailure Batch 5

BUG= 619055 
TBR=tedchoc@chromium.org

Review-Url: https://codereview.chromium.org/2336803005
Cr-Commit-Position: refs/heads/master@{#418624}

[modify] https://crrev.com/2a2a1fcd1bf0255476368cc331b27c619f6fd2f6/chrome/android/javatests/src/org/chromium/chrome/browser/ProcessIsolationTest.java
[modify] https://crrev.com/2a2a1fcd1bf0255476368cc331b27c619f6fd2f6/chrome/android/javatests/src/org/chromium/chrome/browser/RepostFormWarningTest.java
[modify] https://crrev.com/2a2a1fcd1bf0255476368cc331b27c619f6fd2f6/chrome/android/javatests/src/org/chromium/chrome/browser/SelectFileDialogTest.java
[modify] https://crrev.com/2a2a1fcd1bf0255476368cc331b27c619f6fd2f6/chrome/android/javatests/src/org/chromium/chrome/browser/ShareIntentTest.java
[modify] https://crrev.com/2a2a1fcd1bf0255476368cc331b27c619f6fd2f6/chrome/android/javatests/src/org/chromium/chrome/browser/SmartClipProviderTest.java
[modify] https://crrev.com/2a2a1fcd1bf0255476368cc331b27c619f6fd2f6/chrome/android/javatests/src/org/chromium/chrome/browser/TabCountLabelTest.java
[modify] https://crrev.com/2a2a1fcd1bf0255476368cc331b27c619f6fd2f6/chrome/android/javatests/src/org/chromium/chrome/browser/TabTest.java
[modify] https://crrev.com/2a2a1fcd1bf0255476368cc331b27c619f6fd2f6/chrome/android/javatests/src/org/chromium/chrome/browser/TabThemeTest.java
[modify] https://crrev.com/2a2a1fcd1bf0255476368cc331b27c619f6fd2f6/chrome/android/javatests/src/org/chromium/chrome/browser/TabsOpenedFromExternalAppTest.java
[modify] https://crrev.com/2a2a1fcd1bf0255476368cc331b27c619f6fd2f6/chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java
[modify] https://crrev.com/2a2a1fcd1bf0255476368cc331b27c619f6fd2f6/chrome/android/javatests/src/org/chromium/chrome/browser/printing/PrintingControllerTest.java
[modify] https://crrev.com/2a2a1fcd1bf0255476368cc331b27c619f6fd2f6/chrome/android/javatests/src/org/chromium/chrome/browser/provider/ProviderBookmarksUriTest.java
[modify] https://crrev.com/2a2a1fcd1bf0255476368cc331b27c619f6fd2f6/chrome/android/javatests/src/org/chromium/chrome/browser/provider/ProviderSearchesUriTest.java
[modify] https://crrev.com/2a2a1fcd1bf0255476368cc331b27c619f6fd2f6/chrome/android/javatests/src/org/chromium/chrome/browser/push_messaging/PushMessagingTest.java
[modify] https://crrev.com/2a2a1fcd1bf0255476368cc331b27c619f6fd2f6/chrome/android/javatests/src/org/chromium/chrome/browser/search_engines/TemplateUrlServiceTest.java
[modify] https://crrev.com/2a2a1fcd1bf0255476368cc331b27c619f6fd2f6/chrome/android/javatests/src/org/chromium/chrome/browser/signin/OAuth2TokenServiceIntegrationTest.java
[modify] https://crrev.com/2a2a1fcd1bf0255476368cc331b27c619f6fd2f6/chrome/android/javatests/src/org/chromium/chrome/browser/signin/SigninHelperTest.java
[modify] https://crrev.com/2a2a1fcd1bf0255476368cc331b27c619f6fd2f6/chrome/android/javatests/src/org/chromium/chrome/browser/snackbar/SnackbarTest.java
[modify] https://crrev.com/2a2a1fcd1bf0255476368cc331b27c619f6fd2f6/chrome/android/javatests/src/org/chromium/chrome/browser/superviseduser/SupervisedUserContentProviderTest.java
[modify] https://crrev.com/2a2a1fcd1bf0255476368cc331b27c619f6fd2f6/chrome/android/javatests/src/org/chromium/chrome/browser/tab/InterceptNavigationDelegateTest.java
[modify] https://crrev.com/2a2a1fcd1bf0255476368cc331b27c619f6fd2f6/chrome/android/javatests/src/org/chromium/chrome/browser/tab/SadTabTest.java
[modify] https://crrev.com/2a2a1fcd1bf0255476368cc331b27c619f6fd2f6/chrome/android/javatests/src/org/chromium/chrome/browser/tab/TabRedirectHandlerTest.java
[modify] https://crrev.com/2a2a1fcd1bf0255476368cc331b27c619f6fd2f6/chrome/android/javatests/src/org/chromium/chrome/browser/tab/TabUmaTest.java
[modify] https://crrev.com/2a2a1fcd1bf0255476368cc331b27c619f6fd2f6/chrome/android/javatests/src/org/chromium/chrome/browser/tab/UndoIntegrationTest.java
[modify] https://crrev.com/2a2a1fcd1bf0255476368cc331b27c619f6fd2f6/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/ContextMenuLoadUrlParamsTest.java
[modify] https://crrev.com/2a2a1fcd1bf0255476368cc331b27c619f6fd2f6/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/IncognitoTabModelTest.java
[modify] https://crrev.com/2a2a1fcd1bf0255476368cc331b27c619f6fd2f6/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/RestoreMigrateTest.java
[modify] https://crrev.com/2a2a1fcd1bf0255476368cc331b27c619f6fd2f6/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabPersistentStoreTest.java
[modify] https://crrev.com/2a2a1fcd1bf0255476368cc331b27c619f6fd2f6/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/UndoTabModelTest.java
[modify] https://crrev.com/2a2a1fcd1bf0255476368cc331b27c619f6fd2f6/chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/BrandColorTest.java
[modify] https://crrev.com/2a2a1fcd1bf0255476368cc331b27c619f6fd2f6/chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/ToolbarModelTest.java

Project Member

Comment 21 by bugdroid1@chromium.org, Sep 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01e7b50e4595b2b6c59141f3c9b96fdbfe7c37f9

commit 01e7b50e4595b2b6c59141f3c9b96fdbfe7c37f9
Author: boliu <boliu@chromium.org>
Date: Wed Sep 14 19:38:33 2016

Mark flaky chrome_public tests with @RetryOnFailure Batch 6

BUG= 619055 
TBR=tedchoc@chromium.org

Review-Url: https://codereview.chromium.org/2337973005
Cr-Commit-Position: refs/heads/master@{#418642}

[modify] https://crrev.com/01e7b50e4595b2b6c59141f3c9b96fdbfe7c37f9/chrome/android/javatests/src/org/chromium/chrome/browser/UrlSchemeTest.java
[modify] https://crrev.com/01e7b50e4595b2b6c59141f3c9b96fdbfe7c37f9/chrome/android/javatests/src/org/chromium/chrome/browser/UsbChooserDialogTest.java
[modify] https://crrev.com/01e7b50e4595b2b6c59141f3c9b96fdbfe7c37f9/chrome/android/javatests/src/org/chromium/chrome/browser/video/VideoTest.java
[modify] https://crrev.com/01e7b50e4595b2b6c59141f3c9b96fdbfe7c37f9/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ActivityAssignerTest.java
[modify] https://crrev.com/01e7b50e4595b2b6c59141f3c9b96fdbfe7c37f9/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogTest.java
[modify] https://crrev.com/01e7b50e4595b2b6c59141f3c9b96fdbfe7c37f9/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenManagerTest.java
[modify] https://crrev.com/01e7b50e4595b2b6c59141f3c9b96fdbfe7c37f9/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcherTest.java
[modify] https://crrev.com/01e7b50e4595b2b6c59141f3c9b96fdbfe7c37f9/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappModeTest.java
[modify] https://crrev.com/01e7b50e4595b2b6c59141f3c9b96fdbfe7c37f9/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenHomescreenIconTest.java
[modify] https://crrev.com/01e7b50e4595b2b6c59141f3c9b96fdbfe7c37f9/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenTest.java
[modify] https://crrev.com/01e7b50e4595b2b6c59141f3c9b96fdbfe7c37f9/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenThemeColorTest.java
[modify] https://crrev.com/01e7b50e4595b2b6c59141f3c9b96fdbfe7c37f9/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappUrlBarTest.java
[modify] https://crrev.com/01e7b50e4595b2b6c59141f3c9b96fdbfe7c37f9/chrome/android/javatests/src/org/chromium/chrome/browser/widget/OverviewListLayoutTest.java
[modify] https://crrev.com/01e7b50e4595b2b6c59141f3c9b96fdbfe7c37f9/chrome/android/javatests/src/org/chromium/chrome/browser/widget/ToolbarProgressBarTest.java
[modify] https://crrev.com/01e7b50e4595b2b6c59141f3c9b96fdbfe7c37f9/chrome/android/javatests/src/org/chromium/chrome/browser/widget/findinpage/FindTest.java
[modify] https://crrev.com/01e7b50e4595b2b6c59141f3c9b96fdbfe7c37f9/chrome/android/javatests/src/org/chromium/chrome/test/ParametersOnMultiTest.java
[modify] https://crrev.com/01e7b50e4595b2b6c59141f3c9b96fdbfe7c37f9/chrome/android/javatests/src/org/chromium/chrome/test/util/parameters/SigninParametersTest.java
[modify] https://crrev.com/01e7b50e4595b2b6c59141f3c9b96fdbfe7c37f9/components/sync/android/javatests/src/org/chromium/components/sync/notifier/InvalidationPreferencesTest.java

Project Member

Comment 22 by bugdroid1@chromium.org, Sep 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a30d6b8aba55469c3a7e405cf5733fde73b11a32

commit a30d6b8aba55469c3a7e405cf5733fde73b11a32
Author: jbudorick <jbudorick@chromium.org>
Date: Sat Sep 17 00:37:51 2016

[Android] Enable @RetryOnFailure.

BUG= 619055 

Review-Url: https://codereview.chromium.org/2348693004
Cr-Commit-Position: refs/heads/master@{#419349}

[modify] https://crrev.com/a30d6b8aba55469c3a7e405cf5733fde73b11a32/build/android/pylib/local/device/local_device_instrumentation_test_run.py

Blockedon: 648222
Project Member

Comment 24 by bugdroid1@chromium.org, Sep 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0abf7f1128d6e42aa565e4547763c120659cd8c6

commit 0abf7f1128d6e42aa565e4547763c120659cd8c6
Author: boliu <boliu@chromium.org>
Date: Mon Sep 19 16:46:01 2016

android: Mark flaky tests with @RetryOnFailure

These are flaky tests detected by chromium-try-flakes.appspot.com
Most of these have not flaked enough to trigger a bug yet, but they did
end up triggering an additional bog run, which is still bad.

BUG= 619055 
TBR=tedchoc@chromium.org

Review-Url: https://codereview.chromium.org/2352713002
Cr-Commit-Position: refs/heads/master@{#419482}

[modify] https://crrev.com/0abf7f1128d6e42aa565e4547763c120659cd8c6/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java
[modify] https://crrev.com/0abf7f1128d6e42aa565e4547763c120659cd8c6/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java
[modify] https://crrev.com/0abf7f1128d6e42aa565e4547763c120659cd8c6/android_webview/javatests/src/org/chromium/android_webview/test/AwZoomTest.java
[modify] https://crrev.com/0abf7f1128d6e42aa565e4547763c120659cd8c6/android_webview/javatests/src/org/chromium/android_webview/test/PopupWindowTest.java
[modify] https://crrev.com/0abf7f1128d6e42aa565e4547763c120659cd8c6/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
[modify] https://crrev.com/0abf7f1128d6e42aa565e4547763c120659cd8c6/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarTest.java
[modify] https://crrev.com/0abf7f1128d6e42aa565e4547763c120659cd8c6/chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastStartStopTest.java
[modify] https://crrev.com/0abf7f1128d6e42aa565e4547763c120659cd8c6/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java
[modify] https://crrev.com/0abf7f1128d6e42aa565e4547763c120659cd8c6/chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheControllerTest.java
[modify] https://crrev.com/0abf7f1128d6e42aa565e4547763c120659cd8c6/chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheLauncherTest.java
[modify] https://crrev.com/0abf7f1128d6e42aa565e4547763c120659cd8c6/chrome/android/javatests/src/org/chromium/chrome/browser/signin/SigninHelperTest.java
[modify] https://crrev.com/0abf7f1128d6e42aa565e4547763c120659cd8c6/chrome/android/javatests/src/org/chromium/chrome/browser/sync/ui/PassphraseActivityTest.java
[modify] https://crrev.com/0abf7f1128d6e42aa565e4547763c120659cd8c6/content/public/android/javatests/src/org/chromium/content/browser/AddressDetectionTest.java
[modify] https://crrev.com/0abf7f1128d6e42aa565e4547763c120659cd8c6/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java
[modify] https://crrev.com/0abf7f1128d6e42aa565e4547763c120659cd8c6/content/public/android/javatests/src/org/chromium/content/browser/ContentViewPopupZoomerTest.java
[modify] https://crrev.com/0abf7f1128d6e42aa565e4547763c120659cd8c6/content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java
[modify] https://crrev.com/0abf7f1128d6e42aa565e4547763c120659cd8c6/content/public/android/javatests/src/org/chromium/content/browser/PhoneNumberDetectionTest.java
[modify] https://crrev.com/0abf7f1128d6e42aa565e4547763c120659cd8c6/content/public/android/javatests/src/org/chromium/content/browser/input/ImeLollipopTest.java
[modify] https://crrev.com/0abf7f1128d6e42aa565e4547763c120659cd8c6/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

Project Member

Comment 25 by bugdroid1@chromium.org, Sep 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86c12836a5162425ab534fb4129e10bd0a05309a

commit 86c12836a5162425ab534fb4129e10bd0a05309a
Author: boliu <boliu@chromium.org>
Date: Tue Sep 20 16:26:00 2016

android: Mark flaky tests with @RetryOnFailure

These are flaky tests detected by chromium-try-flakes.appspot.com
in the last day.

BUG= 619055 
TBR=tedchoc@chromium.org

Review-Url: https://codereview.chromium.org/2353583005
Cr-Commit-Position: refs/heads/master@{#419786}

[modify] https://crrev.com/86c12836a5162425ab534fb4129e10bd0a05309a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java
[modify] https://crrev.com/86c12836a5162425ab534fb4129e10bd0a05309a/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
[modify] https://crrev.com/86c12836a5162425ab534fb4129e10bd0a05309a/android_webview/javatests/src/org/chromium/android_webview/test/MediaAccessPermissionRequestTest.java
[modify] https://crrev.com/86c12836a5162425ab534fb4129e10bd0a05309a/android_webview/javatests/src/org/chromium/android_webview/test/PostMessageTest.java
[modify] https://crrev.com/86c12836a5162425ab534fb4129e10bd0a05309a/chrome/android/javatests/src/org/chromium/chrome/browser/BackgroundSyncLauncherTest.java
[modify] https://crrev.com/86c12836a5162425ab534fb4129e10bd0a05309a/chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java
[modify] https://crrev.com/86c12836a5162425ab534fb4129e10bd0a05309a/chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java
[modify] https://crrev.com/86c12836a5162425ab534fb4129e10bd0a05309a/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionTest.java
[modify] https://crrev.com/86c12836a5162425ab534fb4129e10bd0a05309a/chrome/android/javatests/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManagerTest.java
[modify] https://crrev.com/86c12836a5162425ab534fb4129e10bd0a05309a/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java
[modify] https://crrev.com/86c12836a5162425ab534fb4129e10bd0a05309a/chrome/android/javatests/src/org/chromium/chrome/browser/incognito/IncognitoNotificationServiceTest.java
[modify] https://crrev.com/86c12836a5162425ab534fb4129e10bd0a05309a/chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastStartStopTest.java
[modify] https://crrev.com/86c12836a5162425ab534fb4129e10bd0a05309a/chrome/android/javatests/src/org/chromium/chrome/browser/media/router/MediaRouterIntegrationTest.java
[modify] https://crrev.com/86c12836a5162425ab534fb4129e10bd0a05309a/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/MediaPermissionsTest.java
[modify] https://crrev.com/86c12836a5162425ab534fb4129e10bd0a05309a/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
[modify] https://crrev.com/86c12836a5162425ab534fb4129e10bd0a05309a/chrome/android/javatests/src/org/chromium/chrome/browser/partnercustomizations/PartnerHomepageUnitTest.java
[modify] https://crrev.com/86c12836a5162425ab534fb4129e10bd0a05309a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTabTest.java
[modify] https://crrev.com/86c12836a5162425ab534fb4129e10bd0a05309a/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivityTest.java
[modify] https://crrev.com/86c12836a5162425ab534fb4129e10bd0a05309a/chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheControllerTest.java
[modify] https://crrev.com/86c12836a5162425ab534fb4129e10bd0a05309a/chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheLauncherTest.java
[modify] https://crrev.com/86c12836a5162425ab534fb4129e10bd0a05309a/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/PreferencesTest.java
[modify] https://crrev.com/86c12836a5162425ab534fb4129e10bd0a05309a/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassinTest.java
[modify] https://crrev.com/86c12836a5162425ab534fb4129e10bd0a05309a/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/UndoTabModelTest.java
[modify] https://crrev.com/86c12836a5162425ab534fb4129e10bd0a05309a/chrome/android/javatests/src/org/chromium/chrome/browser/widget/findinpage/FindTest.java
[modify] https://crrev.com/86c12836a5162425ab534fb4129e10bd0a05309a/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java
[modify] https://crrev.com/86c12836a5162425ab534fb4129e10bd0a05309a/content/public/android/javatests/src/org/chromium/content/browser/ContentViewScrollingTest.java
[modify] https://crrev.com/86c12836a5162425ab534fb4129e10bd0a05309a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

Project Member

Comment 26 by bugdroid1@chromium.org, Sep 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33f42fafa3457f241d333657353d72093bd26905

commit 33f42fafa3457f241d333657353d72093bd26905
Author: boliu <boliu@chromium.org>
Date: Wed Sep 21 17:05:01 2016

android: Mark flaky tests with @RetryOnFailure

These are flaky tests detected by chromium-try-flakes.appspot.com
in the last day.

Noticeably a smaller set than yesterday, so that's good.

BUG= 619055 ,  648952 
TBR=tedchoc@chromium.org

Review-Url: https://codereview.chromium.org/2355363002
Cr-Commit-Position: refs/heads/master@{#420085}

[modify] https://crrev.com/33f42fafa3457f241d333657353d72093bd26905/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java
[modify] https://crrev.com/33f42fafa3457f241d333657353d72093bd26905/android_webview/javatests/src/org/chromium/android_webview/test/AwZoomTest.java
[modify] https://crrev.com/33f42fafa3457f241d333657353d72093bd26905/android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java
[modify] https://crrev.com/33f42fafa3457f241d333657353d72093bd26905/chrome/android/javatests/src/org/chromium/chrome/browser/PrerenderTest.java
[modify] https://crrev.com/33f42fafa3457f241d333657353d72093bd26905/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
[modify] https://crrev.com/33f42fafa3457f241d333657353d72093bd26905/chrome/android/javatests/src/org/chromium/chrome/browser/hardware_acceleration/ChromeTabbedActivityHWATest.java
[modify] https://crrev.com/33f42fafa3457f241d333657353d72093bd26905/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/MediaPermissionsTest.java
[modify] https://crrev.com/33f42fafa3457f241d333657353d72093bd26905/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java
[modify] https://crrev.com/33f42fafa3457f241d333657353d72093bd26905/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java
[modify] https://crrev.com/33f42fafa3457f241d333657353d72093bd26905/chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheControllerTest.java
[modify] https://crrev.com/33f42fafa3457f241d333657353d72093bd26905/chrome/android/javatests/src/org/chromium/chrome/browser/signin/SigninHelperTest.java
[modify] https://crrev.com/33f42fafa3457f241d333657353d72093bd26905/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ActivityAssignerTest.java
[modify] https://crrev.com/33f42fafa3457f241d333657353d72093bd26905/content/public/android/javatests/src/org/chromium/content/browser/MediaSessionTest.java
[modify] https://crrev.com/33f42fafa3457f241d333657353d72093bd26905/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

Project Member

Comment 27 by bugdroid1@chromium.org, Sep 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48b0d3beb3670d7381b8b66aa7ac47433170ffb6

commit 48b0d3beb3670d7381b8b66aa7ac47433170ffb6
Author: jbudorick <jbudorick@chromium.org>
Date: Thu Sep 22 05:22:45 2016

[Android] More @RetryOnFailure in chrome_public_test_apk.

Specifically, for:
 - ChromeBackgroundServiceTest.*
 - all tests deriving from PaymentRequestTestBase

BUG= 619055 
TBR=tedchoc@chromium.org,boliu@chromium.org

Review-Url: https://codereview.chromium.org/2360183002
Cr-Commit-Position: refs/heads/master@{#420265}

[modify] https://crrev.com/48b0d3beb3670d7381b8b66aa7ac47433170ffb6/chrome/android/javatests/src/org/chromium/chrome/browser/ChromeBackgroundServiceTest.java
[modify] https://crrev.com/48b0d3beb3670d7381b8b66aa7ac47433170ffb6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestAbortTest.java
[modify] https://crrev.com/48b0d3beb3670d7381b8b66aa7ac47433170ffb6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsAndFreeShippingTest.java
[modify] https://crrev.com/48b0d3beb3670d7381b8b66aa7ac47433170ffb6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java
[modify] https://crrev.com/48b0d3beb3670d7381b8b66aa7ac47433170ffb6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDynamicShippingMultipleAddressesTest.java
[modify] https://crrev.com/48b0d3beb3670d7381b8b66aa7ac47433170ffb6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDynamicShippingSingleAddressTest.java
[modify] https://crrev.com/48b0d3beb3670d7381b8b66aa7ac47433170ffb6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmailAndFreeShippingTest.java
[modify] https://crrev.com/48b0d3beb3670d7381b8b66aa7ac47433170ffb6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmailTest.java
[modify] https://crrev.com/48b0d3beb3670d7381b8b66aa7ac47433170ffb6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFailCompleteTest.java
[modify] https://crrev.com/48b0d3beb3670d7381b8b66aa7ac47433170ffb6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java
[modify] https://crrev.com/48b0d3beb3670d7381b8b66aa7ac47433170ffb6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteContactDetailsTest.java
[modify] https://crrev.com/48b0d3beb3670d7381b8b66aa7ac47433170ffb6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteEmailTest.java
[modify] https://crrev.com/48b0d3beb3670d7381b8b66aa7ac47433170ffb6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompletePhoneTest.java
[modify] https://crrev.com/48b0d3beb3670d7381b8b66aa7ac47433170ffb6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteServerCardTest.java
[modify] https://crrev.com/48b0d3beb3670d7381b8b66aa7ac47433170ffb6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java
[modify] https://crrev.com/48b0d3beb3670d7381b8b66aa7ac47433170ffb6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMultipleContactDetailsTest.java
[modify] https://crrev.com/48b0d3beb3670d7381b8b66aa7ac47433170ffb6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java
[modify] https://crrev.com/48b0d3beb3670d7381b8b66aa7ac47433170ffb6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppAndCardsTest.java
[modify] https://crrev.com/48b0d3beb3670d7381b8b66aa7ac47433170ffb6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppTest.java
[modify] https://crrev.com/48b0d3beb3670d7381b8b66aa7ac47433170ffb6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPhoneAndFreeShippingTest.java
[modify] https://crrev.com/48b0d3beb3670d7381b8b66aa7ac47433170ffb6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPhoneTest.java
[modify] https://crrev.com/48b0d3beb3670d7381b8b66aa7ac47433170ffb6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestRemoveBillingAddressTest.java
[modify] https://crrev.com/48b0d3beb3670d7381b8b66aa7ac47433170ffb6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestServerCardTest.java
[modify] https://crrev.com/48b0d3beb3670d7381b8b66aa7ac47433170ffb6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShowTwiceTest.java
[modify] https://crrev.com/48b0d3beb3670d7381b8b66aa7ac47433170ffb6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTabTest.java
[modify] https://crrev.com/48b0d3beb3670d7381b8b66aa7ac47433170ffb6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
[modify] https://crrev.com/48b0d3beb3670d7381b8b66aa7ac47433170ffb6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestUseStatsTest.java

Project Member

Comment 28 by bugdroid1@chromium.org, Sep 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07f281f2b29da6d1de19f029cca62437cea4bd78

commit 07f281f2b29da6d1de19f029cca62437cea4bd78
Author: boliu <boliu@chromium.org>
Date: Thu Sep 22 17:50:17 2016

android: Mark flaky tests with @RetryOnFailure

These are flaky tests detected by chromium-try-flakes.appspot.com
in the last day.

Smaller set yet again from yesterday. Will converge eventually, hopefully.

BUG= 619055 
TBR=tedchoc@chromium.org

Review-Url: https://codereview.chromium.org/2362473003
Cr-Commit-Position: refs/heads/master@{#420388}

[modify] https://crrev.com/07f281f2b29da6d1de19f029cca62437cea4bd78/android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java
[modify] https://crrev.com/07f281f2b29da6d1de19f029cca62437cea4bd78/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java
[modify] https://crrev.com/07f281f2b29da6d1de19f029cca62437cea4bd78/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java
[modify] https://crrev.com/07f281f2b29da6d1de19f029cca62437cea4bd78/chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheControllerTest.java
[modify] https://crrev.com/07f281f2b29da6d1de19f029cca62437cea4bd78/chrome/android/javatests/src/org/chromium/chrome/browser/snackbar/SnackbarTest.java
[modify] https://crrev.com/07f281f2b29da6d1de19f029cca62437cea4bd78/chrome/android/javatests/src/org/chromium/chrome/browser/widget/findinpage/FindTest.java
[modify] https://crrev.com/07f281f2b29da6d1de19f029cca62437cea4bd78/content/public/android/javatests/src/org/chromium/content/browser/EmailAddressDetectionTest.java
[modify] https://crrev.com/07f281f2b29da6d1de19f029cca62437cea4bd78/content/public/android/javatests/src/org/chromium/content/browser/MediaSessionTest.java

Project Member

Comment 29 by bugdroid1@chromium.org, Sep 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8673d88defe3c98814ae443f7956196787aaaf2

commit a8673d88defe3c98814ae443f7956196787aaaf2
Author: boliu <boliu@chromium.org>
Date: Fri Sep 23 17:47:47 2016

android: Mark flaky tests with @RetryOnFailure

These are flaky tests detected by chromium-try-flakes.appspot.com
in the last day.

Roughly same number of tests as yesterday. So possibly reached a steady
state now.

BUG= 619055 
TBR=tedchoc@chromium.org

Review-Url: https://codereview.chromium.org/2365783003
Cr-Commit-Position: refs/heads/master@{#420650}

[modify] https://crrev.com/a8673d88defe3c98814ae443f7956196787aaaf2/android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java
[modify] https://crrev.com/a8673d88defe3c98814ae443f7956196787aaaf2/android_webview/javatests/src/org/chromium/android_webview/test/PolicyUrlFilteringTest.java
[modify] https://crrev.com/a8673d88defe3c98814ae443f7956196787aaaf2/chrome/android/javatests/src/org/chromium/chrome/browser/NavigateTest.java
[modify] https://crrev.com/a8673d88defe3c98814ae443f7956196787aaaf2/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
[modify] https://crrev.com/a8673d88defe3c98814ae443f7956196787aaaf2/chrome/android/javatests/src/org/chromium/chrome/browser/download/SystemDownloadNotifierTest.java
[modify] https://crrev.com/a8673d88defe3c98814ae443f7956196787aaaf2/chrome/android/javatests/src/org/chromium/chrome/browser/media/router/MediaRouterIntegrationTest.java
[modify] https://crrev.com/a8673d88defe3c98814ae443f7956196787aaaf2/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/UrlBarTest.java
[modify] https://crrev.com/a8673d88defe3c98814ae443f7956196787aaaf2/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java
[modify] https://crrev.com/a8673d88defe3c98814ae443f7956196787aaaf2/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

RetryOnFailure wasn't sufficient for PolicyUrlFilteringTest going to disable.
Actually, this just added it for BlacklistURL, adding it for whitelist now.

Comment 32 by hbos@chromium.org, Dec 6 2016

If a test is flaky, shouldn't it be made non-flaky rather than doing @RetryOnFailure?

A @RetryOnFailure test just failed:
https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20N5X%20Swarm%20Builder/builds/6967

https://cs.chromium.org/chromium/src/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeChildFrameTest.java?type=cs&q=testHolderFrame&sq=package:chromium&l=181

I'm guessing it's a flake since I've only seen it time out on one of the bots so far and it just disappeared from Sheriff-o-Matic.
In the long term, yes. @RetryOnFailure is a transitional tool from our previous state where everything was retried on failure.
Project Member

Comment 34 by sheriffbot@chromium.org, Dec 11 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Untriaged)
While we can debate whether this was wise to do, I think we can say that @RetryOnFailure is implemented.

Sign in to add a comment