New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 619050 link

Starred by 3 users
Status: Fixed
Owner:
█ spqc...@chromium.org
Last visit > 30 days ago
Closed: Jun 2016
Cc:
█ shrike@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Incognito mode window badge in upper-right is faded on tab drag

Project Member Reported by davidben@chromium.org, Jun 10 2016 
Version: 53.0.2762.0 (Official Build) canary (64-bit)
OS: OS X

What steps will reproduce the problem?
(1) cmd-shift-n to open an incognito window
(2) cmd-t to open a new tab
(3) drag that tab into its own window

What is the expected output?
The two windows look the same

What do you see instead?
The window created via tab drag has a faded out incognito badge. See screenshots.


Please use labels and text to provide additional information.
Screen Shot 2016-06-10 at 11.34.43 AM.png
60.1 KB View Download
Screen Shot 2016-06-10 at 11.34.53 AM.png
58.4 KB View Download

Comment 1 by meh...@chromium.org, Jun 10 2016

Cc: spqc...@chromium.org shrike@chromium.org
Labels: -Pri-3 Proj-MaterialDesign-NativeUI Pri-2
Confirmed.
Bildschirmfoto 2016-06-10 um 22.06.29.png
23.4 KB View Download

Comment 2 by shrike@chromium.org, Jun 10 2016

Cc: -spqc...@chromium.org
Labels: M-53
Owner: spqc...@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43089e93f5acad66a90edae0fc437ef2bddf03db

commit 43089e93f5acad66a90edae0fc437ef2bddf03db
Author: spqchan <spqchan@chromium.org>
Date: Tue Jun 14 18:59:07 2016

[Material][Mac] Fixed tabstrip overlap issue

BUG= 619050 

Review-Url: https://codereview.chromium.org/2063823007
Cr-Commit-Position: refs/heads/master@{#399762}

[modify] https://crrev.com/43089e93f5acad66a90edae0fc437ef2bddf03db/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm

Comment 4 by spqc...@chromium.org, Jun 14 2016

Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43089e93f5acad66a90edae0fc437ef2bddf03db

commit 43089e93f5acad66a90edae0fc437ef2bddf03db
Author: spqchan <spqchan@chromium.org>
Date: Tue Jun 14 18:59:07 2016

[Material][Mac] Fixed tabstrip overlap issue

BUG= 619050 

Review-Url: https://codereview.chromium.org/2063823007
Cr-Commit-Position: refs/heads/master@{#399762}

[modify] https://crrev.com/43089e93f5acad66a90edae0fc437ef2bddf03db/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm

Comment 6 by davidben@chromium.org, Jun 17 2016 

This seems to happen with the volume badge on tabs playing sound too, by the way. (Should I file a separate bug for this?)

Comment 7 by shrike@chromium.org, Jun 18 2016 

Yes, please file a separate bug. Please include exact instructions to reproduce, and screenshots/movies are always helpful. Thank you.

Comment 8 by meh...@chromium.org, Jun 19 2016 

FYI: Filed  issue 621348  regarding comment 6 & 7.
►

Sign in to add a comment