Windows Condition Variable Checks for WAIT_TIMEOUT instead of ERROR_TIMEOUT |
|||
Issue descriptionA code review revealed that the Windows condition variable was checking for WAIT_TIMEOUT when this should have been ERROR_TIMEOUT. This bug has been there since the SleepConditionVariableCS days. This should have been ERROR_TIMEOUT as WAIT_TIMEOUT only applies to WaitFor[Single|Multiple]Object[s][Ex]
,
Jun 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6162e2705ec3496cddb769e08c4c7fb24f7a85b3 commit 6162e2705ec3496cddb769e08c4c7fb24f7a85b3 Author: robliao <robliao@chromium.org> Date: Fri Jun 10 21:46:18 2016 Fix Windows Condition Variable GetLastError Check During the SleepConditionVariableCS days, the GetLastError was checked against WAIT_TIMEOUT. This should have been ERROR_TIMEOUT per the docs. WAIT_TIMEOUT applies to functions like WaitForSingleObject (and more). BUG= 619037 Review-Url: https://codereview.chromium.org/2053403002 Cr-Commit-Position: refs/heads/master@{#399279} [modify] https://crrev.com/6162e2705ec3496cddb769e08c4c7fb24f7a85b3/base/synchronization/condition_variable_win.cc
,
Jun 10 2016
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6162e2705ec3496cddb769e08c4c7fb24f7a85b3 commit 6162e2705ec3496cddb769e08c4c7fb24f7a85b3 Author: robliao <robliao@chromium.org> Date: Fri Jun 10 21:46:18 2016 Fix Windows Condition Variable GetLastError Check During the SleepConditionVariableCS days, the GetLastError was checked against WAIT_TIMEOUT. This should have been ERROR_TIMEOUT per the docs. WAIT_TIMEOUT applies to functions like WaitForSingleObject (and more). BUG= 619037 Review-Url: https://codereview.chromium.org/2053403002 Cr-Commit-Position: refs/heads/master@{#399279} [modify] https://crrev.com/6162e2705ec3496cddb769e08c4c7fb24f7a85b3/base/synchronization/condition_variable_win.cc
,
Jun 17 2016
,
Sep 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4197b46757b395687234c3a49e6775143b4f5b42 commit 4197b46757b395687234c3a49e6775143b4f5b42 Author: robliao <robliao@chromium.org> Date: Wed Sep 14 20:21:45 2016 Add Some Comments to the Timeout Checks on Condition Variables BUG= 619037 Review-Url: https://codereview.chromium.org/2341773003 Cr-Commit-Position: refs/heads/master@{#418655} [modify] https://crrev.com/4197b46757b395687234c3a49e6775143b4f5b42/base/synchronization/condition_variable_posix.cc [modify] https://crrev.com/4197b46757b395687234c3a49e6775143b4f5b42/base/synchronization/condition_variable_win.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by robliao@chromium.org
, Jun 10 2016