New issue
Advanced search Search tips

Issue 619014 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

6.7% regression in dromaeo.domcoretraverse at 398813:398828

Project Member Reported by pmeenan@chromium.org, Jun 10 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=619014

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgvO20pAoM


Bot(s) for this bug's original alert(s):

linux-release
Re-kicked bisect with wider range
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jun 13 2016

Cc: jarin@chromium.org
Owner: jarin@chromium.org

=== Auto-CCing suspected CL author jarin@chromium.org ===

Hi jarin@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : [stubs] StringToNumberStub --> StringToNumber builtin.
Author  : jarin
Commit description:
  
Since some builtins use StringToNumberStub (so the code is always there),
it makes more sense to have StringToNumber builtin.

Review-Url: https://codereview.chromium.org/2050853003
Cr-Commit-Position: refs/heads/master@{#36843}
Commit  : 546dd77ffcccce42a5751b24bddaa8295efefb4b
Date    : Thu Jun 09 07:58:27 2016


===== TESTED REVISIONS =====
Revision                       Mean     Std Dev  N  Good?
chromium@398812                694.827  9.35281  5  good
chromium@398837                695.574  9.6298   5  good
chromium@398840                690.228  7.03535  5  good
chromium@398841                685.955  8.68611  5  good
chromium@398841,v8@fe561a7a18  684.407  10.9396  5  good
chromium@398841,v8@40b5c1d41f  689.02   8.14046  5  good
chromium@398841,v8@546dd77ffc  651.188  5.80675  5  bad    <--
chromium@398842                650.013  10.3145  5  bad
chromium@398843                650.708  6.04075  5  bad
chromium@398849                651.376  5.60735  5  bad
chromium@398861                649.145  10.763   5  bad

Bisect job ran on: linux_perf_bisect
Bug ID: 619014

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests dromaeo.domcoretraverse
Test Metric: dom/dom
Relative Change: 6.57%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6537
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9009962699124567824


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5782258896601088

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Comment 4 by jarin@chromium.org, Jun 22 2016

Status: Fixed (was: Assigned)
This has recovered once we moved the other ToNumber stubs to builtins.

Sign in to add a comment