Regression : Weird extension bubble is seen after installing 'F.B. Purity For Facebook' extension.
Reported by
yfulgaon...@etouch.net,
Jun 10 2016
|
|||||||
Issue descriptionChrome version : 53.0.2764.0 (Official Build) bd10cc1ecbbcc95f143d19911a6d3b81b8043d65-refs/heads/master@{#399036} 32/64 bit OS : Windows (7,8,8.1,10), Linux (14.04 LTS) URL : https://chrome.google.com/webstore/detail/fb-purity-for-facebook/ncdlagniojmheiklojdcpdaeepochckl?utm_source=chrome-ntp-icon What steps will reproduce the problem? 1) Launch chrome, go to above URL and install an extension. 2) Observe the extension bubble at top RHS. Actual : Weird extension bubble is seen after installing 'F.B. Purity For Facebook' extension. Expected : Extension bubble should appear properly. This is a regression issue, broken in 'M-52', below is the Manual Bisect and Narrow Bisect info. Good Build : 52.0.2719.0 Bad Build : 52.0.2720.0 Narrow Bisect info: https://chromium.googlesource.com/chromium/src/+log/84ba684c21b7005f116f2264c71f13c116f3f7cf..e49d943e9f5f90411313e64d0ae6b646edc85043?pretty=fuller&n=10000 Suspecting : r390262 from Narrow Bisect Note : Above issue is not seen on Mac(10.10.5, 10.11.4) OS.
,
Jun 10 2016
yup, it's me. I can't work on a fix till Monday unfortunately.
,
Jun 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb814f63fb1f396192cee63a86feb2582716bdcc commit eb814f63fb1f396192cee63a86feb2582716bdcc Author: estade <estade@chromium.org> Date: Thu Jun 16 18:10:40 2016 Fix extension installed bubble sizing for cases where there's no body text. BUG= 618983 Review-Url: https://codereview.chromium.org/2070883002 Cr-Commit-Position: refs/heads/master@{#400204} [modify] https://crrev.com/eb814f63fb1f396192cee63a86feb2582716bdcc/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
,
Jun 16 2016
A friendly reminder that M52 Stable is launching soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch by July 12. All changes MUST be merged into the release branch by 5pm on July 15 to make into the desktop Stable final build cut. Thank you!
,
Jun 21 2016
estade@: if this has been verified, please request merge into M52 branch
,
Jun 21 2016
,
Jun 21 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e18e8329bca1291e27715b13a4dbfb1623471dd commit 4e18e8329bca1291e27715b13a4dbfb1623471dd Author: Evan Stade <estade@chromium.org> Date: Tue Jun 21 23:37:52 2016 Fix extension installed bubble sizing for cases where there's no body text. BUG= 618983 Review-Url: https://codereview.chromium.org/2070883002 Cr-Commit-Position: refs/heads/master@{#400204} (cherry picked from commit eb814f63fb1f396192cee63a86feb2582716bdcc) Review URL: https://codereview.chromium.org/2089853003 . Cr-Commit-Position: refs/branch-heads/2743@{#440} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/4e18e8329bca1291e27715b13a4dbfb1623471dd/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
,
Jun 21 2016
,
Jul 25 2016
I tried to download this extension (URL : https://chrome.google.com/webstore/detail/fb-purity-for-facebook/ncdlagniojmheiklojdcpdaeepochckl?utm_source=chrome-ntp-icon) on chrome but getting error stating "Item not found". Also couldn't see it in "chrome web store". Let me know if there is another Link or chrome extension which is showing same behavior. Build : M-52 - 8350.60.0
,
Aug 2 2016
Please share another Link or chrome extension which is showing same behavior. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by tkonch...@chromium.org
, Jun 10 2016