Issue metadata
Sign in to add a comment
|
Regression: Grey highlight stays on 'New folder' at bookmark bar even after clicking anywhere on page or reloading
Reported by
jshan...@etouch.net,
Jun 10 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version: 53.0.2764.0 (Official Build)bd10cc1ecbbcc95f143d19911a6d3b81b8043d65-refs/heads/master@{#399036} 64 bit OS: Mac Pro (10.10.5, 11.11.4) Steps: !. Launch Chrome, go to NTP and bookmark it by editing and adding 2-3 'New Folder' 2. Navigate to Webstore and bookmark it with Folder location Bookmark bar. 3. Go to NTP, click on 'New folder' at bookmark bar, then click on 'Star icon' and click on 'Remove'. 4. Observe. Actual: Grey highlight stays on 'New folder' at bookmark bar even after clicking anywhere on page or reloading. Expected: Grey highlight should not stay after clicking anywhere on page or reloading. This is regression issue,broken in ‘M 52’ and below is narrow bisect: https://chromium.googlesource.com/chromium/src/+log/d195033a24b74413492685d93766932b64ad571e..27ceeaa6e172119ef8c1c7e21f0c61ea824d5e83?pretty=fuller&n=100 Suspecting: r394165 ? Good build:52.0.2739.0 Bad build:52.0.2740.0 Note:1. Above issue is not reproducible on Windows and Linux OS.
,
Jun 10 2016
Adding RB label as this is a recent regression
,
Jun 14 2016
Issue is still seen on mac 10.11 chrome canary 53.0.2767.0
,
Jun 14 2016
shrike@, Can you please look into this
,
Jun 14 2016
Simpler steps to reproduce: 1. Click a folder in the Bookmarks Bar 2. Move the mouse down over the folder menu and then to the right so that it's no longer over the folder menu. 3. Move the mouse back up into the Bookmarks Bar Moving the mouse back over the Bookmarks Bar causes the Bookmark folder menu to order out but leaves the folder menu item highlighted in the bar. spqchan@ - would you please take a look at this? Thank you.
,
Jun 14 2016
,
Jun 16 2016
A friendly reminder that M52 Stable is launching soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch by July 12. All changes MUST be merged into the release branch by 5pm on July 15 to make into the desktop Stable final build cut. Thank you!
,
Jun 20 2016
Just to update: Issue is still seen on mac 10.11 chrome canary 53.0.2773.0
,
Jun 22 2016
,
Jun 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/054f2cbda89f48d6c2022c39bc70df417f8012ab commit 054f2cbda89f48d6c2022c39bc70df417f8012ab Author: spqchan <spqchan@chromium.org> Date: Wed Jun 22 02:18:25 2016 [Material][Mac] Fix for Bookmark Button's highlight issues BUG= 618979 Review-Url: https://codereview.chromium.org/2089743002 Cr-Commit-Position: refs/heads/master@{#401167} [modify] https://crrev.com/054f2cbda89f48d6c2022c39bc70df417f8012ab/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm [modify] https://crrev.com/054f2cbda89f48d6c2022c39bc70df417f8012ab/chrome/browser/ui/cocoa/gradient_button_cell.mm
,
Jun 23 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d64a97f997dd89bbc9423a2601ecc4528da6567 commit 5d64a97f997dd89bbc9423a2601ecc4528da6567 Author: spqchan <spqchan@chromium.org> Date: Thu Jun 23 01:59:51 2016 [Material][Mac] Fix for Bookmark Button's highlight issues BUG= 618979 Review-Url: https://codereview.chromium.org/2089743002 Cr-Commit-Position: refs/heads/master@{#401167} (cherry picked from commit 054f2cbda89f48d6c2022c39bc70df417f8012ab) Review URL: https://codereview.chromium.org/2082383004 . Cr-Commit-Position: refs/branch-heads/2743@{#453} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/5d64a97f997dd89bbc9423a2601ecc4528da6567/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm [modify] https://crrev.com/5d64a97f997dd89bbc9423a2601ecc4528da6567/chrome/browser/ui/cocoa/gradient_button_cell.mm
,
Jun 23 2016
,
Jun 30 2016
Tested the same on MacBook Pro Retina 10.11.5 chrome version 52.0.2743.60 - Grey highlight doesn't stay on folder after leaving the folder menu and focussing on other bookmark on bookmark bar. Please find the screencast Fix works as expected. Adding TE verified labels
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by jshan...@etouch.net
, Jun 10 2016