Regression: Focus ring is not seen properly for 'Chrome में प्रवेश कऱे' option on bookmark bubble.
Reported by
dchau...@etouch.net,
Jun 10 2016
|
||||||
Issue descriptionChrome Version: 53.0.2764.0 (Official Build)bd10cc1ecbbcc95f143d19911a6d3b81b8043d65-refs/heads/master@{#399036} 32/64-bit. OS: Windows(7,8,10). What steps will reproduce the problem? 1. Launch chrome, change browser language to 'Hindi' from chrome://settings/addLanguage and restart the chrome. 2. Now, go to NTP or any webpage and click on star icon in omnibox to open 'Bookmark' bubble. 3. Press 'Tab' key from keyboard till focus reaches to 'Chrome में प्रवेश कऱे' option and observe. Bottom line of focus ring is seems to be chopped for 'Chrome में प्रवेश कऱे' option. Focus ring should seen properly for 'Chrome में प्रवेश कऱे' option. This is a regression issue, broken in M-49 series, below is bisect info. Good build: 49.0.2577.0 Bad build: 49.0.2578.0 Narrow bisect: https://chromium.googlesource.com/chromium/src/+log/9073135c8d9ede9b1b0ba230fcfaddad3ee736b0..f3c6a7898179b250386d04d621a30bc239ae9af8?pretty=fuller&n=100 Suspecting: r362231 ? @govind: Kindly help to reassign, if your changes are not related to this issue. Note: This issue is not seen on Mac and Linux OS. Kindly review the attached screen-cast for reference.
,
Jun 10 2016
hmm, this is a functional issue not translation, so the Dev for the related area (Bookmarks or Omnibox?) is the best to take a look and fix.
,
Jun 15 2016
shrike@, could you please help us to find a right owner? Thank you!
,
Jun 15 2016
I'm not sure who the right person is on the Windows size - releasing to be triaged by the Windows team.
,
Jun 15 2016
I dunno who's done the most work on this kind of stuff recently, maybe Evan. I'm removing the regression tag, because the change here is really just a translation change that resulted in a different line wrapping. It's not clear to me we wouldn't have had this issue before if the string had been different.
,
Jun 15 2016
,
Jun 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/85882eb4e66d924e623be4246894d96d7344fce8 commit 85882eb4e66d924e623be4246894d96d7344fce8 Author: estade <estade@chromium.org> Date: Mon Jun 20 23:38:33 2016 Fix StyledLabel so it doesn't clip the bottom of Hindi text. A label can be taller than the calculated line height, so set the height according to the bottom of the lowest label (link) as we iterate through StyledLabel sub-views. Also, somewhat tangentially, reduce the amount of nesting in BubbleSyncPromoView by making it a StyledLabel rather than a view containing a single StyledLabel. BUG= 618978 Review-Url: https://codereview.chromium.org/2072513003 Cr-Commit-Position: refs/heads/master@{#400833} [modify] https://crrev.com/85882eb4e66d924e623be4246894d96d7344fce8/chrome/browser/ui/views/sync/bubble_sync_promo_view.cc [modify] https://crrev.com/85882eb4e66d924e623be4246894d96d7344fce8/chrome/browser/ui/views/sync/bubble_sync_promo_view.h [modify] https://crrev.com/85882eb4e66d924e623be4246894d96d7344fce8/ui/views/controls/styled_label.cc
,
Jun 21 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by gov...@chromium.org
, Jun 10 2016Owner: mummare...@chromium.org