Enterprise.Policies histogram: Replace textual bucket descriptions by actual policy names. |
|||||
Issue descriptionhttps://uma.googleplex.com/p/chrome/histograms/?endDate=06-06-2016&dayCount=1&histograms=Enterprise.Policies&fixupData=true&showMax=true&filters=channel%2Ceq%2C4%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial Bonus points for automating histogram generation in some way / adding a presubmit script to ensure there are no regressions. (bartfab@ says a script already exists.)
,
Jan 24 2017
The mentioned script is tools/metrics/histograms/update_policies.py see https://cs.chromium.org/chromium/src/tools/metrics/histograms/update_policies.py?q=update_policies&sq=package:chromium&dr .
,
Jan 31 2017
,
Jan 31 2017
When we do this, we should also mention the existence of the script in policy_templates.json around the comments # And don't forget to also update the EnterprisePolicies enum of # histograms.xml.
,
Feb 2 2017
,
Feb 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/afdfa8058e3d9e8fcfab6fd09ebf68d9ec31d3c7 commit afdfa8058e3d9e8fcfab6fd09ebf68d9ec31d3c7 Author: pmarko <pmarko@chromium.org> Date: Tue Feb 14 10:34:54 2017 Change Enterprise.Policies histogram bucket descriptions to policy names Adapt the python script generating Enterprise.Policies in histograms.xml to use policy names instead of captions for bucket descriptions. Also, mention the script in policy_templates.json and the PRESUBMIT script for cross-checking if every policy has a bucket in histograms.xml. BUG= 618964 Review-Url: https://codereview.chromium.org/2667373003 Cr-Commit-Position: refs/heads/master@{#450316} [modify] https://crrev.com/afdfa8058e3d9e8fcfab6fd09ebf68d9ec31d3c7/components/policy/resources/PRESUBMIT.py [modify] https://crrev.com/afdfa8058e3d9e8fcfab6fd09ebf68d9ec31d3c7/components/policy/resources/policy_templates.json [modify] https://crrev.com/afdfa8058e3d9e8fcfab6fd09ebf68d9ec31d3c7/tools/metrics/histograms/histograms.xml [modify] https://crrev.com/afdfa8058e3d9e8fcfab6fd09ebf68d9ec31d3c7/tools/metrics/histograms/update_policies.py
,
Feb 14 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by pbond@chromium.org
, Jun 22 2016Status: Available (was: Untriaged)