Use counter filter functions with no arguments |
|||
Issue descriptionThe Filter Effects spec [1] currently allow some filter functions to have no arguments (i.e essentially default argument values). This is currently supported by Blink, but not Gecko or Edge. There's also some controversy as to what the default argument values should be [2], and what Blink implements currently differ from the spec in some cases. Aligning with Gecko and Edge would mean a valid -> invalid transition, so content would be (visually) broken. We should add a use counter to gauge the impact before moving in either direction. [1] https://drafts.fxtf.org/filters/#FilterProperty [2] https://github.com/w3c/fxtf-drafts/issues/1
,
Jun 10 2016
Hmm, actually re-reading the syntax definitions it doesn't look like the spec allows "no arguments" (the grouping used in some places is a bit confusing though.)
,
Jun 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/69dc0dd043ecad3018541eaae6239022a808aa99 commit 69dc0dd043ecad3018541eaae6239022a808aa99 Author: fs <fs@opera.com> Date: Sat Jun 11 20:33:29 2016 Add use counter for parsing of filter functions with no arguments Count before deciding the future for this, and related, "features". BUG= 618960 Review-Url: https://codereview.chromium.org/2051233003 Cr-Commit-Position: refs/heads/master@{#399378} [add] https://crrev.com/69dc0dd043ecad3018541eaae6239022a808aa99/third_party/WebKit/LayoutTests/css3/filters/usecounter-filter-function-no-arguments.html [modify] https://crrev.com/69dc0dd043ecad3018541eaae6239022a808aa99/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp [modify] https://crrev.com/69dc0dd043ecad3018541eaae6239022a808aa99/third_party/WebKit/Source/core/frame/UseCounter.h [modify] https://crrev.com/69dc0dd043ecad3018541eaae6239022a808aa99/tools/metrics/histograms/histograms.xml
,
Jun 11 2016
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/69dc0dd043ecad3018541eaae6239022a808aa99 commit 69dc0dd043ecad3018541eaae6239022a808aa99 Author: fs <fs@opera.com> Date: Sat Jun 11 20:33:29 2016 Add use counter for parsing of filter functions with no arguments Count before deciding the future for this, and related, "features". BUG= 618960 Review-Url: https://codereview.chromium.org/2051233003 Cr-Commit-Position: refs/heads/master@{#399378} [add] https://crrev.com/69dc0dd043ecad3018541eaae6239022a808aa99/third_party/WebKit/LayoutTests/css3/filters/usecounter-filter-function-no-arguments.html [modify] https://crrev.com/69dc0dd043ecad3018541eaae6239022a808aa99/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp [modify] https://crrev.com/69dc0dd043ecad3018541eaae6239022a808aa99/third_party/WebKit/Source/core/frame/UseCounter.h [modify] https://crrev.com/69dc0dd043ecad3018541eaae6239022a808aa99/tools/metrics/histograms/histograms.xml
,
Apr 5 2017
,
Oct 19 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by f...@opera.com
, Jun 10 2016