New issue
Advanced search Search tips

Issue 618926 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

zone allocator should report peak memory usage.

Project Member Reported by tasak@google.com, Jun 10 2016

Issue description

Because of sampling intervals, it is not possible to report zone allocator's peak memory usage correctly.
So zone allocator (or accounting allocator?) should record its peak memory usage, and report the usage when memory-infra requests.

 
Owner: vogelheim@chromium.org
I have a half-done CL for this, based on earlier discussion w/ Toon & Jochen. (crrev.com/2058703002) I guess I'll just grab this issue....

@tasak: Could you explain what interface you need for "report the usage when memory-infra requests"?
Does a histogram that tracks the maximum suffice? Or would you rather want a counter of the current-maximum? Or something else entirely?

Comment 2 by tasak@google.com, Jun 10 2016

I'm thinking of something like the following changes:

https://codereview.chromium.org/2051773002/diff/1/gin/v8_isolate_memory_dump_provider.cc
https://codereview.chromium.org/2050173002/diff/1/include/v8.h
https://codereview.chromium.org/2050173002/diff/1/src/api.cc

The changes add "peak_size" to "v8/isolate_0x[0-9a-f]/malloc". So memory-infra can know the peak size correctly.

However, I'm not sure how to add peak memory usage interface to accounting-allocator:

https://codereview.chromium.org/2050173002/diff/1/src/base/accounting-allocator.cc

I think, the above change is bad because it requires Mutex when invoking malloc or free. It causes performance regression.

Project Member

Comment 3 by sheriffbot@chromium.org, Jun 10 2016

Labels: Hotlist-Google
Status: Fixed (was: Assigned)
Handled by https://codereview.chromium.org/2153423002/

Sign in to add a comment