zone allocator should report peak memory usage. |
||
Issue descriptionBecause of sampling intervals, it is not possible to report zone allocator's peak memory usage correctly. So zone allocator (or accounting allocator?) should record its peak memory usage, and report the usage when memory-infra requests.
,
Jun 10 2016
I'm thinking of something like the following changes: https://codereview.chromium.org/2051773002/diff/1/gin/v8_isolate_memory_dump_provider.cc https://codereview.chromium.org/2050173002/diff/1/include/v8.h https://codereview.chromium.org/2050173002/diff/1/src/api.cc The changes add "peak_size" to "v8/isolate_0x[0-9a-f]/malloc". So memory-infra can know the peak size correctly. However, I'm not sure how to add peak memory usage interface to accounting-allocator: https://codereview.chromium.org/2050173002/diff/1/src/base/accounting-allocator.cc I think, the above change is bad because it requires Mutex when invoking malloc or free. It causes performance regression.
,
Jun 10 2016
,
Jul 18 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by vogelheim@chromium.org
, Jun 10 2016