Regression : Unable to write notes as text caret is seen missing in notepad app.
Reported by
mni...@etouch.net,
Jun 10 2016
|
||||||||||||||
Issue descriptionVersion: 53.0.2763.0 dd933bda0baa6a13ab0120f0056a2b783e459efb-refs/heads/master@{#398752} (32/64-bit) OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.10.5, 10.11.4) URL : https://chrome.google.com/webstore/detail/notepad/ddiajdhnmhmpedmnedjhldgackpocefd/related?utm_source=chrome-ntp-icon What steps will reproduce the problem? 1) Launch chrome and navigate to above url and add app 2) Now launch app and Notepad overlay gets open. 3) Now click on white background to add notes and observe Actual : Unable to write notes as text caret is seen missing Expected : Text caret should be seen and should be able to add notes This is a regression issue broken in 'M-53' and below is the manual regression and Narrow bisect info: Good build : 53.0.2748.0 Bad build : 53.0.2749.0 Narrow bisect info: https://chromium.googlesource.com/chromium/src/+log/a2e6a0c352d0f2bd62a245d26abbad617e06cad3..40752baf2de533a12d1d42dd41a08ecacb652129?pretty=fuller&n=50 Suspecting : r395828 from Narrow bisect @yoichio : Could you please help to reassign if your change is not the cause for this change.
,
Jun 15 2016
This issue is reproducible on windows using chrome version 53.0.2768.0. yoichio @ Could you please look into this issue if it is related to your change,else please route this to an appropriate owner. Thanks,
,
Jun 20 2016
Issue still persists on Canary 53.0.2773.0.
,
Jun 22 2016
Reproduced.
,
Jun 27 2016
Just to update: Still able to see the issue on Windows 7, Mac 10.11.5, Ubuntu 14.04 using latest M-53(53.0.2780.0).
,
Jul 1 2016
yoichio@: Any update on the fix for this blocker issue.
,
Jul 4 2016
Working on.
,
Jul 6 2016
,
Jul 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d607a605c05ae726b55aa3a28b32c94a2ab597ff commit d607a605c05ae726b55aa3a28b32c94a2ab597ff Author: yoichio <yoichio@chromium.org> Date: Thu Jul 14 06:28:09 2016 Contenteditable w/ "-webkit-user-select:all" should be editable. <div id ="div" style="-webkit-user-select:all" contenteditable="true"></div> should be editable. In this CL, we ignore "-webkit-user-select:all" if element has |contenteditable="true| in Node::hasEditableStyle and expandSelection by user click. BUG= 618920 TEST=editing/selection/user-select/user-select-all-contenteditable.html, mouse/click- user-select-all-textarea.html, user-select/user-select-all-contenteditable.html Review-Url: https://codereview.chromium.org/2120913002 Cr-Commit-Position: refs/heads/master@{#405440} [add] https://crrev.com/d607a605c05ae726b55aa3a28b32c94a2ab597ff/third_party/WebKit/LayoutTests/editing/selection/mouse/click-user-select-all-contenteditable.html [add] https://crrev.com/d607a605c05ae726b55aa3a28b32c94a2ab597ff/third_party/WebKit/LayoutTests/editing/selection/mouse/click-user-select-all-textarea.html [add] https://crrev.com/d607a605c05ae726b55aa3a28b32c94a2ab597ff/third_party/WebKit/LayoutTests/editing/selection/user-select/user-select-all-contenteditable.html [modify] https://crrev.com/d607a605c05ae726b55aa3a28b32c94a2ab597ff/third_party/WebKit/Source/core/dom/Node.cpp [modify] https://crrev.com/d607a605c05ae726b55aa3a28b32c94a2ab597ff/third_party/WebKit/Source/core/editing/SelectionController.cpp
,
Jul 19 2016
Verified on Version 54.0.2800.0 canary.
,
Jul 19 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Jul 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/504692a84da84f81aa9ad585d23f41c73990d8de commit 504692a84da84f81aa9ad585d23f41c73990d8de Author: Yoichi Osato <yoichio@chromium.org> Date: Tue Jul 19 06:13:13 2016 Contenteditable w/ "-webkit-user-select:all" should be editable. <div id ="div" style="-webkit-user-select:all" contenteditable="true"></div> should be editable. In this CL, we ignore "-webkit-user-select:all" if element has |contenteditable="true| in Node::hasEditableStyle and expandSelection by user click. BUG= 618920 TEST=editing/selection/user-select/user-select-all-contenteditable.html, mouse/click- user-select-all-textarea.html, user-select/user-select-all-contenteditable.html Review-Url: https://codereview.chromium.org/2120913002 Cr-Commit-Position: refs/heads/master@{#405440} (cherry picked from commit d607a605c05ae726b55aa3a28b32c94a2ab597ff) Review URL: https://codereview.chromium.org/2162483003 . Cr-Commit-Position: refs/branch-heads/2785@{#213} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [add] https://crrev.com/504692a84da84f81aa9ad585d23f41c73990d8de/third_party/WebKit/LayoutTests/editing/selection/mouse/click-user-select-all-contenteditable.html [add] https://crrev.com/504692a84da84f81aa9ad585d23f41c73990d8de/third_party/WebKit/LayoutTests/editing/selection/mouse/click-user-select-all-textarea.html [add] https://crrev.com/504692a84da84f81aa9ad585d23f41c73990d8de/third_party/WebKit/LayoutTests/editing/selection/user-select/user-select-all-contenteditable.html [modify] https://crrev.com/504692a84da84f81aa9ad585d23f41c73990d8de/third_party/WebKit/Source/core/dom/Node.cpp [modify] https://crrev.com/504692a84da84f81aa9ad585d23f41c73990d8de/third_party/WebKit/Source/core/editing/SelectionController.cpp
,
Jul 26 2016
Rechecked this on Windows 7, Mac 10.11.5, Ubuntu 14.04 and merge is working as intended on chrome build 53.0.2785.30. Adding TE-Verified labels. Thanks.! |
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by tkonch...@chromium.org
, Jun 10 2016