[serial] FIrst read will never complete on some posix platforms |
||||
Issue descriptionOS: OSX (1) Open a serial connection to a device that already has data ready to read. (2) Read. (3) Wait forever and the read will never notify that it has completed.
,
Jun 28 2016
This was fixed with https://codereview.chromium.org/2057973002/, right? (If not, please reopen the bug.)
,
Jun 28 2016
That patch was never submitted because it has an outstanding comment.
,
Jun 28 2016
Yep, got sidetracked with other pressing issues. Will come back to this one soon.
,
Jul 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b09276a67a58e6aa0c23d8a052f0b7bd4c9ca668 commit b09276a67a58e6aa0c23d8a052f0b7bd4c9ca668 Author: aschulman <aschulman@chromium.org> Date: Thu Jul 28 20:38:29 2016 [serial] When a read is requested on posix platforms, try the read immediately. On some posix platforms (e.g., OSX) the first read after a serial device is opened may never complete. The problem is on these platforms the message loop will not notify that a file descriptor is ready to read if it was in that state when it was opened. This fixed this problem by trying to perform a read immediately after it is requested. BUG= 618911 Review-Url: https://codereview.chromium.org/2057973002 Cr-Commit-Position: refs/heads/master@{#408467} [modify] https://crrev.com/b09276a67a58e6aa0c23d8a052f0b7bd4c9ca668/device/serial/serial_io_handler_posix.cc [modify] https://crrev.com/b09276a67a58e6aa0c23d8a052f0b7bd4c9ca668/device/serial/serial_io_handler_posix.h
,
Jul 29 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by karandeepb@chromium.org
, Jun 10 2016