libFuzzer builds broken |
||
Issue descriptionkatrielc, would you mind taking a look at this failure? Thanks. See: https://build.chromium.org/p/chromium.fyi/builders/Libfuzzer%20Upload%20Linux%20ASan/builds/1484/steps/generate_build_files/logs/stdio Writing """\ enable_nacl = false is_asan = true is_debug = false pdf_enable_xfa = true proprietary_codecs = true use_libfuzzer = true """ to /b/build/slave/Libfuzzer_Upload_Linux_ASan/build/src/out/Release/args.gn. /b/build/slave/Libfuzzer_Upload_Linux_ASan/build/src/buildtools/linux64/gn gen //out/Release --check -> returned 1 ERROR at //third_party/webrtc/test/fuzzers/BUILD.gn:92:5: Can't load input file. "//webrtc/api:libjingle_peerconnection", ^-------------------------------------- Unable to load: /b/build/slave/Libfuzzer_Upload_Linux_ASan/build/src/webrtc/api/BUILD.gn I also checked in the secondary tree for: /b/build/slave/Libfuzzer_Upload_Linux_ASan/build/src/build/secondary/webrtc/api/BUILD.gn GN gen failed: 1 step returned non-zero exit code: 1 @@@STEP_FAILURE@@@
,
Jun 10 2016
Ah, pbos@ already fixed it (https://chromium.googlesource.com/external/webrtc/+/555cfe9e6e093b01142512de09c8f656308cd043). Filed https://bugs.chromium.org/p/webrtc/issues/detail?id=5992 to add a check in webrtc-land so this doesn't happen again.
,
Jun 10 2016
So pbos@ fixed problem 1 (dependencies were wrong), but problem 2 is that the gn targets that we're using are quite new and don't work with --check. I'll take a look now to see if it's easy to fix, and if not then I'll just remove the new libfuzzers until they don't break chromium.
,
Jun 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/external/webrtc.git/+/81ca73586ef1a0f7b9f904f965b42ce053056abb commit 81ca73586ef1a0f7b9f904f965b42ce053056abb Author: katrielc <katrielc@webrtc.org> Date: Fri Jun 10 09:59:41 2016 Remove new fuzzers until their GN targets work properly in Chromium. Chromium uses gn gen --check, which doesn't like some of the includes used in the new gn targets the fuzzers use. This breaks Chromium libfuzzer compiles, for which there isn't yet a webrtc FYI bot. I'm working on fixing the includes, at which point these can come back. BUG= chromium:618901 NOTRY=true Review-Url: https://codereview.webrtc.org/2053293002 Cr-Commit-Position: refs/heads/master@{#13098} [modify] https://crrev.com/81ca73586ef1a0f7b9f904f965b42ce053056abb/webrtc/test/fuzzers/BUILD.gn [delete] https://crrev.com/94cee3111c19040e16502037b42d2e8a4cae9429/webrtc/test/fuzzers/sdp_parser_fuzzer.cc [delete] https://crrev.com/94cee3111c19040e16502037b42d2e8a4cae9429/webrtc/test/fuzzers/stun_parser_fuzzer.cc [delete] https://crrev.com/94cee3111c19040e16502037b42d2e8a4cae9429/webrtc/test/fuzzers/stun_validator_fuzzer.cc
,
Jun 10 2016
Thanks! I'll mark this as fixed as it looks like they're cycling green now. |
||
►
Sign in to add a comment |
||
Comment 1 by katrielc@chromium.org
, Jun 10 2016