New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 618889 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
EstimatedDays: ----
NextAction: ----
OS: Linux , Android
Pri: 1
Type: Bug



Sign in to add a comment

Add gRPC to Chromium

Project Member Reported by xyzzyz@chromium.org, Jun 10 2016

Issue description

This involves adding gRPC to the Chromium's third_party, and setting up build rules.
 

Comment 1 by w...@chromium.org, Jun 20 2016

Labels: M-54 OS-Android OS-Linux
Status: Assigned (was: Untriaged)
Summary: Add gRPC to Chromium (was: add gRPC to Chromium)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/082e79e5c5dc5c50349c4b42076a97a39bc27ae4

commit 082e79e5c5dc5c50349c4b42076a97a39bc27ae4
Author: xyzzyz <xyzzyz@chromium.org>
Date: Mon Jun 20 18:59:21 2016

Add a gRPC repository to DEPS to fetch for Linux platform.

Adding gRPC was approved by Chrome Eng Review, as long as it is used only by
Blimp, which we plan to enforce by fetching it only on Linux, setting up
visibility rules in BUILD.gn files, and checkdeps.

gRPC was approved by open-source-third-party-reviews@google.com.

BUG= 618889 

Review-Url: https://codereview.chromium.org/2057883002
Cr-Commit-Position: refs/heads/master@{#400742}

[modify] https://crrev.com/082e79e5c5dc5c50349c4b42076a97a39bc27ae4/.gitignore
[modify] https://crrev.com/082e79e5c5dc5c50349c4b42076a97a39bc27ae4/DEPS
[modify] https://crrev.com/082e79e5c5dc5c50349c4b42076a97a39bc27ae4/tools/checklicenses/checklicenses.py

Labels: Blimp-M54-Proj-Scope
[Bulk edit]

Setting tracking label Blimp-M54-Proj-Scope.  This label is for scope tracking purposes only and should not be added / removed from any bugs, even if we add additional bugs to M-54 scope, or remove this bug from M-54 scope.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7c832341abc26616e346725337edb78ffaca881

commit a7c832341abc26616e346725337edb78ffaca881
Author: xyzzyz <xyzzyz@chromium.org>
Date: Tue Aug 16 00:35:52 2016

Roll gRPC deps: update to 3334ae71dca1c60ede931898ebee002f001ab755

BUG= 618889 

Review-Url: https://codereview.chromium.org/2253433002
Cr-Commit-Position: refs/heads/master@{#412114}

[modify] https://crrev.com/a7c832341abc26616e346725337edb78ffaca881/DEPS

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/588582ff4b9d12920646d72ba80c9d99973726e5

commit 588582ff4b9d12920646d72ba80c9d99973726e5
Author: xyzzyz <xyzzyz@chromium.org>
Date: Fri Aug 19 20:14:53 2016

Roll gRPC DEPS.

This updates README.chromium and fixes crosscompiling issue.

BUG= 618889 

Review-Url: https://codereview.chromium.org/2260023003
Cr-Commit-Position: refs/heads/master@{#413226}

[modify] https://crrev.com/588582ff4b9d12920646d72ba80c9d99973726e5/DEPS

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d0f694054f5b6b1bea03ce5f72bb70cab79b9a5

commit 4d0f694054f5b6b1bea03ce5f72bb70cab79b9a5
Author: xyzzyz <xyzzyz@chromium.org>
Date: Wed Sep 14 00:07:49 2016

Roll gRPC's DEPS to 3f186a41daa7c951234ea98cfaa50996047a47fd

BUG= 618889 

Review-Url: https://codereview.chromium.org/2337073005
Cr-Commit-Position: refs/heads/master@{#418426}

[modify] https://crrev.com/4d0f694054f5b6b1bea03ce5f72bb70cab79b9a5/DEPS

Comment 7 by xyzzyz@chromium.org, Oct 24 2016

Status: Fixed (was: Assigned)
Labels: Archive-Blimp

Sign in to add a comment