MacViews: Lots of failing views_unittests at r398760 |
|||
Issue descriptionChrome Version : 53.0.2764.0 OS Version: OS X 10.11.5 (all OSXes) It's not r398736 "Modify IsTextRTL to use GetFirstStrongCharacterDirection." - reverted that and they still fail. There's a 10.9 bot run at https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/241594, but they fail for me after syncing too. 38 tests failed: CustomButtonTest.ButtonClickTogglesInkDrop (../../ui/views/controls/button/custom_button_unittest.cc:350) CustomButtonTest.CaptureLossHidesInkDrop (../../ui/views/controls/button/custom_button_unittest.cc:366) CustomButtonTest.HoverStateOnVisibilityChange (../../ui/views/controls/button/custom_button_unittest.cc:142) HorizontalSliderTest.UpdateFromClickHorizontal (../../ui/views/controls/slider_unittest.cc:261) HorizontalSliderTest.UpdateFromClickRTLHorizontal (../../ui/views/controls/slider_unittest.cc:277) InkDropLabelButtonTest.HoverStateAfterMouseEnterAndExitEvents (../../ui/views/controls/button/label_button_unittest.cc:457) MenuButtonTest.ActivateDropDownOnMouseClick (../../ui/views/controls/button/menu_button_unittest.cc:342) MenuButtonTest.ButtonStateForMenuButtonsWithPressedLocks (../../ui/views/controls/button/menu_button_unittest.cc:355) MenuButtonTest.DraggableMenuButtonActivatesOnRelease (../../ui/views/controls/button/menu_button_unittest.cc:433) MenuButtonTest.PressedStateWithSiblingMenu (../../ui/views/controls/button/menu_button_unittest.cc:420) MenuRunnerTest.WidgetDoesntTakeCapture (../../ui/views/controls/menu/menu_runner_unittest.cc:220) TextfieldTest.ContextMenuDisplayTest (../../ui/views/controls/textfield/textfield_unittest.cc:1180) TextfieldTest.ControlAndSelectTest (../../ui/views/controls/textfield/textfield_unittest.cc:779) TextfieldTest.CursorMovement (../../ui/views/controls/textfield/textfield_unittest.cc:1075) TextfieldTest.CutCopyPaste (../../ui/views/controls/textfield/textfield_unittest.cc:1816) TextfieldTest.DeletionWithSelection (../../ui/views/controls/textfield/textfield_unittest.cc:873) TextfieldTest.DragAndDrop_ToTheLeft (../../ui/views/controls/textfield/textfield_unittest.cc:1442) TextfieldTest.DragAndDrop_ToTheRight (../../ui/views/controls/textfield/textfield_unittest.cc:1392) TextfieldTest.FocusTraversalTest (../../ui/views/controls/textfield/textfield_unittest.cc:1126) TextfieldTest.HitOutsideTextAreaInRTLTest (../../ui/views/controls/textfield/textfield_unittest.cc:2120) TextfieldTest.HitOutsideTextAreaTest (../../ui/views/controls/textfield/textfield_unittest.cc:2087) TextfieldTest.InsertionDeletionTest (../../ui/views/controls/textfield/textfield_unittest.cc:814) TextfieldTest.KeyTest (../../ui/views/controls/textfield/textfield_unittest.cc:728) TextfieldTest.KeysWithModifiersTest (../../ui/views/controls/textfield/textfield_unittest.cc:747) TextfieldTest.OnKeyPress (../../ui/views/controls/textfield/textfield_unittest.cc:964) TextfieldTest.OnKeyPressBinding (../../ui/views/controls/textfield/textfield_unittest.cc:1029) TextfieldTest.OverflowInRTLTest (../../ui/views/controls/textfield/textfield_unittest.cc:2183) TextfieldTest.OverflowTest (../../ui/views/controls/textfield/textfield_unittest.cc:2157) TextfieldTest.OvertypeMode (../../ui/views/controls/textfield/textfield_unittest.cc:1907) TextfieldTest.PasswordTest (../../ui/views/controls/textfield/textfield_unittest.cc:899) TextfieldTest.ReadOnlyTest (../../ui/views/controls/textfield/textfield_unittest.cc:1516) TextfieldTest.TextCursorDisplayInRTLTest (../../ui/views/controls/textfield/textfield_unittest.cc:1973) TextfieldTest.TextCursorDisplayTest (../../ui/views/controls/textfield/textfield_unittest.cc:1921) TextfieldTest.TextInputClientTest (../../ui/views/controls/textfield/textfield_unittest.cc:1584) TextfieldTest.UndoRedoTest (../../ui/views/controls/textfield/textfield_unittest.cc:1700) VerticalSliderTest.UpdateFromClickVertical (../../ui/views/controls/slider_unittest.cc:269) WidgetTest.CaptureDuringMousePressNotOverridden (../../ui/views/widget/widget_unittest.cc:1828) WidgetTest.MousePressCausesCapture (../../ui/views/widget/widget_unittest.cc:1765) 1 test crashed: TextfieldTest.DestroyingTextfieldFromOnKeyEvent (../../ui/views/controls/textfield/textfield_unittest.cc:2489) Tests took 46 seconds.
,
Jun 10 2016
Bisected to 3a5132a428812c397f17b99cfe9101863f8a851c is the first bad commit commit 3a5132a428812c397f17b99cfe9101863f8a851c Author: sadrul <sadrul@chromium.org> Date: Wed Jun 8 15:29:18 2016 -0700 views/mus: Run some more tests from views_unittests in mus. BUG= 577274 Review-Url: https://codereview.chromium.org/2010083002 Cr-Commit-Position: refs/heads/master@{#398705} The way the event generator is constructed changed in a few places, so it doesn't end up knowing which window to send events to on Mac. I think we just make the single-arg EventGenerator(gfx::NativeWindow) constructor work on Mac. (dropping priority, since it's just tests that are broken so nothing bogus is going to Canary - I should still get a fix out today though).
,
Jun 10 2016
https://codereview.chromium.org/2053253002/ .. seems simple enough. Fixes views_unittests. But I'll wait for more bots to report in.
,
Jun 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d688b3e828f5eb8cec391d0126e362cbf1eb48db commit d688b3e828f5eb8cec391d0126e362cbf1eb48db Author: tapted <tapted@chromium.org> Date: Mon Jun 13 06:29:02 2016 Support a ui::test::EventGenerator constructed with a single argument on Mac EventGeneratorDelegateMac::SetContext(..) ignores |root_window|. If that was all that's provided, assume it's the active window. This fixes all the Mac views_unittests regressions from r398705. BUG= 618880 Review-Url: https://codereview.chromium.org/2053253002 Cr-Commit-Position: refs/heads/master@{#399409} [modify] https://crrev.com/d688b3e828f5eb8cec391d0126e362cbf1eb48db/ui/events/test/event_generator.h [modify] https://crrev.com/d688b3e828f5eb8cec391d0126e362cbf1eb48db/ui/views/test/event_generator_delegate_mac.mm
,
Jun 13 2016
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d688b3e828f5eb8cec391d0126e362cbf1eb48db commit d688b3e828f5eb8cec391d0126e362cbf1eb48db Author: tapted <tapted@chromium.org> Date: Mon Jun 13 06:29:02 2016 Support a ui::test::EventGenerator constructed with a single argument on Mac EventGeneratorDelegateMac::SetContext(..) ignores |root_window|. If that was all that's provided, assume it's the active window. This fixes all the Mac views_unittests regressions from r398705. BUG= 618880 Review-Url: https://codereview.chromium.org/2053253002 Cr-Commit-Position: refs/heads/master@{#399409} [modify] https://crrev.com/d688b3e828f5eb8cec391d0126e362cbf1eb48db/ui/events/test/event_generator.h [modify] https://crrev.com/d688b3e828f5eb8cec391d0126e362cbf1eb48db/ui/views/test/event_generator_delegate_mac.mm |
|||
►
Sign in to add a comment |
|||
Comment 1 by tapted@chromium.org
, Jun 9 2016