New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 618868 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

FirmwareTest._call_action should report failures better.

Project Member Reported by aaboagye@chromium.org, Jun 9 2016

Issue description

Currently, when a FirmwareTest which calls the check_state method fails, it fails with a message that isn't so helpful.

For example,

TestFail: Not succeed: calling <bound method FAFTCheckers.crossystem_checker of <autotest_lib.server.cros.faft.utils.faft_checkers.FAFTCheckers object at 0x7f09869fb3d0>> with args ({'recovery_reason': '193', 'mainfw_type': 'recovery'},) returning False

It doesn't report back what actually failed. You can find this information in the logs, but I think it would be better if it were reported here. This is the string that's bubbled up to to the dashboards and such. 

Here's what is shown in the full debug logs:

06/08 04:44:45.194 INFO |     faft_checkers:0105| Expected 'recovery_reason' value '193' but got '0'
06/08 04:44:45.195 INFO |     faft_checkers:0105| Expected 'mainfw_type' value 'recovery' but got 'normal'
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jun 12 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Type-Bug -Hotlist-Recharge-Cold Type-Feature
Status: Available (was: Untriaged)
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 12 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment