New issue
Advanced search Search tips

Issue 618864 link

Starred by 2 users
Status: Assigned
Owner:
qin...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature



Sign in to add a comment

Study download cancel reasons with Chrome network stack

Project Member Reported by qin...@chromium.org, Jun 9 2016 
when rolling out the change to switch download to chrome network stack, we saw a high canceling rate (16%). And we don't have the statistics from android Downloadmanager.

Want to understand why user cancels the download.

Comment 1 by krav...@chromium.org, Jun 10 2016

Status: Assigned (was: Unconfirmed)
Project Member

Comment 2 by sheriffbot@chromium.org, Jun 10 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8211e681b8a98df75bf56e05d30d4179033cee3e

commit 8211e681b8a98df75bf56e05d30d4179033cee3e
Author: qinmin <qinmin@chromium.org>
Date: Mon Jun 13 20:16:30 2016

Add UMA for studying download cancellation reasons

We found high cancellation rate with new download experiment.
This CL is to study why user cancels the download

BUG=618864

Review-Url: https://codereview.chromium.org/2058593002
Cr-Commit-Position: refs/heads/master@{#399521}

[modify] https://crrev.com/8211e681b8a98df75bf56e05d30d4179033cee3e/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
[modify] https://crrev.com/8211e681b8a98df75bf56e05d30d4179033cee3e/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
[modify] https://crrev.com/8211e681b8a98df75bf56e05d30d4179033cee3e/chrome/browser/android/download/chrome_download_manager_overwrite_infobar_delegate.cc
[modify] https://crrev.com/8211e681b8a98df75bf56e05d30d4179033cee3e/chrome/browser/android/download/download_manager_service.cc
[modify] https://crrev.com/8211e681b8a98df75bf56e05d30d4179033cee3e/chrome/browser/android/download/download_manager_service.h
[modify] https://crrev.com/8211e681b8a98df75bf56e05d30d4179033cee3e/content/browser/android/download_controller_android_impl.cc
[modify] https://crrev.com/8211e681b8a98df75bf56e05d30d4179033cee3e/content/public/browser/android/download_controller_android.h
[modify] https://crrev.com/8211e681b8a98df75bf56e05d30d4179033cee3e/tools/metrics/histograms/histograms.xml

Comment 4 by qin...@chromium.org, Jun 13 2016

Labels: -M-53 -MovedFrom-52 Merge-Request-52 M-52 Type-Feature
This should belong to feature  crbug.com/460603 . While launching the feature in M51, we got some negative user feedbacks and a high cancellation rate. To help improve the feature, we need to study why the cancellation rate is high. Since M51 is already launched, we want study the behavior on Beta channels, which is already in a 50% finch study.

Comment 5 by tin...@google.com, Jun 13 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 13 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6804ef5b24b659d083dcfbda0bc5b8faa2d03a2

commit a6804ef5b24b659d083dcfbda0bc5b8faa2d03a2
Author: Min Qin <qinmin@chromium.org>
Date: Mon Jun 13 23:43:34 2016

Add UMA for studying download cancellation reasons

We found high cancellation rate with new download experiment.
This CL is to study why user cancels the download

TBR=tedchoc@chromium.org
BUG=618864

Review-Url: https://codereview.chromium.org/2058593002
Cr-Commit-Position: refs/heads/master@{#399521}
(cherry picked from commit 8211e681b8a98df75bf56e05d30d4179033cee3e)

Review URL: https://codereview.chromium.org/2061063002 .

Cr-Commit-Position: refs/branch-heads/2743@{#342}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/a6804ef5b24b659d083dcfbda0bc5b8faa2d03a2/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
[modify] https://crrev.com/a6804ef5b24b659d083dcfbda0bc5b8faa2d03a2/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
[modify] https://crrev.com/a6804ef5b24b659d083dcfbda0bc5b8faa2d03a2/chrome/browser/android/download/chrome_download_manager_overwrite_infobar_delegate.cc
[modify] https://crrev.com/a6804ef5b24b659d083dcfbda0bc5b8faa2d03a2/chrome/browser/android/download/download_manager_service.cc
[modify] https://crrev.com/a6804ef5b24b659d083dcfbda0bc5b8faa2d03a2/chrome/browser/android/download/download_manager_service.h
[modify] https://crrev.com/a6804ef5b24b659d083dcfbda0bc5b8faa2d03a2/content/browser/android/download_controller_android_impl.cc
[modify] https://crrev.com/a6804ef5b24b659d083dcfbda0bc5b8faa2d03a2/content/public/browser/android/download_controller_android.h
[modify] https://crrev.com/a6804ef5b24b659d083dcfbda0bc5b8faa2d03a2/tools/metrics/histograms/histograms.xml

Comment 7 by qin...@chromium.org, Jun 14 2016

Status: Fixed (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8211e681b8a98df75bf56e05d30d4179033cee3e

commit 8211e681b8a98df75bf56e05d30d4179033cee3e
Author: qinmin <qinmin@chromium.org>
Date: Mon Jun 13 20:16:30 2016

Add UMA for studying download cancellation reasons

We found high cancellation rate with new download experiment.
This CL is to study why user cancels the download

BUG=618864

Review-Url: https://codereview.chromium.org/2058593002
Cr-Commit-Position: refs/heads/master@{#399521}

[modify] https://crrev.com/8211e681b8a98df75bf56e05d30d4179033cee3e/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
[modify] https://crrev.com/8211e681b8a98df75bf56e05d30d4179033cee3e/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
[modify] https://crrev.com/8211e681b8a98df75bf56e05d30d4179033cee3e/chrome/browser/android/download/chrome_download_manager_overwrite_infobar_delegate.cc
[modify] https://crrev.com/8211e681b8a98df75bf56e05d30d4179033cee3e/chrome/browser/android/download/download_manager_service.cc
[modify] https://crrev.com/8211e681b8a98df75bf56e05d30d4179033cee3e/chrome/browser/android/download/download_manager_service.h
[modify] https://crrev.com/8211e681b8a98df75bf56e05d30d4179033cee3e/content/browser/android/download_controller_android_impl.cc
[modify] https://crrev.com/8211e681b8a98df75bf56e05d30d4179033cee3e/content/public/browser/android/download_controller_android.h
[modify] https://crrev.com/8211e681b8a98df75bf56e05d30d4179033cee3e/tools/metrics/histograms/histograms.xml
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6804ef5b24b659d083dcfbda0bc5b8faa2d03a2

commit a6804ef5b24b659d083dcfbda0bc5b8faa2d03a2
Author: Min Qin <qinmin@chromium.org>
Date: Mon Jun 13 23:43:34 2016

Add UMA for studying download cancellation reasons

We found high cancellation rate with new download experiment.
This CL is to study why user cancels the download

TBR=tedchoc@chromium.org
BUG=618864

Review-Url: https://codereview.chromium.org/2058593002
Cr-Commit-Position: refs/heads/master@{#399521}
(cherry picked from commit 8211e681b8a98df75bf56e05d30d4179033cee3e)

Review URL: https://codereview.chromium.org/2061063002 .

Cr-Commit-Position: refs/branch-heads/2743@{#342}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/a6804ef5b24b659d083dcfbda0bc5b8faa2d03a2/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
[modify] https://crrev.com/a6804ef5b24b659d083dcfbda0bc5b8faa2d03a2/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
[modify] https://crrev.com/a6804ef5b24b659d083dcfbda0bc5b8faa2d03a2/chrome/browser/android/download/chrome_download_manager_overwrite_infobar_delegate.cc
[modify] https://crrev.com/a6804ef5b24b659d083dcfbda0bc5b8faa2d03a2/chrome/browser/android/download/download_manager_service.cc
[modify] https://crrev.com/a6804ef5b24b659d083dcfbda0bc5b8faa2d03a2/chrome/browser/android/download/download_manager_service.h
[modify] https://crrev.com/a6804ef5b24b659d083dcfbda0bc5b8faa2d03a2/content/browser/android/download_controller_android_impl.cc
[modify] https://crrev.com/a6804ef5b24b659d083dcfbda0bc5b8faa2d03a2/content/public/browser/android/download_controller_android.h
[modify] https://crrev.com/a6804ef5b24b659d083dcfbda0bc5b8faa2d03a2/tools/metrics/histograms/histograms.xml
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/513a888b2e3fb9b99fb623d32d22b6059c93951f

commit 513a888b2e3fb9b99fb623d32d22b6059c93951f
Author: qinmin <qinmin@chromium.org>
Date: Thu Jun 30 20:43:23 2016

Record one more reason that download is canceled

Download was cancelled when a dangerous download infobar is dismissed.
We missed it in the previous CL.

BUG=618864

Review-Url: https://codereview.chromium.org/2111983002
Cr-Commit-Position: refs/heads/master@{#403274}

[modify] https://crrev.com/513a888b2e3fb9b99fb623d32d22b6059c93951f/chrome/browser/android/download/download_controller.cc
[modify] https://crrev.com/513a888b2e3fb9b99fb623d32d22b6059c93951f/chrome/browser/android/download/download_controller.h
[modify] https://crrev.com/513a888b2e3fb9b99fb623d32d22b6059c93951f/tools/metrics/histograms/histograms.xml

Comment 11 by qin...@chromium.org, Jun 30 2016

Labels: -Hotlist-Merge-Approved -merge-merged-2743 Merge-Request-52
Status: Assigned (was: Fixed)
request to merge the CL in comment 10 to M52 so that we can get better UMA while running 1% experiment on stable

Comment 12 by dimu@google.com, Jun 30 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 13 by sheriffbot@chromium.org, Jul 1 2016 

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 14 by bugdroid1@chromium.org, Jul 1 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2959ac849dd9cc9868c2966923803dc3880cee63

commit 2959ac849dd9cc9868c2966923803dc3880cee63
Author: Min Qin <qinmin@chromium.org>
Date: Fri Jul 01 17:02:54 2016

Record one more reason that download is canceled

Download was cancelled when a dangerous download infobar is dismissed.
We missed it in the previous CL.

TBR=isherman@chromium.org,tedchoc@chromium.org
BUG=618864

Review-Url: https://codereview.chromium.org/2111983002
Cr-Commit-Position: refs/heads/master@{#403274}
(cherry picked from commit 513a888b2e3fb9b99fb623d32d22b6059c93951f)

Review URL: https://codereview.chromium.org/2117833002 .

Cr-Commit-Position: refs/branch-heads/2743@{#568}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/2959ac849dd9cc9868c2966923803dc3880cee63/content/browser/android/download_controller_android_impl.cc
[modify] https://crrev.com/2959ac849dd9cc9868c2966923803dc3880cee63/content/public/browser/android/download_controller_android.h
[modify] https://crrev.com/2959ac849dd9cc9868c2966923803dc3880cee63/tools/metrics/histograms/histograms.xml
►

Sign in to add a comment