New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 618862 link

Starred by 2 users
Status: Fixed
Owner:
█ stanisc@chromium.org
not on Chrome anymore
Closed: Sep 2016
Cc:
█ nick@chromium.org
afakhry@chromium.org
chrome-perf-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 620832



Sign in to add a comment

New Task Manager on Windows should use PrivateWorkingSetSnapshot

Project Member Reported by brucedaw...@chromium.org, Jun 9 2016 
The PrivateWorkingSetSnapshot class, added in crrev.com/1181263005, provides a more efficient way of getting the private working set than using QueryWorkingSet (which is what ProcessMetrics::GetWorkingSetKBytes uses). It can easily take several ms per tab to get memory information using ProcessMetrics::GetWorkingSetKBytes, and PrivateWorkingSetSnapshot is much faster, especially when there are many tabs open.

Assigning to myself since I wrote PrivateWorkingSetSnapshot initially. If somebody else grabs it first that's okay.

Comment 1 by brucedaw...@chromium.org, Jul 6 2016

Blocking: 620832

Comment 2 by brucedaw...@chromium.org, Jul 14 2016

Owner: stanisc@chromium.org
Stan volunteered to take this.

Comment 3 by stanisc@chromium.org, Aug 13 2016

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8d8427d83905a9fc64242dde7b21f1a8eda839c

commit a8d8427d83905a9fc64242dde7b21f1a8eda839c
Author: stanisc <stanisc@chromium.org>
Date: Tue Aug 30 03:58:53 2016

Task manager: Get physical memory efficiently for all processes from SharedSampler.

This leverages recently introduced SharedSampler to get
Physical Memory (Memory column) efficiently for all
processes in one go. This applies only to Windows
implementation. Two other memory columns which aren't
shown by default are still mapped to the old, more
expensive implementation.

BUG= 618862 

Review-Url: https://codereview.chromium.org/2238403003
Cr-Commit-Position: refs/heads/master@{#415066}

[modify] https://crrev.com/a8d8427d83905a9fc64242dde7b21f1a8eda839c/chrome/browser/task_manager/sampling/shared_sampler.h
[modify] https://crrev.com/a8d8427d83905a9fc64242dde7b21f1a8eda839c/chrome/browser/task_manager/sampling/shared_sampler_posix.cc
[add] https://crrev.com/a8d8427d83905a9fc64242dde7b21f1a8eda839c/chrome/browser/task_manager/sampling/shared_sampler_unittest_win.cc
[modify] https://crrev.com/a8d8427d83905a9fc64242dde7b21f1a8eda839c/chrome/browser/task_manager/sampling/shared_sampler_win.cc
[modify] https://crrev.com/a8d8427d83905a9fc64242dde7b21f1a8eda839c/chrome/browser/task_manager/sampling/task_group.cc
[modify] https://crrev.com/a8d8427d83905a9fc64242dde7b21f1a8eda839c/chrome/browser/task_manager/sampling/task_group.h
[modify] https://crrev.com/a8d8427d83905a9fc64242dde7b21f1a8eda839c/chrome/browser/task_manager/task_manager_observer.h
[modify] https://crrev.com/a8d8427d83905a9fc64242dde7b21f1a8eda839c/chrome/browser/ui/task_manager/task_manager_table_model.cc
[delete] https://crrev.com/2ff54586e0102659c1034d58269ac376d1aacc20/chrome/browser/win/private_working_set_snapshot.cc
[delete] https://crrev.com/2ff54586e0102659c1034d58269ac376d1aacc20/chrome/browser/win/private_working_set_snapshot.h
[delete] https://crrev.com/2ff54586e0102659c1034d58269ac376d1aacc20/chrome/browser/win/private_working_set_snapshot_unittest.cc
[modify] https://crrev.com/a8d8427d83905a9fc64242dde7b21f1a8eda839c/chrome/chrome_browser.gypi
[modify] https://crrev.com/a8d8427d83905a9fc64242dde7b21f1a8eda839c/chrome/chrome_tests_unit.gypi

Comment 5 by stanisc@chromium.org, Sep 13 2016

Status: Fixed (was: Started)
►

Sign in to add a comment