New issue
Advanced search Search tips

Issue 618860 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Feature

Blocking:
issue 587995



Sign in to add a comment

Add totalAmount to PaymentResponse

Project Member Reported by rouslan@chromium.org, Jun 9 2016

Issue description

Status: Started (was: Available)
Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65f870288f6c830606d8eb9b0510cd0f156724b8

commit 65f870288f6c830606d8eb9b0510cd0f156724b8
Author: rouslan <rouslan@chromium.org>
Date: Tue Jun 14 02:35:21 2016

Add totalAmount to PaymentResponse.

This patch adds the totalAmount to PaymentResponse. This reflects the
total amount that the user has confirmed they will pay. The change that
introduced totalAmount also introduced PaymentMethodModifier, which is
not in this patch.

https://w3c.github.io/browser-payment-api/#paymentresponse-interface
https://github.com/w3c/browser-payment-api/commit/67f4f25f4a0562e7b13c5139e1bb8f8b1d41f53a

BUG= 618860 

Review-Url: https://codereview.chromium.org/2062583002
Cr-Commit-Position: refs/heads/master@{#399644}

[modify] https://crrev.com/65f870288f6c830606d8eb9b0510cd0f156724b8/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/65f870288f6c830606d8eb9b0510cd0f156724b8/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java
[modify] https://crrev.com/65f870288f6c830606d8eb9b0510cd0f156724b8/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java
[modify] https://crrev.com/65f870288f6c830606d8eb9b0510cd0f156724b8/chrome/test/data/android/payments/dynamic_shipping.js
[modify] https://crrev.com/65f870288f6c830606d8eb9b0510cd0f156724b8/chrome/test/data/android/payments/free_shipping.js
[modify] https://crrev.com/65f870288f6c830606d8eb9b0510cd0f156724b8/chrome/test/data/android/payments/no_shipping.js
[modify] https://crrev.com/65f870288f6c830606d8eb9b0510cd0f156724b8/third_party/WebKit/LayoutTests/payments/promises-keep-request-alive.html
[modify] https://crrev.com/65f870288f6c830606d8eb9b0510cd0f156724b8/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/65f870288f6c830606d8eb9b0510cd0f156724b8/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp
[modify] https://crrev.com/65f870288f6c830606d8eb9b0510cd0f156724b8/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp
[modify] https://crrev.com/65f870288f6c830606d8eb9b0510cd0f156724b8/third_party/WebKit/Source/modules/payments/PaymentResponse.h
[modify] https://crrev.com/65f870288f6c830606d8eb9b0510cd0f156724b8/third_party/WebKit/Source/modules/payments/PaymentResponse.idl
[modify] https://crrev.com/65f870288f6c830606d8eb9b0510cd0f156724b8/third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp
[modify] https://crrev.com/65f870288f6c830606d8eb9b0510cd0f156724b8/third_party/WebKit/Source/modules/payments/PaymentTestHelper.cpp
[modify] https://crrev.com/65f870288f6c830606d8eb9b0510cd0f156724b8/third_party/WebKit/Source/modules/payments/PaymentTestHelper.h
[modify] https://crrev.com/65f870288f6c830606d8eb9b0510cd0f156724b8/third_party/WebKit/public/platform/modules/payments/payment_request.mojom

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65f870288f6c830606d8eb9b0510cd0f156724b8

commit 65f870288f6c830606d8eb9b0510cd0f156724b8
Author: rouslan <rouslan@chromium.org>
Date: Tue Jun 14 02:35:21 2016

Add totalAmount to PaymentResponse.

This patch adds the totalAmount to PaymentResponse. This reflects the
total amount that the user has confirmed they will pay. The change that
introduced totalAmount also introduced PaymentMethodModifier, which is
not in this patch.

https://w3c.github.io/browser-payment-api/#paymentresponse-interface
https://github.com/w3c/browser-payment-api/commit/67f4f25f4a0562e7b13c5139e1bb8f8b1d41f53a

BUG= 618860 

Review-Url: https://codereview.chromium.org/2062583002
Cr-Commit-Position: refs/heads/master@{#399644}

[modify] https://crrev.com/65f870288f6c830606d8eb9b0510cd0f156724b8/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/65f870288f6c830606d8eb9b0510cd0f156724b8/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java
[modify] https://crrev.com/65f870288f6c830606d8eb9b0510cd0f156724b8/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java
[modify] https://crrev.com/65f870288f6c830606d8eb9b0510cd0f156724b8/chrome/test/data/android/payments/dynamic_shipping.js
[modify] https://crrev.com/65f870288f6c830606d8eb9b0510cd0f156724b8/chrome/test/data/android/payments/free_shipping.js
[modify] https://crrev.com/65f870288f6c830606d8eb9b0510cd0f156724b8/chrome/test/data/android/payments/no_shipping.js
[modify] https://crrev.com/65f870288f6c830606d8eb9b0510cd0f156724b8/third_party/WebKit/LayoutTests/payments/promises-keep-request-alive.html
[modify] https://crrev.com/65f870288f6c830606d8eb9b0510cd0f156724b8/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/65f870288f6c830606d8eb9b0510cd0f156724b8/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp
[modify] https://crrev.com/65f870288f6c830606d8eb9b0510cd0f156724b8/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp
[modify] https://crrev.com/65f870288f6c830606d8eb9b0510cd0f156724b8/third_party/WebKit/Source/modules/payments/PaymentResponse.h
[modify] https://crrev.com/65f870288f6c830606d8eb9b0510cd0f156724b8/third_party/WebKit/Source/modules/payments/PaymentResponse.idl
[modify] https://crrev.com/65f870288f6c830606d8eb9b0510cd0f156724b8/third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp
[modify] https://crrev.com/65f870288f6c830606d8eb9b0510cd0f156724b8/third_party/WebKit/Source/modules/payments/PaymentTestHelper.cpp
[modify] https://crrev.com/65f870288f6c830606d8eb9b0510cd0f156724b8/third_party/WebKit/Source/modules/payments/PaymentTestHelper.h
[modify] https://crrev.com/65f870288f6c830606d8eb9b0510cd0f156724b8/third_party/WebKit/public/platform/modules/payments/payment_request.mojom

Sign in to add a comment