New issue
Advanced search Search tips

Issue 618852 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

OmniboxViewTest.CopyURLToClipboard fails with GN

Project Member Reported by steve...@chromium.org, Jun 9 2016

Issue description

When running:

interactive_ui_tests --gtest_filter=OmniboxViewTest.CopyURLToClipboard

The following error shows up in the log:

[124042:124042:0609/154305:ERROR:service_registry_impl.cc(98)] mojom::ResourceUsageReporter not found

And the test fails.

I looked at the .gn files, and it seems like resource_usage_reporter.mojom (which contains ResourceUsageReporter) is included in chrome/common:mojo_bindings (and if I remove that, interactive_ui_tests fails to compile).

I'm not sure what is going on there, or why (or if) that would be affecting this test, but it was the only significant difference in the output from the GYP build.


 
Owner: steve...@chromium.org
Status: Started (was: Assigned)
Nevermind, I figured this out, we were setting use_clipboard_aurax11 incorrectly.

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cba53b32d8b2bff2db94deccbe0a393e1056edbb

commit cba53b32d8b2bff2db94deccbe0a393e1056edbb
Author: stevenjb <stevenjb@chromium.org>
Date: Fri Jun 10 05:39:33 2016

GN: Set and use use_clipboard_aurax11 correctly

BUG= 618852 

Review-Url: https://codereview.chromium.org/2058623002
Cr-Commit-Position: refs/heads/master@{#399110}

[modify] https://crrev.com/cba53b32d8b2bff2db94deccbe0a393e1056edbb/build/config/ui.gni
[modify] https://crrev.com/cba53b32d8b2bff2db94deccbe0a393e1056edbb/ui/base/BUILD.gn

Status: Fixed (was: Started)
I think this is fixed now ...
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cba53b32d8b2bff2db94deccbe0a393e1056edbb

commit cba53b32d8b2bff2db94deccbe0a393e1056edbb
Author: stevenjb <stevenjb@chromium.org>
Date: Fri Jun 10 05:39:33 2016

GN: Set and use use_clipboard_aurax11 correctly

BUG= 618852 

Review-Url: https://codereview.chromium.org/2058623002
Cr-Commit-Position: refs/heads/master@{#399110}

[modify] https://crrev.com/cba53b32d8b2bff2db94deccbe0a393e1056edbb/build/config/ui.gni
[modify] https://crrev.com/cba53b32d8b2bff2db94deccbe0a393e1056edbb/ui/base/BUILD.gn

Status: Verified (was: Fixed)
Bulk verified

Sign in to add a comment