New issue
Advanced search Search tips

Issue 618813 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Setting window.name to the same name should NOT change unique name of the frame.

Project Member Reported by lukasza@chromium.org, Jun 9 2016

Issue description

Fact: Recalculating unique name depends on state of other frames (and therefore calculating unique name for the same assigned name can give different result, depending on the sate of other frames).

Requirement: Setting window.name to the same value should not change unique name.

Currently this requirement is not met - with a carefully crafted layout test we can hit the DCHECK below:

  content/browser/frame_host/frame_tree_node.cc:

    void FrameTreeNode::SetFrameName(const std::string& name,
                                     const std::string& unique_name) {
      if (name == replication_state_.name) {
        // |unique_name| shouldn't change unless |name| changes.
        DCHECK_EQ(unique_name, replication_state_.unique_name);
        return;
      }

 
Status: Started (was: Untriaged)
Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/543dc5fcb73056046770cf5489ace558811ff20d

commit 543dc5fcb73056046770cf5489ace558811ff20d
Author: lukasza <lukasza@chromium.org>
Date: Fri Jun 17 20:54:03 2016

More aggressive DCHECKs for FrameTree::setName.

BUG= 618813 

Review-Url: https://codereview.chromium.org/2078643002
Cr-Commit-Position: refs/heads/master@{#400500}

[modify] https://crrev.com/543dc5fcb73056046770cf5489ace558811ff20d/third_party/WebKit/Source/core/page/FrameTree.cpp

Sign in to add a comment