New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 618808 link

Starred by 1 user
Status: Fixed
Owner:
█ moshayedi@chromium.org
Last visit > 30 days ago
Closed: Jun 2016
Cc:
█ fsam...@chromium.org
█ ben@chromium.org
sadrul@chromium.org
jamescook@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature
mus



Sign in to add a comment

Re-organize event mojom files

Project Member Reported by moshayedi@chromium.org, Jun 9 2016 
1. event related mojom files are currently in //components/mus/public/interfaces, but they should move to //ui/events/mojo/.
2. Their naming should be consistent with the matching header file in //ui/events (i.e. input_events.mojom should be renamed to event.mojom).
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1637da1d27e0a28a16c1c6954c97f94111cd448

commit b1637da1d27e0a28a16c1c6954c97f94111cd448
Author: moshayedi <moshayedi@chromium.org>
Date: Mon Jun 13 15:32:48 2016

Reorganize event mojom files.

* Moves input_events.mojom to //ui/events/mojo/event.mojom.
* Moves input_event_constants.mojom to //ui/events/mojo/event_constants.mojom.
* Moves input_key_codes.mojom to //ui/events/mojo/keyboard_codes.mojom.

BUG= 618808 

Review-Url: https://codereview.chromium.org/2057793002
Cr-Commit-Position: refs/heads/master@{#399454}

[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/ash/mus/accelerator_registrar_unittest.cc
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/ash/mus/root_window_controller.cc
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/ash/mus/window_manager.cc
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/common/event_matcher_util.cc
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/common/event_matcher_util.h
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/public/cpp/tests/window_tree_client_unittest.cc
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/public/cpp/window_manager_delegate.h
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/public/interfaces/BUILD.gn
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/public/interfaces/accelerator_registrar.mojom
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/public/interfaces/event_matcher.mojom
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/public/interfaces/window_manager.mojom
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/public/interfaces/window_tree.mojom
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/ws/accelerator.cc
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/ws/accelerator.h
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/ws/event_dispatcher.cc
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/ws/event_dispatcher.h
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/ws/event_dispatcher_unittest.cc
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/ws/event_matcher.cc
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/ws/event_matcher.h
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/ws/event_matcher_unittest.cc
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/ws/window_manager_state.cc
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/ws/window_manager_state_unittest.cc
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/ws/window_tree.cc
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/ws/window_tree_unittest.cc
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/content/renderer/mus/compositor_mus_connection.cc
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/content/renderer/mus/compositor_mus_connection_unittest.cc
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/mash/app_driver/app_driver.cc
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/ui/events/mojo/BUILD.gn
[rename] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/ui/events/mojo/event.mojom
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/ui/events/mojo/event.typemap
[rename] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/ui/events/mojo/event_constants.mojom
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/ui/events/mojo/event_struct_traits.cc
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/ui/events/mojo/event_struct_traits.h
[rename] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/ui/events/mojo/keyboard_codes.mojom
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/ui/events/mojo/traits_test_service.mojom
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/ui/views/mus/window_manager_connection.cc

Comment 2 by moshayedi@chromium.org, Jun 13 2016

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1637da1d27e0a28a16c1c6954c97f94111cd448

commit b1637da1d27e0a28a16c1c6954c97f94111cd448
Author: moshayedi <moshayedi@chromium.org>
Date: Mon Jun 13 15:32:48 2016

Reorganize event mojom files.

* Moves input_events.mojom to //ui/events/mojo/event.mojom.
* Moves input_event_constants.mojom to //ui/events/mojo/event_constants.mojom.
* Moves input_key_codes.mojom to //ui/events/mojo/keyboard_codes.mojom.

BUG= 618808 

Review-Url: https://codereview.chromium.org/2057793002
Cr-Commit-Position: refs/heads/master@{#399454}

[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/ash/mus/accelerator_registrar_unittest.cc
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/ash/mus/root_window_controller.cc
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/ash/mus/window_manager.cc
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/common/event_matcher_util.cc
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/common/event_matcher_util.h
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/public/cpp/tests/window_tree_client_unittest.cc
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/public/cpp/window_manager_delegate.h
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/public/interfaces/BUILD.gn
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/public/interfaces/accelerator_registrar.mojom
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/public/interfaces/event_matcher.mojom
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/public/interfaces/window_manager.mojom
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/public/interfaces/window_tree.mojom
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/ws/accelerator.cc
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/ws/accelerator.h
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/ws/event_dispatcher.cc
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/ws/event_dispatcher.h
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/ws/event_dispatcher_unittest.cc
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/ws/event_matcher.cc
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/ws/event_matcher.h
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/ws/event_matcher_unittest.cc
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/ws/window_manager_state.cc
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/ws/window_manager_state_unittest.cc
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/ws/window_tree.cc
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/components/mus/ws/window_tree_unittest.cc
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/content/renderer/mus/compositor_mus_connection.cc
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/content/renderer/mus/compositor_mus_connection_unittest.cc
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/mash/app_driver/app_driver.cc
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/ui/events/mojo/BUILD.gn
[rename] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/ui/events/mojo/event.mojom
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/ui/events/mojo/event.typemap
[rename] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/ui/events/mojo/event_constants.mojom
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/ui/events/mojo/event_struct_traits.cc
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/ui/events/mojo/event_struct_traits.h
[rename] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/ui/events/mojo/keyboard_codes.mojom
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/ui/events/mojo/traits_test_service.mojom
[modify] https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448/ui/views/mus/window_manager_connection.cc

Comment 4 by lafo...@chromium.org, Feb 26 2018

Components: Internals>Services>WindowService

Comment 5 by lafo...@chromium.org, Feb 26 2018

Components: -MUS>Phase>1
►

Sign in to add a comment