Soft undo keyboard shortcut is not working in devtools Sources panel
Reported by
cont...@jaygeorge.co.uk,
Jun 9 2016
|
||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2761.0 Safari/537.36 Steps to reproduce the problem: 1. In sources view press cmd + d to highlight the next occurrence 2. Press cmd + u to try and soft undo selection What is the expected behavior? Devtools un-lights the last selection, as per the soft undo command. What went wrong? The soft undo command no longer works. Nothing happens. Did this work before? Yes About a month or two ago Chrome version: 53.0.2761.0 Channel: n/a OS Version: OS X 10.11.5 Flash Version: Shockwave Flash 22.0 r0
,
Jun 10 2016
,
Jun 14 2016
Thank you for reporting. I was able to repro earlier this week, but after trying again on Mac, Canary 53.0.2766.0, I'm unable to repro. Are you still seeing it broken after updating?
,
Jun 14 2016
I was on 53.0.2765.0 yesterday. I just upgraded to 53.0.2766.0 and it's still broken for me. Jay
,
Jun 21 2016
I've tried out soft undo and found it working (not broken) in several cases. In the cases I've tried, it seems that this bug only consistently appears on pretty-fied formatted files and HTML files. For example repro, soft undo is broken on "http://asdf.com/" in the "(index)" source and on "ga.js" in the google-analytics folder after you click the Pretty Print button. I can get started on these 2 cases. It looks like they've been broken before, so this is actually not a regression. Could you please let me know if there are other non-HTML or non-prettified cases where soft undo is broken? Thanks!
,
Jun 21 2016
I just tried on 53.0.2774.2 and it's still broken for me. I've attached a video to show it broken. I've also just tried in Chrome stable (51.0.2704) and it is broken there too. Are you a different OS per chance?
,
Jun 21 2016
Thank you for the helpful screencast! I can confirm this bug on Stable and Canary as well, Linux and Mac. It seems that only readonly files are affected. CL in review https://codereview.chromium.org/2080603008/
,
Jun 27 2016
Github issue created https://github.com/codemirror/CodeMirror/issues/4090
,
Jun 27 2016
,
Jun 30 2016
CodeMirror v5.16.2 has fixed soft-undo for read-only files. Now we just need to bump up the version in DevTools.
,
Jul 19 2016
,
Aug 20 2016
FYI I'm not sure what you mean by "read only files" are affected. I'm working on live projects in the "Sources" panel and writing to disk, and this problem is still there in Chrome Canary 54.0.2834.0
,
Oct 29 2017
This still broken, over a year later, even though it's an advertised keyboard shortcut. Reading through the thread, I think you misdiagnosed — This is not to do with "readonly files", it is affecting the main "text editor" in DevTools. To show that it's broken, I've attached a video of a very simple 10 second demo in the latest DevTools.
,
Oct 12
,
Oct 15
Could you let me know which version you've fixed this in so I can verify the fix? Thanks |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by l...@chromium.org
, Jun 9 2016Status: Assigned (was: Unconfirmed)