Desktop Capture Picker Window New UI For Mac |
|||||||||||
Issue descriptionThis bug relates to crbug/602478 After the development of Tab Capture and Audio Capture feature for Desktop Sharing. The old UI of picker window looks confusing for the end user. Thus we need a new UI design for the picker window. The general design doc: https://docs.google.com/presentation/d/1xIgk_xNpa-4yBSR4DIcoDLfBFigu7SJwFWOdIzSC8r4/ This bug mainly focused on the Mac implementation. As making the appearance identical to the above design, we need to subclass almost all the elements, which is a huge project. We think it is unnecessary to do that way, and thus we decide to implement Mac's Desktop Picker Window in Cocoa style. See the attachments for snapshots from my mock dev. Comments and suggestions are welcome.
,
Jun 9 2016
,
Jun 10 2016
Should we go with something that looks a little more like the collected cookies dialog? Or the system Display Preferences. Not having those buttons centered looks kinda weird. Also OSX likes to put them at the top of the dialog in most cases I've seen. The text: "Foo would like to share your screen..." text. Would it still make sense to put it below the buttons? Maybe it should *actually* change when the tabs change.
,
Jun 10 2016
I tried that way, I can upload the screenshots later. One thing I do not like is that it looks like "double border" for the content viewer.
,
Jun 10 2016
What kind of time constraints are you under? We (the Mac team and UX) are having some overarching UI discussions right now. We might be able to give you some direction on this in the next couple of days, and odds are you will be able to start from your non-Mac implementation (so much less work than starting from scratch).
,
Jun 10 2016
Using NSTabView. In the NSTabViewItem, we have only an IKImageBrowserView or an NSTableView. The Overral effect would look like a "double" border, which I do not like. Any suggestions?
,
Jun 10 2016
Hello everyone working on this, I ask again what kind of time constraints are you under? The Mac team and UX are having some overarching UI discussions right now about the future of desktop UI, which will directly impact this Mac dialog. There's a good chance you'll be able to modify your new picker design to work on the Mac instead of ship this written-for-Mac version (which will save you a lot of work).
,
Jun 13 2016
Re #8: It is better that we can catch M53 branch point. Did you mean that we are migrating Mac Cocoa UI to the UI wrapped by chromium's views and controls? What is the migrating progress now? For picker window: Non-mac UI is already developed. For Mac UI to Chrome UI migration, I think it is just a couple lines of change (just pre-compile switch change).
,
Jun 13 2016
I'm didn't fully understand your first question. It looks like we are migrating the browser to use a variant of Material Design UI in its dialogs across all desktop platforms. In short, the non-Mac UI you have already developed is pretty close to what would be deployed everywhere, so I think it makes better sense to not even worry about a Mac-specific UI.
,
Jun 13 2016
Re#10: Yes, this answers my question. What is the migration progress now? Namely, when we can launch general picker window UI on Mac?
,
Jun 13 2016
That's probably a good discussion for your PM to have with rpop@ (Chrome Mac's PM).
,
Jun 14 2016
I think developement of Mac specific Desktop Capture Picker can be parallel with Mac UI migration. So can I develop the Desktop Capture Picker for Mac at this point? Because currently the Mac specific Desktop Capture Picker is the only blocker for us to release the new functionality of tab sharing. (current UI for tab source is ugly, and we think should not release to end user) In the future, when Mac UI migration is done, to launch generic Desktop Capture Picker on Mac is just a couple lines of change.
,
Jun 14 2016
rpop@: do you have an idea of the timeline of Mac UI migration project? Do you think it worth to do Mac specific UI developement for Desktop Capture Picker Window at this point? P.S. I think after migration, it is easy to switch to General UI for picker window. But we are trying to catch M53 to release the new functionality, and the picker window's new UI dev would block it.
,
Jun 14 2016
It's probably OK to proceed with the Mac version of the desktop capture picker.
,
Jun 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8a7f3f0519e401ddadc437dfce377be5d43ed46 commit f8a7f3f0519e401ddadc437dfce377be5d43ed46 Author: qiangchen <qiangchen@chromium.org> Date: Thu Jun 30 18:08:55 2016 Desktop Capture Picker Window New UI For Mac This CL develops the new Mac UI for Desktop Capture Picker window. The main changes are 1. Separate the items of different source types into different browser view. 2. Use table view rather than image view for tab capture, because we do not have HD preview for tab. BUG= 602478 , 618796 Review-Url: https://codereview.chromium.org/2072003002 Cr-Commit-Position: refs/heads/master@{#403223} [modify] https://crrev.com/f8a7f3f0519e401ddadc437dfce377be5d43ed46/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_bridge.h [modify] https://crrev.com/f8a7f3f0519e401ddadc437dfce377be5d43ed46/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_bridge.mm [modify] https://crrev.com/f8a7f3f0519e401ddadc437dfce377be5d43ed46/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_cocoa.h [modify] https://crrev.com/f8a7f3f0519e401ddadc437dfce377be5d43ed46/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_cocoa.mm [modify] https://crrev.com/f8a7f3f0519e401ddadc437dfce377be5d43ed46/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.h [modify] https://crrev.com/f8a7f3f0519e401ddadc437dfce377be5d43ed46/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm [add] https://crrev.com/f8a7f3f0519e401ddadc437dfce377be5d43ed46/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller_deprecated.h [add] https://crrev.com/f8a7f3f0519e401ddadc437dfce377be5d43ed46/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller_deprecated.mm [add] https://crrev.com/f8a7f3f0519e401ddadc437dfce377be5d43ed46/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller_deprecated_unittest.mm [modify] https://crrev.com/f8a7f3f0519e401ddadc437dfce377be5d43ed46/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller_unittest.mm [modify] https://crrev.com/f8a7f3f0519e401ddadc437dfce377be5d43ed46/chrome/chrome_browser_ui.gypi [modify] https://crrev.com/f8a7f3f0519e401ddadc437dfce377be5d43ed46/chrome/chrome_tests_unit.gypi
,
Jun 30 2016
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by qiangchen@chromium.org
, Jun 9 2016