Marking with Needs-Bisect label to identify if its whether a regression issue or not.

Able to reproduce the issue and is a non regression as seeing the same on any dark theme installed from M35 Builds. Attached a screenshot for the same. 

Issue is not observed on Windows and Linux OS. As there is a White color spinner displayed which is clear and visible even on dark themes.

Removing bisect label.

Thanks.!

Issue still seen on mac 10.11 chrome canary version 53.0.2767.0

shrike@, Any update on this please

A friendly reminder that M52 Stable is launching soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch by July 12. All changes MUST be merged into the release branch by 5pm on July 15 to make into the desktop Stable final build cut. Thank you!

gentle ping..

I'm trying to figure out how best to tackle this. The spinner needs to be reimplemented for Material Design. I've done most of the work but it will take some non-trivial refactoring to get it the rest of the way (and there's more animation code to be written). As a stopgap I'm thinking about creating a version of the existing spinner animation that will be visible in incognito. I need to get this going this week.

** Bulk Edit **

M52 Stable is launching very soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged ASAP. All changes MUST be merged into the release branch by 5pm on July 15 to make into the desktop Stable final build cut. Thank you!

** IMPORTANT change in M52 merge date due to first 2 weeks of July no release weeks **
M52 Stable is launching very soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged ASAP. All changes MUST be merged into the release branch by 5pm on July 1 to make into the desktop Stable final build cut. Thank you!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58a27fbd45da0a20f536e0607b59c8f1658db0be

commit 58a27fbd45da0a20f536e0607b59c8f1658db0be
Author: shrike <shrike@chromium.org>
Date: Mon Jun 27 22:34:11 2016

[Mac][Material Design] Add temporary spinner for Incognito mode.

The tab spinner on the Mac will be replaced by a Material Design version
in a future cl. Until then, we need a white version of the current
spinner so that it's visible on Incognito tabs.

R=cpu@chromium.org
BUG= 618778 

Review-Url: https://codereview.chromium.org/2092193004
Cr-Commit-Position: refs/heads/master@{#402316}

[add] https://crrev.com/58a27fbd45da0a20f536e0607b59c8f1658db0be/chrome/app/theme/default_100_percent/mac/throbber_incognito.png
[add] https://crrev.com/58a27fbd45da0a20f536e0607b59c8f1658db0be/chrome/app/theme/default_100_percent/mac/throbber_waiting_incognito.png
[add] https://crrev.com/58a27fbd45da0a20f536e0607b59c8f1658db0be/chrome/app/theme/default_200_percent/mac/throbber_incognito.png
[add] https://crrev.com/58a27fbd45da0a20f536e0607b59c8f1658db0be/chrome/app/theme/default_200_percent/mac/throbber_waiting_incognito.png
[modify] https://crrev.com/58a27fbd45da0a20f536e0607b59c8f1658db0be/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/58a27fbd45da0a20f536e0607b59c8f1658db0be/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

Rechecked this on Chrome version 53.0.2782.0 on MAC 10.11.5. "waiting for connection" spinner is now visible on incognito window. Attached screenshots for the same.

But verified the same on some dark themes on chrome and the visibility is still not clear for preloading spinner (Third Screenshot).

@shrike: Kindly have a review of it and please let us know if the above change was intended till incognito. Based on which we will add TE-Verified labels.

Thanks.!

Deleted: Waiting for URL to load.png 30.9 KB

	Waiting for URL to load.png 30.9 KB View Download

Deleted: Loading URL.png 76.6 KB

	Loading URL.png 76.6 KB View Download

Deleted: Dark Theme_Spinner.png 33.7 KB

	Dark Theme_Spinner.png 33.7 KB View Download

Re: #13, that's a bummer. I think the code just checks to see if you're in Incognito mode, not if you're using a dark theme. I have filed a follow-up bug on that,  Issue 624106 .

Your change meets the bar and is auto-approved for M52 (branch: 2743)

@jayson, should we wait till the follow up bug  issue 624106  to be fixed to get this bug CL merged in to M52 branch ?

My preference is to merge this cl to M52. Between getting the cl for  issue 624106  landed and seeing that it works in Canary, we're going to be super close to the deadline for cherry picks to M52. I will see if I can a get cl going today, but getting the cl for this issue cherry-picked will at least be better than not.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8cf4cd0f7039f6c5e991e13d925ad9683664a1d

commit b8cf4cd0f7039f6c5e991e13d925ad9683664a1d
Author: Jayson Adams <shrike@chromium.org>
Date: Tue Jun 28 23:10:22 2016

[Mac][Material Design] Add temporary spinner for Incognito mode.

The tab spinner on the Mac will be replaced by a Material Design version
in a future cl. Until then, we need a white version of the current
spinner so that it's visible on Incognito tabs.

R=cpu@chromium.org
BUG= 618778 

Review-Url: https://codereview.chromium.org/2092193004
Cr-Commit-Position: refs/heads/master@{#402316}
(cherry picked from commit 58a27fbd45da0a20f536e0607b59c8f1658db0be)

Review URL: https://codereview.chromium.org/2110713002 .

Cr-Commit-Position: refs/branch-heads/2743@{#512}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[add] https://crrev.com/b8cf4cd0f7039f6c5e991e13d925ad9683664a1d/chrome/app/theme/default_100_percent/mac/throbber_incognito.png
[add] https://crrev.com/b8cf4cd0f7039f6c5e991e13d925ad9683664a1d/chrome/app/theme/default_100_percent/mac/throbber_waiting_incognito.png
[add] https://crrev.com/b8cf4cd0f7039f6c5e991e13d925ad9683664a1d/chrome/app/theme/default_200_percent/mac/throbber_incognito.png
[add] https://crrev.com/b8cf4cd0f7039f6c5e991e13d925ad9683664a1d/chrome/app/theme/default_200_percent/mac/throbber_waiting_incognito.png
[modify] https://crrev.com/b8cf4cd0f7039f6c5e991e13d925ad9683664a1d/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/b8cf4cd0f7039f6c5e991e13d925ad9683664a1d/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

Rechecked this on Chrome version 52.0.2743.60 on MAC 10.11.5. "waiting for connection" spinner is visible on incognito window. Merge is working fine.

Adding TE-Verified labels.