New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 618771 link

Starred by 107 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Mac - Can't Paste URL into Outlook

Reported by ja...@lamb-family.net, Jun 9 2016

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.79 Safari/537.36

Steps to reproduce the problem:
1. Open Chrome, highlight URL (or command-A) and then copy (or command-C) from address bar
2. Switch to Outlook (I'm using 2011 but I've seen reports on other versions)
3. Start a new email (HTML format) and move to body of email
4. Edit > Paste (or command-V) - notice nothing* occurs
5. Edit > Paste and Match Style (or FN-SHIFT-OPT-COMMAND-V) - notice URL appears in email
6. Move to Subject
7. Paste (command-V) - notice URL appears in Subject Line
8. Draft > uncheck HTML format and click Yes - observe that URL is in body (*from step 4 where it looked like nothing happened)

What is the expected behavior?
Expect in step 4 for URL to appear in body.  
In step 1, replace "Chrome" with "Safari" or "Firefox" or "older version of Chrome" to see the expected behavior

What went wrong?
There is some weird encoding in the URL in the address bar of the current version of Mac Chrome that prevents the typical expected ability to simply paste a URL into Chrome.  (I've not seen first hand but it sounds like it also impacts Lotus Notes.)

Did this work before? Yes maybe a few days ago?

Chrome version: 51.0.2704.79  Channel: stable
OS Version: OS X 10.10.5
Flash Version: Shockwave Flash 21.0 r0

Chatter on Google Product Groups is picking up suggesting it's just now hit Stable.
 
Cc: manoranj...@chromium.org
Components: Blink>Editing
Labels: Hotlist-ConOps
Manoranjan, Can you help us test ?

Forum : https://productforums.google.com/forum/#!msg/chrome/Sqv4fPmgztU/wpWF0HXXDQAJ
Cc: pbomm...@chromium.org gov...@chromium.org anan...@chromium.org sshruthi@chromium.org
Labels: -Pri-2 M-51 ReleaseBlock-Stable Pri-1
Status: Untriaged (was: Unconfirmed)
James@, thank you for the report. I am able to reproduce this issue on Chrome Stable#51.0.2704.79/84 as well as on Latest Canary#53.0.2764.0 for Mac OS X 10.11.5.

This seems to be a recent regression and working fine on previous stable#50.0.2661.102. Working on finding a narrow bisect.

PS: I am using Outlook 2011 for the repro.

Thank you!
Owner: yoichio@chromium.org
Status: Assigned (was: Untriaged)
Here is the narrow bisect: https://chromium.googlesource.com/chromium/src/+log/40e5476f77c26efab0a63f05e8498ec8968565de..29f6dfa448d004e6f41c43e2c1a7cd6c4bcf1dfa

yoichio@, could you please look into this change: (https://chromium.googlesource.com/chromium/src/+/29f6dfa448d004e6f41c43e2c1a7cd6c4bcf1dfa) ?

Thank you!

Comment 5 by gov...@chromium.org, Jun 13 2016

We're planning to M51 Desktop Stable refresh release this week. yoichio@, could you PTAL as this bug as been reported as  M51 stable blocker?

Comment 6 by gov...@chromium.org, Jun 13 2016

Cc: tkent@chromium.org xiy...@chromium.org lazyboy@chromium.org
Ccing CL (https://chromium.googlesource.com/chromium/src/+/29f6dfa448d004e6f41c43e2c1a7cd6c4bcf1dfa) reviewers as yoichio@ is in Japan.

Comment 7 by tkent@chromium.org, Jun 13 2016

Components: UI>Browser>Omnibox
> Here is the narrow bisect: https://chromium.googlesource.com/chromium/src/+log/40e5476f77c26efab0a63f05e8498ec8968565de..29f6dfa448d004e6f41c43e2c1a7cd6c4bcf1dfa

Is the range correct?  This issue must be unrelated to Blink, and both of the changes were in Blink.

Owner: manoranj...@chromium.org
Hmm., let me redo the bisect. Seems like there are few chromium instances where "Cmd+c" itself not working and somehow i missed that before.


Comment 9 by jsil...@gmail.com, Jun 15 2016

I'm experiencing this issue as well. I cannot paste a URL directly from the URL bar on Chrome on Mac to the email body of a message in Outlook. Instead, I need to paste it to the subject line, a new tab, or a text file, then copy the text again. At that point, I can paste it into the Outlook email body.

Comment 10 by llhok...@gmail.com, Jun 15 2016

I am experiencing this issue as well. Glad to know the bug is being addressed. 

Chrome Version 51.0.2704.84 (64-bit)
Outlook Version 14.6.4 
OS X Yosemite Version 10.10.5

Owner: sdefresne@chromium.org
Please find the rebisect below  :

This is broken between Chrome builds 51.0.2696.0 and 51.0.2697.0(Find the change log for the same below)

https://chromium.googlesource.com/chromium/src/+log/51.0.2696.0..51.0.2697.0?pretty=fuller&n=10000


Suspected CL : https://chromium.googlesource.com/chromium/src/+/26a06f645bbdc6b23e4a4a72b5afef2cf2f7a0d4


 Issue 620263  has been merged into this issue.
Cc: shrike@chromium.org
erikchen@ - I was looking at ClipboardUtil::AddDataToPasteboard():

void ClipboardUtil::AddDataToPasteboard(NSPasteboard* pboard,
                                        NSPasteboardItem* item) {
  NSSet* oldTypes = [NSSet setWithArray:[pboard types]];
  NSMutableSet* newTypes = [NSMutableSet setWithArray:[item types]];
  [newTypes minusSet:oldTypes];

  [pboard addTypes:[newTypes allObjects] owner:nil];
  for (NSString* type in newTypes) {

This function adds only the types in |item| that the pasteboard does not already contain. However I would think you would want to add all the representations of |item| to the pasteboard? Theoretically, if the pasteboard already contains plain text at the moment the user copies from Chrome, AddDataToPasteboard() will see that plain text and skip copying plain text from Chrome.

Comment 15 by tkent@chromium.org, Jun 15 2016

Cc: -tkent@chromium.org
Components: -Blink>Editing
Cc: rpop@chromium.org
There is two of us at our office having the same issue as well. It started a few days ago for us. We cannot paste a URL directly from the URL bar on Chrome on Mac to the email body of a message in Outlook. Instead, I need to paste it to the subject line, a new tab, or a text file, then copy the text again. It's so frustrating when this is part of our daily work load, keeping track of websites.
Chrome Version 51.0.2704.84 (64-bit)
Outlook Version 15.19.1 (160212) 
OS X Yosemite Version 10.10.5
You can simply use the Chrome tool bar to open a new email with the url embedded in the text:  File/Email page location
I, too, am experiencing this issue on my Mac with Chrome/Outlook.
I see that this is not just Outlook, I saw similar behavior on "Notes".
Cc: -shrike@chromium.org
Owner: shrike@chromium.org
Thank you for the pointer on reproducing this in the notes app. I believe I have found the cause of the regression and am putting together a cl for it.

Status: Started (was: Assigned)
This happens on my Mac as well but with my apple mail account. Hoping your fix will work for this as well. Model Name:	iMac
  Model Identifier:	iMac10,1
  Processor Name:	Intel Core 2 Duo
  Processor Speed:	3.06 GHz
  Number of Processors:	1
  Total Number of Cores:	2
  L2 Cache:	3 MB
  Memory:	12 GB
  Bus Speed:	1.07 GHz
  Boot ROM Version:	IM101.00CC.B00
  SMC Version (system):	1.52f9
  Serial Number (system):	QP0120TZB9S
  Hardware UUID:	EA71055D-4718-54E4-B9E7-855A993C6C1F


Same Problem for me on 2 macs.   This same behavior is true in Apples Mail.app also.
shrike@, could you please provide an update on this? Is there any progress on fix?
I have a fix which I tried to land but tests failed. I'm going to work on getting the tests to pass and hopefully land it in time for tonight's Canary.
Thank you shrike@ for the update. 
For the record, I can reproduce this problem in 51.0.2704.103 but not in 51.0.2704.84.
I could also not paste into Notes, as an intermediary location. So from the URL bar in to the email subject field in Outlook and then into the body does work as a workaround. 
Cc: shrike@chromium.org
Owner: erikc...@chromium.org
erikchen@ - I'm assigning this bug to you. Once your cl lands and gets a little airtime on Canary we need to cherry-pick back to M52 and M51.

Correction to #29 - it seems that copy/paste works fine from Chrome to Notes on my desktop machine but not on my laptop. Both are running 10.11.5 (15F34).
Project Member

Comment 33 by bugdroid1@chromium.org, Jun 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23d52abd52313ed4431d33935d6a4d72394a350c

commit 23d52abd52313ed4431d33935d6a4d72394a350c
Author: erikchen <erikchen@chromium.org>
Date: Tue Jun 21 22:51:27 2016

[Mac] Fix regression with copying URLs from the Omnibox.

The function ClipboardUtil::PasteboardItemFromUrl was incorrectly attempting to
create a public UTI using UTIFromPboardType. The resulting NSPasteboardItem was
not correctly writing to the NSPasteboard. Using the public UTIs directly fixes
this problem.

BUG= 618771 

Review-Url: https://codereview.chromium.org/2080603007
Cr-Commit-Position: refs/heads/master@{#401134}

[modify] https://crrev.com/23d52abd52313ed4431d33935d6a4d72394a350c/ui/base/clipboard/clipboard_util_mac.mm
[modify] https://crrev.com/23d52abd52313ed4431d33935d6a4d72394a350c/ui/base/clipboard/clipboard_util_mac_unittest.mm

Labels: Merge-Request-52
Status: Fixed (was: Started)
According to the changelog for 53.0.2774.3 Canary

https://chromium.googlesource.com/chromium/src/+log/53.0.2774.2..53.0.2774.3?pretty=fuller&n=10000

the fix is not in today's Canary, and I confirm that after updating to Canary I still see the problem. Let's hold off on merging until we confirm it works and maybe get some confirmation from users out there.

Also, if an issue has been fixed but needs to be cherry-picked back to a milestone, should it really be marked as fixed? Seems like it's then easy to forget that there's additional work required.

Comment 36 by dimu@google.com, Jun 22 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Having the same issue - can't paste URL into Outlook email. I'm not a computer expert like many here seem to be. How do I correct this?

Comment 38 Deleted

Comment 39 Deleted

Dowloaded the Canary Release 53.0.2777.0 64-bit for Mac and verified that this is now working for me as well.  
Labels: -TE-Verified-M53 -TE-Verified-53.0.2776.0
Confirmed - seems to be fixed in 53.0.2776.0.
Project Member

Comment 43 by bugdroid1@chromium.org, Jun 23 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d84e10c2bbaa428299a7d654c9bf023ff1ca3a4

commit 2d84e10c2bbaa428299a7d654c9bf023ff1ca3a4
Author: erikchen <erikchen@chromium.org>
Date: Thu Jun 23 16:14:11 2016

[Merge to 2743] [Mac] Fix regression with copying URLs from the Omnibox.

> The function ClipboardUtil::PasteboardItemFromUrl was incorrectly attempting to
> create a public UTI using UTIFromPboardType. The resulting NSPasteboardItem was
> not correctly writing to the NSPasteboard. Using the public UTIs directly fixes
> this problem.
>
> BUG= 618771 
>
> Review-Url: https://codereview.chromium.org/2080603007
> Cr-Commit-Position: refs/heads/master@{#401134}

(cherry picked from commit 23d52abd52313ed4431d33935d6a4d72394a350c)

Review URL: https://codereview.chromium.org/2094553003 .

Cr-Commit-Position: refs/branch-heads/2743@{#455}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/2d84e10c2bbaa428299a7d654c9bf023ff1ca3a4/ui/base/clipboard/clipboard_util_mac.mm
[modify] https://crrev.com/2d84e10c2bbaa428299a7d654c9bf023ff1ca3a4/ui/base/clipboard/clipboard_util_mac_unittest.mm

Labels: -M-51
Labels: Merge-Request-51
I don't think we should merge to M-51, since it's already pushed to stable, and this isn't a P-0.
sshruthi@ has said that we should merge this back to M51 because of all the ConOps activity it's generating. sshruthi@ - please remove Merge-Request-51 if we should not merge back to M51, otherwise we should get TEs to do some testing as we discussed.
Labels: TE-Verified-53.0.2777.0 TE-Verified-M53
Confirmation from TE team: Fix (as per c#33) is working as intended on Latest Canary#53.0.2777.0 for Mac OS X 10.11.5 MacBook Air (Outlook 2011).

Thank you!
What this mean for the timing of the fix getting into a future update?
It's probably a little too late to get this into M51. How safe is the fix, in any case?
I found this issue while searching for this issue in relation to the "Notes" app, that comes with the Mac OS. It seems like pasting and URL, from Chrome, works fine for me when I use Outlook...However, I've been unable to do this at all today, in the Notes app, after upgrading to the latest version of Chrome v51.0.2704.103. Everything worked great yesterday.

Comment 52 by dimu@google.com, Jun 24 2016

Labels: -Merge-Request-51 Merge-Review-51 Hotlist-Merge-Review
[Automated comment] Request affecting a post-stable build (M51), manual review required.
Re: # 51, the fix should be relatively safe. erikchen@ can speak more directly about it.

I'm not pushing for a merge to M-51. We should do whatever makes sense.

When can we expect this to be implemented?  I have enterprise Mac users this is effecting.
Labels: -Merge-Review-51
The problem with changes to copy/paste or drag and drop code is that the integration with external apps has poor test coverage. While my CL looks safe to me, it could have broken other integration. I don't think we should merge to M-51.

binarydaddy: When M52 is released, the problem should be fixed. Alternatively, the next Beta bush to M52 should also fix the problem.
I am using Google Chrome Version 51.0.2704.103 (64-bit).  I use Outlook for MAC 2011.  I can cut and past into the "Subject" and into a word doc and then into the body of the message, but not directly into the body of the e-mail message.  Weird.  Any ideas. Happens with all URLs, and any method of cut and past.
Safari works fine so the problem seems to be integrating Outlook 11 with google chrome on a Mac.

Comment 58 by dpit...@gmail.com, Jun 27 2016

I have the same issue, Chrome Version 51.0.2704.103 (64-bit) and Outlook 2011 Version 14.6.5 (160527) I have to copy even URLs and text into a text editor, and then copy into Outlook email body.

Labels: Restrict-AddIssueComment-EditIssue
Hi everyone,

This issue will be fixed in Chrome version 52, which will probably be released to the stable channel in late July.  If you're anxious to get a fixed version sooner, you can switch to the Beta channel, which should have the fix when the new beta version is released later this week.

Labels: TE-Verified-M52 TE-Verified-52.0.2743.60
Tested the fix on Latest Beta#52.0.2743.60 for Mac OS X 10.11.5 (Using Outlook 2011) and it is working as intended.

Thank you!

Sign in to add a comment