New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 618763 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Omnibox dropdown icons are gray instead of white in Incognito

Project Member Reported by shrike@chromium.org, Jun 9 2016

Issue description

Version: M52 Beta, M53 Canary

See the attached screenshot.

spqchan@ - would you please take a look at this. I'm not sure when things went south, but we need to fix it and cherry-pick that fix back to M52 once we confirm it on Canary. Thank you.

 
Screen Shot 2016-06-07 at 9.37.12 AM.png
49.7 KB View Download
I just had a look and it looks like this is caused by this CL:
https://chromium.googlesource.com/chromium/src/+/7d8ce7003186698ce565f6eb59bf7027a2707f22

This line in particular is causing the issue:
https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.mm?rcl=0&l=50

Basically we're explicitly ignoring the fact that it's in dark mode.
I guess this is now an outdated design?
Project Member

Comment 2 by sheriffbot@chromium.org, Jun 10 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by shrike@chromium.org, Jun 11 2016

Labels: -M-53 -MovedFrom-52 M-52
Ah, so the fix should be as simple as telling it not to ignore dark theme?

You talked about an outdated design - what are you referring to?

Yeah, that should be it. I was actually asking if ignoring the dark mode was part of an older Material design spec. I want to make sure if it's okay for us to get rid of

Comment 5 by shrike@chromium.org, Jun 19 2016

It sounds like you're saying there might be code that's no longer needed. If so, that can definitely be removed.

Awesome thanks! I'll go ahead and remove it
Labels: Merge-Request-52

Comment 9 by dimu@google.com, Jun 30 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 30 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/caeb412303073d89f6a6384798eed1ad2b691494

commit caeb412303073d89f6a6384798eed1ad2b691494
Author: spqchan <spqchan@chromium.org>
Date: Thu Jun 30 01:01:05 2016

[Material][Mac] Set Incognito Omnibox Dropdown Icons to White

BUG= 618763 

Review-Url: https://codereview.chromium.org/2082723002
Cr-Commit-Position: refs/heads/master@{#402634}
(cherry picked from commit a8403516d197bb546c068d3202f41844a004892e)

Review URL: https://codereview.chromium.org/2105413003 .

Cr-Commit-Position: refs/branch-heads/2743@{#539}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/caeb412303073d89f6a6384798eed1ad2b691494/chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.mm
[modify] https://crrev.com/caeb412303073d89f6a6384798eed1ad2b691494/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h
[modify] https://crrev.com/caeb412303073d89f6a6384798eed1ad2b691494/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm

Status: Fixed (was: Assigned)
Cc: ashej...@chromium.org
Labels: TE-Verified-52.0..2743.75 TE-Verified-M52
Tested the above issue on Mac 10.11.5 with chrome version '52.0..2743.75' & omnibox  drop down icons are white in incognito. Hence marking the same as TE-Verified-52.0..2743.75.

Thank you!

Sign in to add a comment