media_unittest BasicPlaybackOpusOggTrimmingHashed uses .webm file |
|
Issue descriptionhttps://cs.chromium.org/chromium/src/media/test/pipeline_integration_test.cc?q=BasicPlaybackOpu&sq=package:chromium&l=932 Introduced here: https://codereview.chromium.org/1260193005 Should use 'opus-trimming-test.ogg', but when I tried changing this locally the test fails with: ../../media/test/pipeline_integration_test.cc:950: Failure Value of: GetAudioHash() Actual: "-12.44,-13.97,-13.23,-11.62,-10.57,-10.92," Expected: kOpusEndTrimmingHash_3 Which is: "-13.28,-14.35,-13.67,-11.68,-10.18,-10.46," [ FAILED ] PipelineIntegrationTest.BasicPlaybackOpusOggTrimmingHashed (391 ms)
,
Jun 10 2016
Little confused... both the ogg and webm file contain opus. Why should we be using the ogg file? Its possible that the ogg and webm file have slightly different encoded opus data, leading to different hash.
,
Jun 10 2016
It's highly possible we shouldn't be.
,
Jun 10 2016
Ah, perhaps we shouldn't be. I was basing it off of the names and the presence of the opus-trimming-test.ogg file that is not getting used anywhere (that I could find). BasicPlaybackOpusOggTrimmingHashed BasicPlaybackOpusWebmTrimmingHashed Currently these two functions are completely identical (as far as I can see), so I think either one can be deleted or one should use the other file
,
Jun 10 2016
No, you're right - my mistake. I think the bug is legit actually. I just converted the ogg and webm file to wav files and found no differences... so I suspect they are encoded the same and we are trimming slightly differently.
,
Sep 20
Possibly related: Issue 456252 |
|
►
Sign in to add a comment |
|
Comment 1 by dalecur...@chromium.org
, Jun 9 2016Owner: chcunningham@chromium.org
Status: Assigned (was: Untriaged)