New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 618754 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 587995



Sign in to add a comment

Rename CurrencyAmount and ShippingOption so that all begin Payment*

Project Member Reported by jinho.b...@samsung.com, Jun 9 2016

Issue description

BK started to work on this issue.

(I updated this issue status instead of him because he doesn't have bug-editing privileges yet.)
Status: Started (was: Assigned)
Components: Blink>Payments
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef35132022c6123992c4e5666213b5e481b39d33

commit ef35132022c6123992c4e5666213b5e481b39d33
Author: gogag2 <gogag2@gmail.com>
Date: Fri Jun 17 19:36:59 2016

Rename remaining types so that all begin Payment*

Modified CurrencyAmount to PaymentCurrencyAmount and ShippingOption to PaymentShippingOption.

BUG= 618754 

RelatedLink=https://github.com/w3c/browser-payment-api/commit/26b092664b26cf06293a3eab462ef8c4005c82f5

Review-Url: https://codereview.chromium.org/2056803002
Cr-Commit-Position: refs/heads/master@{#400475}

[modify] https://crrev.com/ef35132022c6123992c4e5666213b5e481b39d33/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/ef35132022c6123992c4e5666213b5e481b39d33/third_party/WebKit/Source/modules/modules.gypi
[rename] https://crrev.com/ef35132022c6123992c4e5666213b5e481b39d33/third_party/WebKit/Source/modules/payments/PaymentCurrencyAmount.idl
[modify] https://crrev.com/ef35132022c6123992c4e5666213b5e481b39d33/third_party/WebKit/Source/modules/payments/PaymentDetails.idl
[modify] https://crrev.com/ef35132022c6123992c4e5666213b5e481b39d33/third_party/WebKit/Source/modules/payments/PaymentItem.idl
[modify] https://crrev.com/ef35132022c6123992c4e5666213b5e481b39d33/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
[modify] https://crrev.com/ef35132022c6123992c4e5666213b5e481b39d33/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp
[modify] https://crrev.com/ef35132022c6123992c4e5666213b5e481b39d33/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp
[modify] https://crrev.com/ef35132022c6123992c4e5666213b5e481b39d33/third_party/WebKit/Source/modules/payments/PaymentResponse.h
[modify] https://crrev.com/ef35132022c6123992c4e5666213b5e481b39d33/third_party/WebKit/Source/modules/payments/PaymentResponse.idl
[modify] https://crrev.com/ef35132022c6123992c4e5666213b5e481b39d33/third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp
[rename] https://crrev.com/ef35132022c6123992c4e5666213b5e481b39d33/third_party/WebKit/Source/modules/payments/PaymentShippingOption.idl
[modify] https://crrev.com/ef35132022c6123992c4e5666213b5e481b39d33/third_party/WebKit/Source/modules/payments/PaymentTestHelper.cpp
[modify] https://crrev.com/ef35132022c6123992c4e5666213b5e481b39d33/third_party/WebKit/Source/modules/payments/PaymentTestHelper.h
[modify] https://crrev.com/ef35132022c6123992c4e5666213b5e481b39d33/third_party/WebKit/public/platform/modules/payments/payment_request.mojom

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 17 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/7583f7e87cfb13f2635b5906a1180748a40af6b7

commit 7583f7e87cfb13f2635b5906a1180748a40af6b7
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Fri Jun 17 22:12:34 2016

Sign in to add a comment