New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 618753 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Spitzer fullscreen not working on gfycat

Project Member Reported by w...@chromium.org, Jun 9 2016

Issue description

When you go fullscreen the video disappears. The "border-radius" style is causing the overlay to not be scheduled for some reason, and removing it fixes the issue.

e.g., https://gfycat.com/InconsequentialTenderDeviltasmanian
 
I examined the compositor code to make a list of all the affected properties. Some cause the quad to move to a non-root render pass, which prevents underlays:
  - opacity
  - -webkit-filter
  - border-radius
  - mix-blend-mode

A few more turn out to render on top of the video:
  - border
  - background-image

The eventual fix for these is probably a combination of changes to the video stack and compositor, but the most important will be to never switch away from SurfaceTexture if the video layer is not in the root render pass.

In the short term we need a fix for M52.
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f33109c4d3bdafe0a0c07c59bd1bf1639595dc8a

commit f33109c4d3bdafe0a0c07c59bd1bf1639595dc8a
Author: sandersd <sandersd@chromium.org>
Date: Fri Jun 24 19:17:14 2016

Exclude more CSS properties for fullscreen video on Android.

This CL overrides additional CSS properties that prevent accelerated overlays from being used:
  - -webkit-filter
  - opacity
  - border-radius
  - mix-blend-mode

And two that are rendered incorrectly:
  - background-image
  - border

This is especially important because there is no non-overlay fallback.

This mechanism is expected to be replaced by compositor changes in M53.

BUG= 618753 

Review-Url: https://codereview.chromium.org/2055023002
Cr-Commit-Position: refs/heads/master@{#401923}

[modify] https://crrev.com/f33109c4d3bdafe0a0c07c59bd1bf1639595dc8a/content/child/blink_platform_impl.cc
[modify] https://crrev.com/f33109c4d3bdafe0a0c07c59bd1bf1639595dc8a/third_party/WebKit/Source/core/css/CSSDefaultStyleSheets.cpp
[add] https://crrev.com/f33109c4d3bdafe0a0c07c59bd1bf1639595dc8a/third_party/WebKit/Source/core/css/fullscreenAndroid.css
[modify] https://crrev.com/f33109c4d3bdafe0a0c07c59bd1bf1639595dc8a/third_party/WebKit/Source/core/layout/LayoutTheme.h
[modify] https://crrev.com/f33109c4d3bdafe0a0c07c59bd1bf1639595dc8a/third_party/WebKit/Source/core/layout/LayoutThemeMac.h
[modify] https://crrev.com/f33109c4d3bdafe0a0c07c59bd1bf1639595dc8a/third_party/WebKit/Source/core/layout/LayoutThemeMac.mm
[modify] https://crrev.com/f33109c4d3bdafe0a0c07c59bd1bf1639595dc8a/third_party/WebKit/Source/core/layout/LayoutThemeMobile.cpp
[modify] https://crrev.com/f33109c4d3bdafe0a0c07c59bd1bf1639595dc8a/third_party/WebKit/Source/core/layout/LayoutThemeMobile.h
[modify] https://crrev.com/f33109c4d3bdafe0a0c07c59bd1bf1639595dc8a/third_party/WebKit/public/blink_resources.grd

Labels: Merge-Request-52

Comment 4 by dimu@google.com, Jun 24 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 24 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d98b389f591edceddd9a439b67a408602c43737

commit 0d98b389f591edceddd9a439b67a408602c43737
Author: Dan Sanders <sandersd@chromium.org>
Date: Fri Jun 24 21:04:16 2016

Merge to M52: Exclude more CSS properties for fullscreen video on Android.

This CL overrides additional CSS properties that prevent accelerated overlays from being used:
  - -webkit-filter
  - opacity
  - border-radius
  - mix-blend-mode

And two that are rendered incorrectly:
  - background-image
  - border

This is especially important because there is no non-overlay fallback.

This mechanism is expected to be replaced by compositor changes in M53.

BUG= 618753 

Review-Url: https://codereview.chromium.org/2055023002
Cr-Commit-Position: refs/heads/master@{#401923}
(cherry picked from commit f33109c4d3bdafe0a0c07c59bd1bf1639595dc8a)

Review URL: https://codereview.chromium.org/2097983002 .

Cr-Commit-Position: refs/branch-heads/2743@{#471}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/0d98b389f591edceddd9a439b67a408602c43737/content/child/blink_platform_impl.cc
[modify] https://crrev.com/0d98b389f591edceddd9a439b67a408602c43737/third_party/WebKit/Source/core/css/CSSDefaultStyleSheets.cpp
[add] https://crrev.com/0d98b389f591edceddd9a439b67a408602c43737/third_party/WebKit/Source/core/css/fullscreenAndroid.css
[modify] https://crrev.com/0d98b389f591edceddd9a439b67a408602c43737/third_party/WebKit/Source/core/layout/LayoutTheme.h
[modify] https://crrev.com/0d98b389f591edceddd9a439b67a408602c43737/third_party/WebKit/Source/core/layout/LayoutThemeMac.h
[modify] https://crrev.com/0d98b389f591edceddd9a439b67a408602c43737/third_party/WebKit/Source/core/layout/LayoutThemeMac.mm
[modify] https://crrev.com/0d98b389f591edceddd9a439b67a408602c43737/third_party/WebKit/Source/core/layout/LayoutThemeMobile.cpp
[modify] https://crrev.com/0d98b389f591edceddd9a439b67a408602c43737/third_party/WebKit/Source/core/layout/LayoutThemeMobile.h
[modify] https://crrev.com/0d98b389f591edceddd9a439b67a408602c43737/third_party/WebKit/public/blink_resources.grd

Status: Fixed (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fbe2117175d7766761489fe60da97a4a34cdbf2

commit 0fbe2117175d7766761489fe60da97a4a34cdbf2
Author: sandersd <sandersd@chromium.org>
Date: Mon Jul 11 20:51:16 2016

Mobile: Restore painted content for fullscreen video.

It is no longer necessary to disable the background-image and border
properties for fullscreen video on Android because commit
014e89fdbe83fd895898331249f9bba28cc71130 does this in a non-exposed way.

(Actually rendering such content is still in progress.)

BUG= 618753 

Review-Url: https://codereview.chromium.org/2103953006
Cr-Commit-Position: refs/heads/master@{#404727}

[modify] https://crrev.com/0fbe2117175d7766761489fe60da97a4a34cdbf2/third_party/WebKit/Source/core/css/fullscreenAndroid.css

Sign in to add a comment