testOnShowAndHideCustom* tests flaky on cq |
||||||
Issue descriptionhttps://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/83229 https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/85061 https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/84760 https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/84248 https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/84105 https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/84021 Errors split half-half between waitForCustomViewShown and waitForCustomViewHidden C 447.489s Main [FAIL] org.chromium.android_webview.test.AwContentsClientFullScreenTest#testOnShowAndHideCustomViewWithJavascript_videoInsideDiv: C 447.489s Main java.util.concurrent.TimeoutException: waitForCallback timed out! C 447.489s Main at org.chromium.content.browser.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:184) C 447.489s Main at org.chromium.android_webview.test.FullScreenVideoTestAwContentsClient.waitForCustomViewShown(FullScreenVideoTestAwContentsClient.java:105) C 447.489s Main at org.chromium.android_webview.test.AwContentsClientFullScreenTest.doOnShowCustomViewTest(AwContentsClientFullScreenTest.java:540) C 447.489s Main at org.chromium.android_webview.test.AwContentsClientFullScreenTest.doOnShowAndHideCustomViewTest(AwContentsClientFullScreenTest.java:532) C 447.489s Main at org.chromium.android_webview.test.AwContentsClientFullScreenTest.doTestOnShowAndHideCustomViewWithJavascript(AwContentsClientFullScreenTest.java:127) C 447.489s Main at org.chromium.android_webview.test.AwContentsClientFullScreenTest.testOnShowAndHideCustomViewWithJavascript_videoInsideDiv(AwContentsClientFullScreenTest.java:123) C 447.490s Main at java.lang.reflect.Method.invokeNative(Native Method) C 447.490s Main at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214) C 447.490s Main at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199) C 447.490s Main at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192) C 447.490s Main at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161) C 447.490s Main at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124) C 447.490s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191) C 447.490s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176) C 447.490s Main at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554) C 447.490s Main at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701) C 504.289s Main [FAIL] org.chromium.android_webview.test.AwContentsClientFullScreenTest#testOnShowAndHideCustomViewWithBackKey_video: C 504.289s Main java.util.concurrent.TimeoutException: waitForCallback timed out! C 504.289s Main at org.chromium.content.browser.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:184) C 504.289s Main at org.chromium.android_webview.test.FullScreenVideoTestAwContentsClient.waitForCustomViewHidden(FullScreenVideoTestAwContentsClient.java:109) C 504.289s Main at org.chromium.android_webview.test.AwContentsClientFullScreenTest.doTestOnShowAndHideCustomViewWithBackKey(AwContentsClientFullScreenTest.java:170) C 504.289s Main at org.chromium.android_webview.test.AwContentsClientFullScreenTest.testOnShowAndHideCustomViewWithBackKey_video(AwContentsClientFullScreenTest.java:145) C 504.289s Main at java.lang.reflect.Method.invokeNative(Native Method) C 504.289s Main at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214) C 504.289s Main at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199) C 504.289s Main at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192) C 504.289s Main at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161) C 504.289s Main at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124) C 504.289s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191) C 504.289s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176) C 504.289s Main at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554) C 504.290s Main at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
,
Jun 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7179cb647adff03cdbbbd25d3a720515e16354b3 commit 7179cb647adff03cdbbbd25d3a720515e16354b3 Author: boliu <boliu@chromium.org> Date: Thu Jun 09 18:48:05 2016 aw: Diable testOnShowAndHideCustomView tests Flaky on cq. BUG=618749 TBR=sgurun@chromium.org Review-Url: https://codereview.chromium.org/2056793002 Cr-Commit-Position: refs/heads/master@{#398967} [modify] https://crrev.com/7179cb647adff03cdbbbd25d3a720515e16354b3/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java
,
Jun 13 2016
some of these are probably being removed soon, others need to be deflaked and re-enabled again
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7179cb647adff03cdbbbd25d3a720515e16354b3 commit 7179cb647adff03cdbbbd25d3a720515e16354b3 Author: boliu <boliu@chromium.org> Date: Thu Jun 09 18:48:05 2016 aw: Diable testOnShowAndHideCustomView tests Flaky on cq. BUG=618749 TBR=sgurun@chromium.org Review-Url: https://codereview.chromium.org/2056793002 Cr-Commit-Position: refs/heads/master@{#398967} [modify] https://crrev.com/7179cb647adff03cdbbbd25d3a720515e16354b3/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java
,
Jun 15 2016
Ok, pretty much all the video tests are flaky!! disabling https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/86397 https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/87293 C 449.000s Main [FAIL] org.chromium.android_webview.test.AwContentsClientFullScreenTest#testFullscreenVideoInSoftwareModeDoesNotDeadlock: C 449.000s Main java.util.concurrent.TimeoutException: waitForCallback timed out! C 449.000s Main at org.chromium.content.browser.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:184) C 449.000s Main at org.chromium.android_webview.test.FullScreenVideoTestAwContentsClient.waitForCustomViewShown(FullScreenVideoTestAwContentsClient.java:105) C 449.000s Main at org.chromium.android_webview.test.AwContentsClientFullScreenTest.testFullscreenVideoInSoftwareModeDoesNotDeadlock(AwContentsClientFullScreenTest.java:73) C 449.000s Main at java.lang.reflect.Method.invokeNative(Native Method) C 449.000s Main at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214) C 449.000s Main at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199) C 449.000s Main at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192) C 449.000s Main at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161) C 449.000s Main at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124) C 449.000s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191) C 449.000s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176) C 449.000s Main at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554) C 449.000s Main at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701) https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/86623 C 424.709s Main [FAIL] org.chromium.android_webview.test.AwContentsClientFullScreenTest#testOnShowCustomViewTransfersHolePunchingSurfaceForVideoInsideDiv: C 424.709s Main junit.framework.AssertionFailedError: Criteria not met in allotted time. C 424.709s Main at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:74) C 424.709s Main at org.chromium.content.browser.test.util.DOMUtils.waitForMediaPlay(DOMUtils.java:105) C 424.709s Main at org.chromium.android_webview.test.AwContentsClientFullScreenTest.testOnShowCustomViewTransfersHolePunchingSurfaceForVideoInsideDiv(AwContentsClientFullScreenTest.java:250) C 424.709s Main at java.lang.reflect.Method.invokeNative(Native Method) C 424.709s Main at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214) C 424.709s Main at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199) C 424.709s Main at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192) C 424.709s Main at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161) C 424.709s Main at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124) C 424.709s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191) C 424.710s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176) C 424.710s Main at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554) C 424.710s Main at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701) https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/87384 https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/87962 C 434.526s Main [FAIL] org.chromium.android_webview.test.AwContentsClientFullScreenTest#testHolePunchingSurfaceNotCreatedForClearVideo: C 434.526s Main junit.framework.AssertionFailedError: Criteria not met in allotted time. C 434.526s Main at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:74) C 434.527s Main at org.chromium.content.browser.test.util.DOMUtils.waitForMediaPlay(DOMUtils.java:105) C 434.527s Main at org.chromium.android_webview.test.AwContentsClientFullScreenTest.testHolePunchingSurfaceNotCreatedForClearVideo(AwContentsClientFullScreenTest.java:228) C 434.527s Main at java.lang.reflect.Method.invokeNative(Native Method) C 434.527s Main at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214) C 434.527s Main at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199) C 434.527s Main at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192) C 434.527s Main at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161) C 434.527s Main at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124) C 434.527s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191) C 434.527s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176) C 434.527s Main at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554) C 434.527s Main at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a0d5b99370c5872e19a619211e447095ba008a20 commit a0d5b99370c5872e19a619211e447095ba008a20 Author: boliu <boliu@chromium.org> Date: Wed Jun 15 18:40:22 2016 aw: Disable flaky video tests See crbug.com/618749 for details. BUG=618749, 604568 TBR=sgurun@chromium.org Review-Url: https://codereview.chromium.org/2064753007 Cr-Commit-Position: refs/heads/master@{#399972} [modify] https://crrev.com/a0d5b99370c5872e19a619211e447095ba008a20/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java
,
Jun 15 2016
,
Jun 16 2016
> Let's address this in fix-it week. Probably half of the video tests are going to be removed when we remove VIDEO_HOLE. Other half, sure.
,
Jun 21 2016
Tima, do you have time to look at deflaking the tests that are not going to be removed?
,
Jun 21 2016
Will start later today.
,
Jun 23 2016
More tests failed on Lollipop Low-end Tester: https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Low-end%20Tester/builds/3539 org.chromium.android_webview.test.AwContentsClientFullScreenTest#testOnShowCustomViewRemovesHolePunchingSurfaceForVideo Going to disable.
,
Jun 23 2016
only disable if it's failing on main waterfall, you can make the test be skipped on L or above though
,
Jun 23 2016
It might be failing becasue of Low-end, not necessary Lollipop. It is also going to be removed for Spitzer.
,
Sep 4 2017
The assigned owner "timav@chromium.org" is not able to receive e-mails, please re-triage. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 6 2017
,
Aug 21
Just came across this issue. I think some of these tests were removed (as per comment #8) in 78b35e8a8b01f2db768a30033dee03323f71f316. Out of the 8 remaining disabled tests, how many can we remove vs. need to deflake?
,
Aug 21
Glancing over the disabled ones, probably all of them should be deflaked.
,
Aug 23
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by boliu@chromium.org
, Jun 9 2016