New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 618741 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

[Sync] OpenTabsTest can flake with having 1 node instead of the expected 2

Project Member Reported by maxbogue@chromium.org, Jun 9 2016

Issue description

I'm not sure what's causing this, but since the code only needs the header, I'm going to try a fix that waits for > 0 nodes and then tries to pull the information out of the header.

C  163.762s Main  [FAIL] org.chromium.chrome.browser.sync.OpenTabsTest#testUploadOpenTab:
C  163.762s Main  junit.framework.AssertionFailedError: Values did not match. Expected: 2, actual: 1
C  163.762s Main  	at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:74)
C  163.762s Main  	at org.chromium.chrome.browser.sync.SyncTestBase.pollInstrumentationThread(SyncTestBase.java:231)
C  163.762s Main  	at org.chromium.chrome.browser.sync.OpenTabsTest.getClientName(OpenTabsTest.java:267)
C  163.762s Main  	at org.chromium.chrome.browser.sync.OpenTabsTest.setUp(OpenTabsTest.java:79)
C  163.763s Main  	at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
C  163.763s Main  	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
C  163.763s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
C  163.763s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
C  163.763s Main  	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
C  163.763s Main  	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32a5e3038a2b592133ef7dc19a10cc53e093b66f

commit 32a5e3038a2b592133ef7dc19a10cc53e093b66f
Author: maxbogue <maxbogue@chromium.org>
Date: Thu Jun 09 22:05:24 2016

[Sync] Attempt to fix a flake in OpenTabsTest.

BUG= 618741 

Review-Url: https://codereview.chromium.org/2056753002
Cr-Commit-Position: refs/heads/master@{#399031}

[modify] https://crrev.com/32a5e3038a2b592133ef7dc19a10cc53e093b66f/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/OpenTabsTest.java

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32a5e3038a2b592133ef7dc19a10cc53e093b66f

commit 32a5e3038a2b592133ef7dc19a10cc53e093b66f
Author: maxbogue <maxbogue@chromium.org>
Date: Thu Jun 09 22:05:24 2016

[Sync] Attempt to fix a flake in OpenTabsTest.

BUG= 618741 

Review-Url: https://codereview.chromium.org/2056753002
Cr-Commit-Position: refs/heads/master@{#399031}

[modify] https://crrev.com/32a5e3038a2b592133ef7dc19a10cc53e093b66f/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/OpenTabsTest.java

Sign in to add a comment