New issue
Advanced search Search tips

Issue 618738 link

Starred by 2 users
Status: WontFix
Owner:
mustaq@chromium.org
Closed: May 2018
Cc:
rbyers@chromium.org
sadrul@chromium.org
dtapu...@chromium.org
tdres...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Clarify WebGestureEvent.uniqueTouchEventId for indirect gesture events

Project Member Reported by mustaq@chromium.org, Jun 9 2016 
If the WebGestureEvent has sourceDevice=WebGestureDeviceTouchscreen, WebGestureEvent.uniqueTouchEventId contains the unique identifier for the touch event that released the gesture event at TouchDispositionGestureFilter.

When the WebGestureEvents was not released through a touch event (e.g. timer-released gesture events or gesture events with sourceDevice!=WebGestureDeviceTouchscree), the field contains 0.

In the second case above, we should perhaps make this field more informative by setting it to the touch-start id or last triggering touch-event id.

A. Not obvious what we should do on double tap.
B. Need to be careful about two very quick single taps that are queued before the first touch-start ack comes back to TouchDispositionGestureFilter.
C. What about a mix of active/passive listeners for B?

Comment 1 by mustaq@chromium.org, Jun 9 2016 

For records, here are samples of the unique ids (in parentheses) we currently get for TEs and GEs:

[Sample1: quick tap]
touchstart(12), gesturetapdown(12),
touchend(13), gestureshowpress(13), gesturetap(13).

I also remember seeing a GestureTapUnconfirmed with correct id after gesturetapdown that seems to reset some following ids---at least the gesturetap id.

[Sample2: long tap]
touchstart(10), gesturetapdown(10), gestureshowpress(0), delay, gesturelongpress(0),
touchend(11), gesturetapdowncancel(11), gesturelongtap(11).


---

It may make more sense if all events (TE+GE) in the sequence carry the touchstart id.

Comment 2 by tdres...@chromium.org, Jun 10 2016 

gestureshowpress can either be fired on a delay, or when the touch release occurs, which is why it's inconsistent.

I'd be fine with making everything carry the touchstart id.

Comment 3 by mustaq@chromium.org, Apr 13 2017

Cc: dtapu...@chromium.org
Project Member

Comment 4 by sheriffbot@chromium.org, Apr 16 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by bokan@chromium.org, May 9 2018

Status: Assigned (was: Untriaged)
Assuming this is still relevant - Mustaq, please re-triage if not.

Comment 6 by mustaq@chromium.org, May 9 2018

Status: WontFix (was: Assigned)
I think this is still a problem, but no functionality is affected by this AFAIK.  I will close the bug now.  If someone finds a bug related to this crack, we can come back to this bug through an existing code comment:
https://cs.chromium.org/chromium/src/third_party/blink/public/platform/web_gesture_event.h?rcl=dfaa6bddf8d5e6ba4b73b51561063052e1bb732c&l=41
►

Sign in to add a comment