SavePackage::TruncateBaseNameToFitPathConstraints is wrong |
|||
Issue descriptionAs written, the function doesn't work even for UTF-8 based paths. * FilePaths cannot be truncated without knowing its encoding. For Posix systems, this isn't a given. When there are length constraints, the filename should be truncated at path generation time instead of afterwards. * Truncation should only be performed at character boundaries instead of byte offsets. * Path component length restrictions should be determined at runtime based on the underlying file system instead of using hardcoded constants. See base::GetMaximumPathComponentLength in file_util.h
,
Jun 12 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 16
|
|||
►
Sign in to add a comment |
|||
Comment 1 by asanka@chromium.org
, Jun 9 2016