New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 618733 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

clean up status.log when logging machine

Project Member Reported by kevcheng@chromium.org, Jun 9 2016

Issue description

in our status log we log the machine which sometimes is a dict which will soon contain an afe_host which will make the log entry really unwieldy.  Update the logging lines to be much more friendly.
 
Owner: jrbarnette@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/28aa689a4e1db1638229413b60ba4077416465fd

commit 28aa689a4e1db1638229413b60ba4077416465fd
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Fri Jun 10 20:00:58 2016

[autotest] Log hostname, not machine object in special tasks.

Recently, we changed the type of elements of the 'machines' list
given to special task from 'str' to 'dict'.  However, some log
message log 'machine', leading to worthless gobbledy-gook in
status.log.

This changes all the special task control files to go back to
logging just the hostname.

BUG= chromium:618733 
TEST=run special tasks in a local instance

Change-Id: I90105d1d3087c149926ad410a265dcff8d14ef8c
Reviewed-on: https://chromium-review.googlesource.com/351570
Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Kevin Cheng <kevcheng@chromium.org>

[modify] https://crrev.com/28aa689a4e1db1638229413b60ba4077416465fd/server/control_segments/verify
[modify] https://crrev.com/28aa689a4e1db1638229413b60ba4077416465fd/server/control_segments/provision
[modify] https://crrev.com/28aa689a4e1db1638229413b60ba4077416465fd/server/control_segments/repair
[modify] https://crrev.com/28aa689a4e1db1638229413b60ba4077416465fd/server/control_segments/reset
[modify] https://crrev.com/28aa689a4e1db1638229413b60ba4077416465fd/server/control_segments/cleanup

Status: Fixed (was: Started)

Sign in to add a comment