git cl upload gave me WindowsError: [Error 5] Access is denied |
|||
Issue descriptionVersion: gclient.py 0.7, git cl 1.0, depot tools rev 7bb9cf7 OS: Windows 10.0.10586 What steps will reproduce the problem? (1) git cl upload (2) sometimes gets Access is denied, not sure I can reliably reproduce. (3) What is the expected output? What do you see instead? c:\src\gclient\src>git cl upload Using 50% similarity for rename/copy detection. Override with --similarity. Running presubmit upload checks ... checking owners took a long time: 537ms Done processing c:\src\gclient\src\chrome\browser\install_verification\win\install_verification.cc INFO:root:Loading histograms.xml... INFO:root:histograms.xml is correctly pretty-printed. Presubmit checks took 12.1s to calculate. Presubmit checks passed. .../win/install_verification.cc | 51 ++++++++++++++++++++++ tools/metrics/histograms/histograms.xml | 30 +++++++++++++ 2 files changed, 81 insertions(+) This branch is associated with issue 2055613002. Adding patch to that issue. Upload server: https://codereview.chromium.org (change with -s/--server) Title describing this patch set: code review changes Issue updated. URL: https://codereview.chromium.org/2055613002 (patchset: 40001) Not uploading the base file for tools/metrics/histograms/histograms.xml because it's too large. Traceback (most recent call last): File "c:\src\depot_tools\python276_bin\lib\multiprocessing\util.py", line 268, in _run_finalizers finalizer() File "c:\src\depot_tools\python276_bin\lib\multiprocessing\util.py", line 201, in __call__ res = self._callback(*self._args, **self._kwargs) File "c:\src\depot_tools\python276_bin\lib\multiprocessing\pool.py", line 500, in _terminate_pool p.terminate() File "c:\src\depot_tools\python276_bin\lib\multiprocessing\process.py", line 137, in terminate self._popen.terminate() File "c:\src\depot_tools\python276_bin\lib\multiprocessing\forking.py", line 312, in terminate _subprocess.TerminateProcess(int(self._handle), TERMINATE) WindowsError: [Error 5] Access is denied c:\src\gclient\src> Please use labels and text to provide additional information.
,
Aug 11 2016
Still getting this as of 2016/08/11 depot_tools commit 9e198a8
,
Aug 17 2016
Heh, multiprocess + Python2.7 + Win is toxic :( Robbie, any idea?
,
Aug 31 2016
Issue 642872 has been merged into this issue.
,
Aug 31 2016
,
Sep 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/86099d7ce5d1e18e1832aa6c41c25908d42a2ca6 commit 86099d7ce5d1e18e1832aa6c41c25908d42a2ca6 Author: scottmg <scottmg@chromium.org> Date: Thu Sep 01 16:16:51 2016 Shutdown multiprocess pool after running tests to avoid _finalizer spew on Windows Can't just let the GC collect the pool on Windows. R=tandrii@chromium.org BUG= 618726 Review-Url: https://codereview.chromium.org/2296723006 [modify] https://crrev.com/86099d7ce5d1e18e1832aa6c41c25908d42a2ca6/presubmit_support.py [modify] https://crrev.com/86099d7ce5d1e18e1832aa6c41c25908d42a2ca6/tests/presubmit_unittest.py
,
Sep 1 2016
Hopefully fixed now.
,
Sep 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/fea22d1222db68c68b7d6e1bea7dabea384b6a93 commit fea22d1222db68c68b7d6e1bea7dabea384b6a93 Author: recipe-roller <recipe-roller@chromium.org> Date: Thu Sep 01 16:27:19 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) depot_tools: https://crrev.com/86099d7ce5d1e18e1832aa6c41c25908d42a2ca6 Shutdown multiprocess pool after running tests to avoid _finalizer spew on Windows (scottmg@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= 618726 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2301113002 [modify] https://crrev.com/fea22d1222db68c68b7d6e1bea7dabea384b6a93/infra/config/recipes.cfg
,
Sep 1 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/8573fb5ba5a3cfe2d6257beec258b9ce51b29af8 commit 8573fb5ba5a3cfe2d6257beec258b9ce51b29af8 Author: recipe-roller <recipe-roller@chromium.org> Date: Thu Sep 01 16:34:40 2016
,
Sep 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/a2b21abe8fe59e74a99aae9ddea86c18fc8c679a commit a2b21abe8fe59e74a99aae9ddea86c18fc8c679a Author: recipe-roller <recipe-roller@chromium.org> Date: Thu Sep 01 16:44:26 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/fea22d1222db68c68b7d6e1bea7dabea384b6a93 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) depot_tools: https://crrev.com/86099d7ce5d1e18e1832aa6c41c25908d42a2ca6 Shutdown multiprocess pool after running tests to avoid _finalizer spew on Windows (scottmg@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= 618726 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2294913007 [modify] https://crrev.com/a2b21abe8fe59e74a99aae9ddea86c18fc8c679a/infra/config/recipes.cfg
,
Sep 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1fea1772f885b6b685a991c0d477b3c5c1d30859 commit 1fea1772f885b6b685a991c0d477b3c5c1d30859 Author: recipe-roller <recipe-roller@chromium.org> Date: Thu Sep 01 16:42:13 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/fea22d1222db68c68b7d6e1bea7dabea384b6a93 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/e0d6ce3e5ab8c9c27ee2147334802a41502f7eb6 Add ClangToTLinuxAsanLibfuzzer (ochang@chromium.org) depot_tools: https://crrev.com/86099d7ce5d1e18e1832aa6c41c25908d42a2ca6 Shutdown multiprocess pool after running tests to avoid _finalizer spew on Windows (scottmg@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= 635952 , 618726 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2299213002 Cr-Commit-Position: refs/heads/master@{#415970} [modify] https://crrev.com/1fea1772f885b6b685a991c0d477b3c5c1d30859/infra/config/recipes.cfg |
|||
►
Sign in to add a comment |
|||
Comment 1 by wfh@chromium.org
, Jun 9 2016