New issue
Advanced search Search tips

Issue 618718 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Extract media/capture unittests into its own executable

Project Member Reported by mcasas@chromium.org, Jun 9 2016

Issue description

media/capture has unittests but they are bundled
inside media_unittests [1,2]. This will also 
hold after https://crrev.com/2031073002/.

Consider extracting them to its own executable
as e.g. media/midi does.


[1] https://cs.chromium.org/chromium/src/media/BUILD.gn?dr=C&q=capture:unittests&sq=package:chromium&l=602
[2] https://cs.chromium.org/chromium/src/media/media.gyp?q=capture_unittests&sq=package:chromium&l=1153&dr=C
 

Comment 1 by mcasas@chromium.org, Jun 21 2016

Cc: emir...@chromium.org chfremer@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13b4123d553a41899acebba9020b99ace0f2472d

commit 13b4123d553a41899acebba9020b99ace0f2472d
Author: mcasas <mcasas@chromium.org>
Date: Thu Jun 23 19:52:10 2016

Extract media/capture/capture_unittests from media_unittests

This CL:
- extracts capture_unittests out of media_unittests.
- adds it to all testing/buildbot/*.json where appropriate,
  i.e. where there is media_unittests.
- adds the necessary .isolate and _apk.isolate.

BUG= 618718 
TEST= No new code added, all bots running capture_unittests
and being happy with it.¯

TBR=miu@chromium.org

Review-Url: https://codereview.chromium.org/2087683002
Cr-Commit-Position: refs/heads/master@{#401692}

[modify] https://crrev.com/13b4123d553a41899acebba9020b99ace0f2472d/BUILD.gn
[modify] https://crrev.com/13b4123d553a41899acebba9020b99ace0f2472d/build/all.gyp
[modify] https://crrev.com/13b4123d553a41899acebba9020b99ace0f2472d/media/BUILD.gn
[modify] https://crrev.com/13b4123d553a41899acebba9020b99ace0f2472d/media/base/run_all_unittests.cc
[modify] https://crrev.com/13b4123d553a41899acebba9020b99ace0f2472d/media/capture/BUILD.gn
[modify] https://crrev.com/13b4123d553a41899acebba9020b99ace0f2472d/media/capture/capture.gyp
[add] https://crrev.com/13b4123d553a41899acebba9020b99ace0f2472d/media/capture/capture_unittests.isolate
[add] https://crrev.com/13b4123d553a41899acebba9020b99ace0f2472d/media/capture/capture_unittests_apk.isolate
[modify] https://crrev.com/13b4123d553a41899acebba9020b99ace0f2472d/media/capture/video/android/photo_capabilities.h
[modify] https://crrev.com/13b4123d553a41899acebba9020b99ace0f2472d/media/media.gyp
[modify] https://crrev.com/13b4123d553a41899acebba9020b99ace0f2472d/testing/buildbot/chromium.android.json
[modify] https://crrev.com/13b4123d553a41899acebba9020b99ace0f2472d/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/13b4123d553a41899acebba9020b99ace0f2472d/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/13b4123d553a41899acebba9020b99ace0f2472d/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/13b4123d553a41899acebba9020b99ace0f2472d/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/13b4123d553a41899acebba9020b99ace0f2472d/testing/buildbot/chromium.memory.fyi.json
[modify] https://crrev.com/13b4123d553a41899acebba9020b99ace0f2472d/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/13b4123d553a41899acebba9020b99ace0f2472d/testing/buildbot/chromium.webrtc.fyi.json
[modify] https://crrev.com/13b4123d553a41899acebba9020b99ace0f2472d/testing/buildbot/chromium.webrtc.json
[modify] https://crrev.com/13b4123d553a41899acebba9020b99ace0f2472d/testing/buildbot/chromium.win.json
[modify] https://crrev.com/13b4123d553a41899acebba9020b99ace0f2472d/testing/buildbot/chromium_memory_trybot.json
[modify] https://crrev.com/13b4123d553a41899acebba9020b99ace0f2472d/testing/buildbot/client.v8.fyi.json
[modify] https://crrev.com/13b4123d553a41899acebba9020b99ace0f2472d/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/13b4123d553a41899acebba9020b99ace0f2472d/testing/buildbot/tryserver.v8.json

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5de80c184c4e0f4460809d8fb52253b087a0e6df

commit 5de80c184c4e0f4460809d8fb52253b087a0e6df
Author: mcasas <mcasas@chromium.org>
Date: Thu Jun 23 21:17:47 2016

Revert of Extract media/capture/capture_unittests from media_unittests (patchset #4 id:120001 of https://codereview.chromium.org/2087683002/ )

Reason for revert:
Broke Win x64 bot  https://build.chromium.org/p/chromium/builders/Win%20x64/builds/1849

FAILED: audio_unittests.exe audio_unittests.exe.pdb
C:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests environment.x64 True audio_unittests.exe "C:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper environment.x64 False link.exe /nologo /OUT:audio_unittests.exe @audio_unittests.exe.rsp" 1 mt.exe rc.exe "obj\media\audio_unittests.audio_unittests.exe.intermediate.manifest" obj\media\audio_unittests.audio_unittests.exe.generated.manifest ..\..\build\win\compatibility.manifest
media.lib(media.core_audio_util_win.obj) : error LNK2019: unresolved external symbol CLSID_DxDiagProvider referenced in function "public: static bool __cdecl media::CoreAudioUtil::GetDxDiagDetails(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > *,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > *)" (?GetDxDiagDetails@CoreAudioUtil@media@@SA_NPEAV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@0@Z)

media.lib(media.core_audio_util_win.obj) : error LNK2019: unresolved external symbol IID_IDxDiagProvider referenced in function "public: static bool __cdecl media::CoreAudioUtil::GetDxDiagDetails(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > *,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > *)" (?GetDxDiagDetails@CoreAudioUtil@media@@SA_NPEAV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@0@Z)

audio_unittests.exe : fatal error LNK1120: 2 unresolved externals

Original issue's description:
> Extract media/capture/capture_unittests from media_unittests
>
> This CL:
> - extracts capture_unittests out of media_unittests.
> - adds it to all testing/buildbot/*.json where appropriate,
>   i.e. where there is media_unittests.
> - adds the necessary .isolate and _apk.isolate.
>
> BUG= 618718 
> TEST= No new code added, all bots running capture_unittests
> and being happy with it.¯
>
> TBR=miu@chromium.org
>
> Committed: https://crrev.com/13b4123d553a41899acebba9020b99ace0f2472d
> Cr-Commit-Position: refs/heads/master@{#401692}

TBR=xhwang@chromium.org,maruel@chromium.org,brettw@chromium.org,miu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 618718 

Review-Url: https://codereview.chromium.org/2093563004
Cr-Commit-Position: refs/heads/master@{#401714}

[modify] https://crrev.com/5de80c184c4e0f4460809d8fb52253b087a0e6df/BUILD.gn
[modify] https://crrev.com/5de80c184c4e0f4460809d8fb52253b087a0e6df/build/all.gyp
[modify] https://crrev.com/5de80c184c4e0f4460809d8fb52253b087a0e6df/media/BUILD.gn
[modify] https://crrev.com/5de80c184c4e0f4460809d8fb52253b087a0e6df/media/base/run_all_unittests.cc
[modify] https://crrev.com/5de80c184c4e0f4460809d8fb52253b087a0e6df/media/capture/BUILD.gn
[modify] https://crrev.com/5de80c184c4e0f4460809d8fb52253b087a0e6df/media/capture/capture.gyp
[delete] https://crrev.com/a806e74826ea63c1493d850e2bb0e4dbcb7f0456/media/capture/capture_unittests.isolate
[delete] https://crrev.com/a806e74826ea63c1493d850e2bb0e4dbcb7f0456/media/capture/capture_unittests_apk.isolate
[modify] https://crrev.com/5de80c184c4e0f4460809d8fb52253b087a0e6df/media/capture/video/android/photo_capabilities.h
[modify] https://crrev.com/5de80c184c4e0f4460809d8fb52253b087a0e6df/media/media.gyp
[modify] https://crrev.com/5de80c184c4e0f4460809d8fb52253b087a0e6df/testing/buildbot/chromium.android.json
[modify] https://crrev.com/5de80c184c4e0f4460809d8fb52253b087a0e6df/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/5de80c184c4e0f4460809d8fb52253b087a0e6df/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/5de80c184c4e0f4460809d8fb52253b087a0e6df/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/5de80c184c4e0f4460809d8fb52253b087a0e6df/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/5de80c184c4e0f4460809d8fb52253b087a0e6df/testing/buildbot/chromium.memory.fyi.json
[modify] https://crrev.com/5de80c184c4e0f4460809d8fb52253b087a0e6df/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/5de80c184c4e0f4460809d8fb52253b087a0e6df/testing/buildbot/chromium.webrtc.fyi.json
[modify] https://crrev.com/5de80c184c4e0f4460809d8fb52253b087a0e6df/testing/buildbot/chromium.webrtc.json
[modify] https://crrev.com/5de80c184c4e0f4460809d8fb52253b087a0e6df/testing/buildbot/chromium.win.json
[modify] https://crrev.com/5de80c184c4e0f4460809d8fb52253b087a0e6df/testing/buildbot/chromium_memory_trybot.json
[modify] https://crrev.com/5de80c184c4e0f4460809d8fb52253b087a0e6df/testing/buildbot/client.v8.fyi.json
[modify] https://crrev.com/5de80c184c4e0f4460809d8fb52253b087a0e6df/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/5de80c184c4e0f4460809d8fb52253b087a0e6df/testing/buildbot/tryserver.v8.json

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2f53ea376660b150b8bdc7d1341a43db557711e

commit d2f53ea376660b150b8bdc7d1341a43db557711e
Author: mcasas <mcasas@chromium.org>
Date: Fri Jun 24 19:24:27 2016

Reland: Extract media/capture/capture_unittests from media_unittests

Original CL got reverted due to audio_unittests not finding two
symbols
error LNK2019: unresolved external symbol CLSID_DxDiagProvider
error LNK2019: unresolved external symbol IID_IDxDiagProvider

CQ doesn't have any gyp + win x64 bot, so didn't catch
it, but it can be repro using   win_clang_x64_rel bot --  see
it failing in PS1 and compiling in PS2.

Original's issue description -------------------------------------------
Extract media/capture/capture_unittests from media_unittests

This CL:
- extracts capture_unittests out of media_unittests.
- adds it to all testing/buildbot/*.json where appropriate,
  i.e. where there is media_unittests.
- adds the necessary .isolate and _apk.isolate.

BUG= 618718 
TEST= No new code added, all bots running capture_unittests
and being happy with it.¯

------------------------------------------------------------------------

TBR=miu@chromium.org, xhwang@chromium.org, maruel@chromium.org, brettw@chromium.org

Review-Url: https://codereview.chromium.org/2095623003
Cr-Commit-Position: refs/heads/master@{#401927}

[modify] https://crrev.com/d2f53ea376660b150b8bdc7d1341a43db557711e/BUILD.gn
[modify] https://crrev.com/d2f53ea376660b150b8bdc7d1341a43db557711e/build/all.gyp
[modify] https://crrev.com/d2f53ea376660b150b8bdc7d1341a43db557711e/media/BUILD.gn
[modify] https://crrev.com/d2f53ea376660b150b8bdc7d1341a43db557711e/media/base/run_all_unittests.cc
[modify] https://crrev.com/d2f53ea376660b150b8bdc7d1341a43db557711e/media/capture/BUILD.gn
[modify] https://crrev.com/d2f53ea376660b150b8bdc7d1341a43db557711e/media/capture/capture.gyp
[add] https://crrev.com/d2f53ea376660b150b8bdc7d1341a43db557711e/media/capture/capture_unittests.isolate
[add] https://crrev.com/d2f53ea376660b150b8bdc7d1341a43db557711e/media/capture/capture_unittests_apk.isolate
[modify] https://crrev.com/d2f53ea376660b150b8bdc7d1341a43db557711e/media/capture/video/android/photo_capabilities.h
[modify] https://crrev.com/d2f53ea376660b150b8bdc7d1341a43db557711e/media/media.gyp
[modify] https://crrev.com/d2f53ea376660b150b8bdc7d1341a43db557711e/testing/buildbot/chromium.android.json
[modify] https://crrev.com/d2f53ea376660b150b8bdc7d1341a43db557711e/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/d2f53ea376660b150b8bdc7d1341a43db557711e/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/d2f53ea376660b150b8bdc7d1341a43db557711e/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/d2f53ea376660b150b8bdc7d1341a43db557711e/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/d2f53ea376660b150b8bdc7d1341a43db557711e/testing/buildbot/chromium.memory.fyi.json
[modify] https://crrev.com/d2f53ea376660b150b8bdc7d1341a43db557711e/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/d2f53ea376660b150b8bdc7d1341a43db557711e/testing/buildbot/chromium.webrtc.fyi.json
[modify] https://crrev.com/d2f53ea376660b150b8bdc7d1341a43db557711e/testing/buildbot/chromium.webrtc.json
[modify] https://crrev.com/d2f53ea376660b150b8bdc7d1341a43db557711e/testing/buildbot/chromium.win.json
[modify] https://crrev.com/d2f53ea376660b150b8bdc7d1341a43db557711e/testing/buildbot/chromium_memory_trybot.json
[modify] https://crrev.com/d2f53ea376660b150b8bdc7d1341a43db557711e/testing/buildbot/client.v8.fyi.json
[modify] https://crrev.com/d2f53ea376660b150b8bdc7d1341a43db557711e/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/d2f53ea376660b150b8bdc7d1341a43db557711e/testing/buildbot/tryserver.v8.json

Comment 5 by mcasas@chromium.org, Jun 27 2016

Owner: mcasas@chromium.org
Status: Fixed (was: Available)
Seems to be sticking: closing! \o/
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f53aa4322d58784abd314573f0dca2c47ce1a698

commit f53aa4322d58784abd314573f0dca2c47ce1a698
Author: mcasas <mcasas@chromium.org>
Date: Thu Jul 14 01:34:24 2016

Move media/capture/content/feedback_signal_accumulator{.h,_unittest.cc} to media/base

feedback_signal_accumulator.h contains a generic templatised class used
by cast/sender/vp8_encoder.cc and capture/content/video_capture_oracle.cc
Since media/capture is now a component (and so is media/cast), it
makes sense to move it to a common place, media/base being a good
option.

gn and gyp files are updated, and the _unittest.cc file is moved as
well.

This cleanup came up while working on  https://crbug.com/626125 

BUG= 618718 
TEST= no new code: all builds and unittests working as before.

Review-Url: https://codereview.chromium.org/2149793003
Cr-Commit-Position: refs/heads/master@{#405389}

[modify] https://crrev.com/f53aa4322d58784abd314573f0dca2c47ce1a698/media/base/BUILD.gn
[rename] https://crrev.com/f53aa4322d58784abd314573f0dca2c47ce1a698/media/base/feedback_signal_accumulator.h
[rename] https://crrev.com/f53aa4322d58784abd314573f0dca2c47ce1a698/media/base/feedback_signal_accumulator_unittest.cc
[modify] https://crrev.com/f53aa4322d58784abd314573f0dca2c47ce1a698/media/capture/BUILD.gn
[modify] https://crrev.com/f53aa4322d58784abd314573f0dca2c47ce1a698/media/capture/capture.gyp
[modify] https://crrev.com/f53aa4322d58784abd314573f0dca2c47ce1a698/media/capture/content/video_capture_oracle.h
[modify] https://crrev.com/f53aa4322d58784abd314573f0dca2c47ce1a698/media/cast/sender/vp8_encoder.h
[modify] https://crrev.com/f53aa4322d58784abd314573f0dca2c47ce1a698/media/media.gyp

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/d9b49d015428fba8ce2d85d76279c78f7df767c3

commit d9b49d015428fba8ce2d85d76279c78f7df767c3
Author: phoglund <phoglund@chromium.org>
Date: Fri Jul 29 13:43:05 2016

Adding capture unittests to webcam-equipped WebRTC bots.

BUG= 618718 

Review-Url: https://codereview.chromium.org/2119233003

[modify] https://crrev.com/d9b49d015428fba8ce2d85d76279c78f7df767c3/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py
[modify] https://crrev.com/d9b49d015428fba8ce2d85d76279c78f7df767c3/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Linux_Builder.json
[modify] https://crrev.com/d9b49d015428fba8ce2d85d76279c78f7df767c3/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Linux_Tester.json
[modify] https://crrev.com/d9b49d015428fba8ce2d85d76279c78f7df767c3/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Mac_Builder.json
[modify] https://crrev.com/d9b49d015428fba8ce2d85d76279c78f7df767c3/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Mac_Tester.json
[modify] https://crrev.com/d9b49d015428fba8ce2d85d76279c78f7df767c3/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Win10_Tester.json
[modify] https://crrev.com/d9b49d015428fba8ce2d85d76279c78f7df767c3/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Win7_Tester.json
[modify] https://crrev.com/d9b49d015428fba8ce2d85d76279c78f7df767c3/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Win8_Tester.json
[modify] https://crrev.com/d9b49d015428fba8ce2d85d76279c78f7df767c3/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Win_Builder.json
[modify] https://crrev.com/d9b49d015428fba8ce2d85d76279c78f7df767c3/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Linux_Builder.json
[modify] https://crrev.com/d9b49d015428fba8ce2d85d76279c78f7df767c3/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Linux_Tester.json
[modify] https://crrev.com/d9b49d015428fba8ce2d85d76279c78f7df767c3/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Mac_Builder.json
[modify] https://crrev.com/d9b49d015428fba8ce2d85d76279c78f7df767c3/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Mac_Tester.json
[modify] https://crrev.com/d9b49d015428fba8ce2d85d76279c78f7df767c3/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Win10_Tester.json
[modify] https://crrev.com/d9b49d015428fba8ce2d85d76279c78f7df767c3/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Win7_Tester.json
[modify] https://crrev.com/d9b49d015428fba8ce2d85d76279c78f7df767c3/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Win_Builder.json

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/d9b49d015428fba8ce2d85d76279c78f7df767c3

commit d9b49d015428fba8ce2d85d76279c78f7df767c3
Author: phoglund <phoglund@chromium.org>
Date: Fri Jul 29 13:43:05 2016

Adding capture unittests to webcam-equipped WebRTC bots.

BUG= 618718 

Review-Url: https://codereview.chromium.org/2119233003

[modify] https://crrev.com/d9b49d015428fba8ce2d85d76279c78f7df767c3/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py
[modify] https://crrev.com/d9b49d015428fba8ce2d85d76279c78f7df767c3/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Linux_Builder.json
[modify] https://crrev.com/d9b49d015428fba8ce2d85d76279c78f7df767c3/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Linux_Tester.json
[modify] https://crrev.com/d9b49d015428fba8ce2d85d76279c78f7df767c3/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Mac_Builder.json
[modify] https://crrev.com/d9b49d015428fba8ce2d85d76279c78f7df767c3/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Mac_Tester.json
[modify] https://crrev.com/d9b49d015428fba8ce2d85d76279c78f7df767c3/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Win10_Tester.json
[modify] https://crrev.com/d9b49d015428fba8ce2d85d76279c78f7df767c3/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Win7_Tester.json
[modify] https://crrev.com/d9b49d015428fba8ce2d85d76279c78f7df767c3/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Win8_Tester.json
[modify] https://crrev.com/d9b49d015428fba8ce2d85d76279c78f7df767c3/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Win_Builder.json
[modify] https://crrev.com/d9b49d015428fba8ce2d85d76279c78f7df767c3/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Linux_Builder.json
[modify] https://crrev.com/d9b49d015428fba8ce2d85d76279c78f7df767c3/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Linux_Tester.json
[modify] https://crrev.com/d9b49d015428fba8ce2d85d76279c78f7df767c3/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Mac_Builder.json
[modify] https://crrev.com/d9b49d015428fba8ce2d85d76279c78f7df767c3/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Mac_Tester.json
[modify] https://crrev.com/d9b49d015428fba8ce2d85d76279c78f7df767c3/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Win10_Tester.json
[modify] https://crrev.com/d9b49d015428fba8ce2d85d76279c78f7df767c3/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Win7_Tester.json
[modify] https://crrev.com/d9b49d015428fba8ce2d85d76279c78f7df767c3/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Win_Builder.json

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 29 2016

Project Member

Comment 11 by bugdroid1@chromium.org, Jul 29 2016

Project Member

Comment 12 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/f7842261e4d71926cc486307e30ec5655be8bb43

commit f7842261e4d71926cc486307e30ec5655be8bb43
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Jul 29 14:06:03 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/d9b49d015428fba8ce2d85d76279c78f7df767c3 Adding capture unittests to webcam-equipped WebRTC bots. (phoglund@chromium.org)

R=phoglund@chromium.org
BUG= 618718 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2191293003

[modify] https://crrev.com/f7842261e4d71926cc486307e30ec5655be8bb43/infra/config/recipes.cfg

Project Member

Comment 13 by bugdroid1@chromium.org, Aug 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/4caf780db33469b8003353ec6443e46c4722f65d

commit 4caf780db33469b8003353ec6443e46c4722f65d
Author: ehmaldonado <ehmaldonado@chromium.org>
Date: Wed Aug 03 11:45:40 2016

Remove media_unittests.

The entry doesn't apply anymore, since VideoCaptureDeviceTest* was
moved to capture_unittests.

BUG= 618718 

Review-Url: https://codereview.chromium.org/2203323002

[modify] https://crrev.com/4caf780db33469b8003353ec6443e46c4722f65d/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py
[modify] https://crrev.com/4caf780db33469b8003353ec6443e46c4722f65d/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Linux_Builder.json
[modify] https://crrev.com/4caf780db33469b8003353ec6443e46c4722f65d/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Linux_Tester.json
[modify] https://crrev.com/4caf780db33469b8003353ec6443e46c4722f65d/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Mac_Builder.json
[modify] https://crrev.com/4caf780db33469b8003353ec6443e46c4722f65d/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Mac_Tester.json
[modify] https://crrev.com/4caf780db33469b8003353ec6443e46c4722f65d/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Win10_Tester.json
[modify] https://crrev.com/4caf780db33469b8003353ec6443e46c4722f65d/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Win7_Tester.json
[modify] https://crrev.com/4caf780db33469b8003353ec6443e46c4722f65d/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Win8_Tester.json
[modify] https://crrev.com/4caf780db33469b8003353ec6443e46c4722f65d/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Win_Builder.json
[modify] https://crrev.com/4caf780db33469b8003353ec6443e46c4722f65d/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Linux_Builder.json
[modify] https://crrev.com/4caf780db33469b8003353ec6443e46c4722f65d/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Linux_Tester.json
[modify] https://crrev.com/4caf780db33469b8003353ec6443e46c4722f65d/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Mac_Builder.json
[modify] https://crrev.com/4caf780db33469b8003353ec6443e46c4722f65d/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Mac_Tester.json
[modify] https://crrev.com/4caf780db33469b8003353ec6443e46c4722f65d/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Win10_Tester.json
[modify] https://crrev.com/4caf780db33469b8003353ec6443e46c4722f65d/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Win7_Tester.json
[modify] https://crrev.com/4caf780db33469b8003353ec6443e46c4722f65d/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Win_Builder.json

Project Member

Comment 14 by bugdroid1@chromium.org, Aug 3 2016

Project Member

Comment 15 by bugdroid1@chromium.org, Aug 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/bfb527039f2fc45379fb9b634256a7dc2d48af1a

commit bfb527039f2fc45379fb9b634256a7dc2d48af1a
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Aug 03 12:16:26 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/b0527999d735b56c01137274294fb25088afc5fe export_tarball: update skia/ext/skia_commit_hash.h (phajdan.jr@chromium.org)
  https://crrev.com/dd506d25c0eaaab0921400f8656a9ec34b280aa6 [Skia] Convert the 10k Nanobench CPU and GPU bots into 1k bots (rmistry@google.com)
  https://crrev.com/4caf780db33469b8003353ec6443e46c4722f65d Remove media_unittests. (ehmaldonado@chromium.org)

R=ehmaldonado@chromium.org,rmistry@google.com,phajdan.jr@chromium.org
BUG= 618718 ,none,skia:5598

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2209643002

[modify] https://crrev.com/bfb527039f2fc45379fb9b634256a7dc2d48af1a/infra/config/recipes.cfg

Sign in to add a comment