New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 618715 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Don't put CQ_EXTRA_TRYBOTS for disable CL's.

Project Member Reported by simonhatch@chromium.org, Jun 9 2016

Issue description

What do you think about expanding the logic a bit here to not put the extra trybots in the case of simple disables? I'm not sure there's much point in sending these off to the perf trybots in cases where sheriffs are just disabling broken tests.

 
Cc: nednguyen@chromium.org
Components: -Tests Tests>AutoBisect
This makes sense, but the main requirement for CQ perf jobs to check if the change breaks any perf benchmarks. It is highly unlikely that disabling a benchmark would break anything, but incase if sheriff thinks the CQ is unnecessary then they can always remove the CQ_EXTRA_TRYBOTS from description and commit the CL.

+1 to what Prasad says. Doing static analysis on the code to know whether the CL is just a disable CL seems hard..
FWIW I actually managed to typo the disabled annotation a few times and these bots caught my mistake.
Status: WontFix (was: Untriaged)
Ah ok, sounds like this is catching things :) Nevermind then!
Components: Speed>Bisection

Sign in to add a comment