New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 618709 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

Fix recipes.py blind reliance on coverage in sys.path before moving to recipes to client repos

Project Member Reported by tandrii@chromium.org, Jun 9 2016

Issue description

The fact that recipe expectation needs coverage is well known.
Please, fix this before shipping recipes.py to every repository out there.
 
Cc: phajdan@google.com iannucci@chromium.org martiniss@chromium.org
Could we vendor coverage into the recipe engine since it's a hard dependency? That way each repo wouldn't need to have it set up.

Comment 2 by estaab@chromium.org, Jun 10 2016

Ok, Robbie says we can't vendor it since it needs to be compiled. Maybe we can just fail more gracefully for now.
+1 for failing gracefully. Also, martiniss@ CL https://codereview.chromium.org/2064453002/ gave an idea: why can't we copy-paste  bootstrap/ from infra/infra to recipes-py repository and edit deps.pyl to just contain coverage? Then, recipes.py would just run bootstrap right after cloning recipe engine repo (recipes-py)

Comment 4 by iannu...@google.com, Jun 14 2016

copy-pasting bootstrap may not be the worst thing.

Comment 5 by iannu...@google.com, Jun 14 2016

(I've somewhat given up on python package management at this point... bootstrap is the least worst thing we've got at this point. There's also glyco (I think?) but I'm not sure how it deals with compiled dependencies).
Owner: martiniss@chromium.org
Status: Started (was: Untriaged)
I'll move a small version of bootstrap into recipes.
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/adf9f0db005b9617bcd81de3083d31571031114a

commit adf9f0db005b9617bcd81de3083d31571031114a
Author: recipe-roller <recipe-roller@chromium.org>
Date: Thu Jun 16 07:51:12 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/a6baded1c8c7a15dd1e4020289fd19d985f58c25 add basic bootstrap for coverage (martiniss@google.com)

R=martiniss@google.com,iannucci@chromium.org,phajdan.jr@chromium.org
BUG= 618709 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2075483002

[modify] https://crrev.com/adf9f0db005b9617bcd81de3083d31571031114a/infra/config/recipes.cfg

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/44072249bbf05af66334a3be12a04eebfa983de3

commit 44072249bbf05af66334a3be12a04eebfa983de3
Author: recipe-roller <recipe-roller@chromium.org>
Date: Thu Jun 16 07:55:53 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

depot_tools:
  https://crrev.com/adf9f0db005b9617bcd81de3083d31571031114a Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
recipe_engine:
  https://crrev.com/a6baded1c8c7a15dd1e4020289fd19d985f58c25 add basic bootstrap for coverage (martiniss@google.com)

R=martiniss@google.com,phajdan.jr@chromium.org,iannucci@chromium.org,martiniss@chromium.org,recipe-roller@chromium.org
BUG= 618709 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2072453003

[modify] https://crrev.com/44072249bbf05af66334a3be12a04eebfa983de3/infra/config/recipes.cfg

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/c0a34113486a88427f90ce3f1214f5198c97287f

commit c0a34113486a88427f90ce3f1214f5198c97287f
Author: recipe-roller <recipe-roller@chromium.org>
Date: Thu Jun 16 08:19:47 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/44072249bbf05af66334a3be12a04eebfa983de3 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/adf9f0db005b9617bcd81de3083d31571031114a Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
recipe_engine:
  https://crrev.com/a6baded1c8c7a15dd1e4020289fd19d985f58c25 add basic bootstrap for coverage (martiniss@google.com)

R=martiniss@google.com,phajdan.jr@chromium.org,martiniss@chromium.org,iannucci@chromium.org,recipe-roller@chromium.org
BUG= 618709 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2069943005

[modify] https://crrev.com/c0a34113486a88427f90ce3f1214f5198c97287f/infra/config/recipes.cfg

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 17 2016

Labels: Pri-2
Status: Assigned (was: Started)
Status: Started (was: Assigned)
Status: Fixed (was: Started)
This is done. You can use --use-bootstrap to download a version of coverage.

Sign in to add a comment