lkgr ubsan and tsan targets broken after moving them to recipes |
|||
Issue description/b/build/scripts/slave/.recipe_deps/depot_tools/ninja -w dupbuild=err -C /b/build/slave/UBSan_Release/build/src/out/Release chromium_builder_asan -j50 ninja: Entering directory `/b/build/slave/UBSan_Release/build/src/out/Release' ninja: error: unknown target 'chromium_builder_asan' The reason for this is actually hilarious: Before the recipes switch (https://build.chromium.org/p/chromium.lkgr/builders/TSAN%20Release/builds/3286), runhooks was still running gyp, and then generate_build_files ran later, but it ran `gn gen out/None` (!) instead of `gn gen out/Release`, and so the gn-written files went to a different directory and weren't used :-( I'll see if there's a quick fix, and if not I guess I'll switch this bot back to gyp for a bit (since the switch to gn didn't really switch them to gn, but since the bots weren't on recipes we didn't notice)
,
Jun 10 2016
,
Jun 10 2016
,
Jun 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f7d4fc75b62ca7008642c5aea6233eade695da5 commit 3f7d4fc75b62ca7008642c5aea6233eade695da5 Author: thakis <thakis@chromium.org> Date: Fri Jun 10 18:47:50 2016 gn: Add chromium_builder_asan target. All the LKGR clusterfuzz bots build this target, so add it to allow switching these bots to gn. BUG= 618702 , 542853 , 619086 TBR=eroman Review-Url: https://codereview.chromium.org/2059843002 Cr-Commit-Position: refs/heads/master@{#399241} [modify] https://crrev.com/3f7d4fc75b62ca7008642c5aea6233eade695da5/BUILD.gn [modify] https://crrev.com/3f7d4fc75b62ca7008642c5aea6233eade695da5/build/all.gyp [modify] https://crrev.com/3f7d4fc75b62ca7008642c5aea6233eade695da5/build/sanitizers/BUILD.gn [modify] https://crrev.com/3f7d4fc75b62ca7008642c5aea6233eade695da5/build/sanitizers/sanitizers.gyp [modify] https://crrev.com/3f7d4fc75b62ca7008642c5aea6233eade695da5/chrome/chrome_syzygy.gyp [modify] https://crrev.com/3f7d4fc75b62ca7008642c5aea6233eade695da5/net/net.gyp
,
Jun 10 2016
They look better now. ("ASAN Debug" is due to bug 618849)
I just relanded the gn switch after adding chromium_builder_asan, hopefully the waterfall will look better this time round. But the recipe switch looks like it worked.
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f7d4fc75b62ca7008642c5aea6233eade695da5 commit 3f7d4fc75b62ca7008642c5aea6233eade695da5 Author: thakis <thakis@chromium.org> Date: Fri Jun 10 18:47:50 2016 gn: Add chromium_builder_asan target. All the LKGR clusterfuzz bots build this target, so add it to allow switching these bots to gn. BUG= 618702 , 542853 , 619086 TBR=eroman Review-Url: https://codereview.chromium.org/2059843002 Cr-Commit-Position: refs/heads/master@{#399241} [modify] https://crrev.com/3f7d4fc75b62ca7008642c5aea6233eade695da5/BUILD.gn [modify] https://crrev.com/3f7d4fc75b62ca7008642c5aea6233eade695da5/build/all.gyp [modify] https://crrev.com/3f7d4fc75b62ca7008642c5aea6233eade695da5/build/sanitizers/BUILD.gn [modify] https://crrev.com/3f7d4fc75b62ca7008642c5aea6233eade695da5/build/sanitizers/sanitizers.gyp [modify] https://crrev.com/3f7d4fc75b62ca7008642c5aea6233eade695da5/chrome/chrome_syzygy.gyp [modify] https://crrev.com/3f7d4fc75b62ca7008642c5aea6233eade695da5/net/net.gyp |
|||
►
Sign in to add a comment |
|||
Comment 1 by thakis@chromium.org
, Jun 9 2016