New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 618700 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Long pressing on tel: URL link should not show invalid context menu options.

Project Member Reported by ajit...@samsung.com, Jun 9 2016

Issue description

Version: Chrome 50.0.2661.89
OS: Android 5.1.1 Lollipop
Device: Samsung Galaxy Note4 SM-910F

What steps will reproduce the problem?
(1) load www.oznium.com
(2) Long press on the tel link in the web page
(3) Context menu is appeared. (Observe context menu items)

What is the expected output?
Irrelevent options like "Open in new tab" & "Open in incognito tab" should not be seen.

What do you see instead?
We can see "Open in new tab". "Open in incognito tab" options, which is not relevant to tel: URLs. If we select those options blank page with "about:blank" is getting opened, which is useless


 
recording.mp4
6.5 MB View Download
Cc: amaralp@chromium.org
Status: Available (was: Untriaged)
Owner: amaralp@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdd83683711c3bb501a693e9fd1281c794dee694

commit fdd83683711c3bb501a693e9fd1281c794dee694
Author: amaralp <amaralp@chromium.org>
Date: Thu Jun 09 20:48:15 2016

Don't show navigation menu items when URI isnt accepted

Don't show "open in new window", "open in new tab", or "open in incognito tab" if URI isn't accepted.
BUG= 618700 

Review-Url: https://codereview.chromium.org/2048353004
Cr-Commit-Position: refs/heads/master@{#399005}

[modify] https://crrev.com/fdd83683711c3bb501a693e9fd1281c794dee694/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

Status: Fixed (was: Started)

Comment 5 by ajit...@samsung.com, Jun 10 2016

Thanks a lot for fixing this in super quick time :)
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdd83683711c3bb501a693e9fd1281c794dee694

commit fdd83683711c3bb501a693e9fd1281c794dee694
Author: amaralp <amaralp@chromium.org>
Date: Thu Jun 09 20:48:15 2016

Don't show navigation menu items when URI isnt accepted

Don't show "open in new window", "open in new tab", or "open in incognito tab" if URI isn't accepted.
BUG= 618700 

Review-Url: https://codereview.chromium.org/2048353004
Cr-Commit-Position: refs/heads/master@{#399005}

[modify] https://crrev.com/fdd83683711c3bb501a693e9fd1281c794dee694/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

Sign in to add a comment