New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 618697 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Dec 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug
mus



Sign in to add a comment

Avoid extra copies in ui::Event struct-traits

Project Member Reported by moshayedi@chromium.org, Jun 9 2016

Issue description

Right now we still suffer from extra copies for derived types like ui::KeyEvent. We create a bunch of temporary mojom::*Data types and then copy things over to their file destination. We need to direct copy into the final destination which means we need StructTraits for derived types too. For example:

struct StructTraits<ui::mojom::KeyData, std::unique_ptr<ui::KeyEvent>> {
 .. 
}

would populate the key event specific fields in the KeyEvent.

 
file should be final. Sorry for the typo.
Summary: Avoid extra copies in ui::Event struct-traits (was: Send even data structs directly over mojo IPC)
Components: Internals>MUS
Labels: Proj-Mustash
Cc: moshayedi@chromium.org
Owner: ----
Status: Available (was: Assigned)
Components: -Internals>MUS Internals>Services>WindowService
Components: -MUS>Phase>1
Labels: -Proj-Mustash Proj-Mash OS-Chrome
Labels: -Pri-2 Pri-3
Status: Fixed (was: Available)
This was done a while back.

Sign in to add a comment