video-layer-crash.html and layer-compositing-reasons.html are flaky on Mac10.11 retina |
||||||
Issue descriptionPlease refer to: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28retina%29/builds/3599 Seems to start from: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20(retina)/builds/3574 Marking it as [ Failure Pass ] for now. Suspecting this CL: https://codereview.chromium.org/2046883003
,
Jun 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47b9d2b1d977fcfb0316a2053e68c1246fa3e5cf commit 47b9d2b1d977fcfb0316a2053e68c1246fa3e5cf Author: xidachen <xidachen@chromium.org> Date: Thu Jun 09 14:19:46 2016 Label video-layer-crash.html as flaky on Mac10.11 retina BUG= 618693 NOTRY=true TBR=jbroman@chromium.org Review-Url: https://codereview.chromium.org/2049793003 Cr-Commit-Position: refs/heads/master@{#398870} [modify] https://crrev.com/47b9d2b1d977fcfb0316a2053e68c1246fa3e5cf/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5fc715b9bad244ccc0259737c7f10e42bf9f2455 commit 5fc715b9bad244ccc0259737c7f10e42bf9f2455 Author: xidachen <xidachen@chromium.org> Date: Thu Jun 09 14:29:00 2016 Mark inspector/layers/layer-compositing-reasons.html as flaky BUG= 618693 NOTRY=true TBR=jbroman@chromium.org Review-Url: https://codereview.chromium.org/2049793004 Cr-Commit-Position: refs/heads/master@{#398872} [modify] https://crrev.com/5fc715b9bad244ccc0259737c7f10e42bf9f2455/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 9 2016
,
Jun 9 2016
,
Jun 9 2016
,
Jun 9 2016
,
Jun 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f680f548f24b12a47c17f0701545a1b2dfb7ae2 commit 6f680f548f24b12a47c17f0701545a1b2dfb7ae2 Author: jbroman <jbroman@chromium.org> Date: Thu Jun 09 17:12:18 2016 Deflake inspector/layers/layer-compositing-reasons.html BUG= 618693 Review-Url: https://codereview.chromium.org/2048133004 Cr-Commit-Position: refs/heads/master@{#398925} [modify] https://crrev.com/6f680f548f24b12a47c17f0701545a1b2dfb7ae2/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/6f680f548f24b12a47c17f0701545a1b2dfb7ae2/third_party/WebKit/LayoutTests/inspector/layers/layer-compositing-reasons.html
,
Jun 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df36a90065e1e2c3883f1633c8bdec90091450ce commit df36a90065e1e2c3883f1633c8bdec90091450ce Author: jbroman <jbroman@chromium.org> Date: Thu Jun 09 20:25:37 2016 Remove bad expectations for layer-compositing-reasons.html. BUG= 618693 Review-Url: https://codereview.chromium.org/2050053006 Cr-Commit-Position: refs/heads/master@{#398996} [delete] https://crrev.com/bb1df9d42a87c280c4add2366c51fa2e8bff8f36/third_party/WebKit/LayoutTests/platform/android/inspector/layers/layer-compositing-reasons-expected.txt [delete] https://crrev.com/bb1df9d42a87c280c4add2366c51fa2e8bff8f36/third_party/WebKit/LayoutTests/platform/mac-retina/inspector/layers/layer-compositing-reasons-expected.png [delete] https://crrev.com/bb1df9d42a87c280c4add2366c51fa2e8bff8f36/third_party/WebKit/LayoutTests/platform/mac-retina/inspector/layers/layer-compositing-reasons-expected.txt [delete] https://crrev.com/bb1df9d42a87c280c4add2366c51fa2e8bff8f36/third_party/WebKit/LayoutTests/platform/win/inspector/layers/layer-compositing-reasons-expected.png
,
Jun 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4990c8699c14f2c7226b901c11ea45a810d93c63 commit 4990c8699c14f2c7226b901c11ea45a810d93c63 Author: jbroman <jbroman@chromium.org> Date: Thu Jun 09 20:53:25 2016 Attempt to deflake video-layer-crash.html. This makes the test wait for layout and paint, instead of finishing the test as soon as the seeked event is seen. Currently the Retina bot flakily produces the frame previous to the one that is expected. BUG= 618693 Review-Url: https://codereview.chromium.org/2053793002 Cr-Commit-Position: refs/heads/master@{#399010} [modify] https://crrev.com/4990c8699c14f2c7226b901c11ea45a810d93c63/third_party/WebKit/LayoutTests/media/video-paint-test.js
,
Jun 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f0ab9c835e3f55e0d073239a75a4a73c1e61836 commit 5f0ab9c835e3f55e0d073239a75a4a73c1e61836 Author: jbroman <jbroman@chromium.org> Date: Fri Jun 10 15:37:51 2016 Revert of Attempt to deflake video-layer-crash.html. (patchset #1 id:1 of https://codereview.chromium.org/2053793002/ ) Reason for revert: Didn't deflake -- and there should be a synchronous layout/paint before pixel dump anyhow. Original issue's description: > Attempt to deflake video-layer-crash.html. > > This makes the test wait for layout and paint, instead of finishing the test as > soon as the seeked event is seen. Currently the Retina bot flakily produces the > frame previous to the one that is expected. > > BUG= 618693 > > Committed: https://crrev.com/4990c8699c14f2c7226b901c11ea45a810d93c63 > Cr-Commit-Position: refs/heads/master@{#399010} TBR=xidachen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 618693 Review-Url: https://codereview.chromium.org/2057193002 Cr-Commit-Position: refs/heads/master@{#399189} [modify] https://crrev.com/5f0ab9c835e3f55e0d073239a75a4a73c1e61836/third_party/WebKit/LayoutTests/media/video-paint-test.js
,
Jun 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90e90026d8045a112853f0c9c26b119f5fbb964a commit 90e90026d8045a112853f0c9c26b119f5fbb964a Author: jbroman <jbroman@chromium.org> Date: Fri Jun 10 16:59:35 2016 Replace expected pixel result for video-layer-crash.html on Mac Retina. It looks like this was already flaky before my patch, but the rebaseline bot had the misfortune of grabbing a bad expectation. If so, hopefully committing the good expectation will fix things. BUG= 618693 Review-Url: https://codereview.chromium.org/2056343002 Cr-Commit-Position: refs/heads/master@{#399213} [modify] https://crrev.com/90e90026d8045a112853f0c9c26b119f5fbb964a/third_party/WebKit/LayoutTests/platform/mac-retina/media/video-layer-crash-expected.png [modify] https://crrev.com/90e90026d8045a112853f0c9c26b119f5fbb964a/third_party/WebKit/LayoutTests/platform/mac-retina/media/video-layer-crash-expected.txt
,
Jun 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16788ccba5871bd6a6b0deeb80151e7c0009e040 commit 16788ccba5871bd6a6b0deeb80151e7c0009e040 Author: jbroman <jbroman@chromium.org> Date: Fri Jun 10 19:54:32 2016 Remove [ Failure Pass ] expectation for video-layer-crash.html. It was mildly flaky before my patch, so in all likelihood this trouble was caused only by the rebaseline bot picking a bad run on Retina (there are flaky-but-pass-on-retry failures before and after my original patch on the flakiness dashboard, and it's not obvious why this test is flaky). BUG= 618693 Review-Url: https://codereview.chromium.org/2059903002 Cr-Commit-Position: refs/heads/master@{#399256} [modify] https://crrev.com/16788ccba5871bd6a6b0deeb80151e7c0009e040/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 13 2016
It worked! This test is no more flaky than it was before. (I wish this test weren't flaky at all, but I don't know the media pipeline well enough to know what's up here.)
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47b9d2b1d977fcfb0316a2053e68c1246fa3e5cf commit 47b9d2b1d977fcfb0316a2053e68c1246fa3e5cf Author: xidachen <xidachen@chromium.org> Date: Thu Jun 09 14:19:46 2016 Label video-layer-crash.html as flaky on Mac10.11 retina BUG= 618693 NOTRY=true TBR=jbroman@chromium.org Review-Url: https://codereview.chromium.org/2049793003 Cr-Commit-Position: refs/heads/master@{#398870} [modify] https://crrev.com/47b9d2b1d977fcfb0316a2053e68c1246fa3e5cf/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5fc715b9bad244ccc0259737c7f10e42bf9f2455 commit 5fc715b9bad244ccc0259737c7f10e42bf9f2455 Author: xidachen <xidachen@chromium.org> Date: Thu Jun 09 14:29:00 2016 Mark inspector/layers/layer-compositing-reasons.html as flaky BUG= 618693 NOTRY=true TBR=jbroman@chromium.org Review-Url: https://codereview.chromium.org/2049793004 Cr-Commit-Position: refs/heads/master@{#398872} [modify] https://crrev.com/5fc715b9bad244ccc0259737c7f10e42bf9f2455/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f680f548f24b12a47c17f0701545a1b2dfb7ae2 commit 6f680f548f24b12a47c17f0701545a1b2dfb7ae2 Author: jbroman <jbroman@chromium.org> Date: Thu Jun 09 17:12:18 2016 Deflake inspector/layers/layer-compositing-reasons.html BUG= 618693 Review-Url: https://codereview.chromium.org/2048133004 Cr-Commit-Position: refs/heads/master@{#398925} [modify] https://crrev.com/6f680f548f24b12a47c17f0701545a1b2dfb7ae2/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/6f680f548f24b12a47c17f0701545a1b2dfb7ae2/third_party/WebKit/LayoutTests/inspector/layers/layer-compositing-reasons.html
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df36a90065e1e2c3883f1633c8bdec90091450ce commit df36a90065e1e2c3883f1633c8bdec90091450ce Author: jbroman <jbroman@chromium.org> Date: Thu Jun 09 20:25:37 2016 Remove bad expectations for layer-compositing-reasons.html. BUG= 618693 Review-Url: https://codereview.chromium.org/2050053006 Cr-Commit-Position: refs/heads/master@{#398996} [delete] https://crrev.com/bb1df9d42a87c280c4add2366c51fa2e8bff8f36/third_party/WebKit/LayoutTests/platform/android/inspector/layers/layer-compositing-reasons-expected.txt [delete] https://crrev.com/bb1df9d42a87c280c4add2366c51fa2e8bff8f36/third_party/WebKit/LayoutTests/platform/mac-retina/inspector/layers/layer-compositing-reasons-expected.png [delete] https://crrev.com/bb1df9d42a87c280c4add2366c51fa2e8bff8f36/third_party/WebKit/LayoutTests/platform/mac-retina/inspector/layers/layer-compositing-reasons-expected.txt [delete] https://crrev.com/bb1df9d42a87c280c4add2366c51fa2e8bff8f36/third_party/WebKit/LayoutTests/platform/win/inspector/layers/layer-compositing-reasons-expected.png
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4990c8699c14f2c7226b901c11ea45a810d93c63 commit 4990c8699c14f2c7226b901c11ea45a810d93c63 Author: jbroman <jbroman@chromium.org> Date: Thu Jun 09 20:53:25 2016 Attempt to deflake video-layer-crash.html. This makes the test wait for layout and paint, instead of finishing the test as soon as the seeked event is seen. Currently the Retina bot flakily produces the frame previous to the one that is expected. BUG= 618693 Review-Url: https://codereview.chromium.org/2053793002 Cr-Commit-Position: refs/heads/master@{#399010} [modify] https://crrev.com/4990c8699c14f2c7226b901c11ea45a810d93c63/third_party/WebKit/LayoutTests/media/video-paint-test.js
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f0ab9c835e3f55e0d073239a75a4a73c1e61836 commit 5f0ab9c835e3f55e0d073239a75a4a73c1e61836 Author: jbroman <jbroman@chromium.org> Date: Fri Jun 10 15:37:51 2016 Revert of Attempt to deflake video-layer-crash.html. (patchset #1 id:1 of https://codereview.chromium.org/2053793002/ ) Reason for revert: Didn't deflake -- and there should be a synchronous layout/paint before pixel dump anyhow. Original issue's description: > Attempt to deflake video-layer-crash.html. > > This makes the test wait for layout and paint, instead of finishing the test as > soon as the seeked event is seen. Currently the Retina bot flakily produces the > frame previous to the one that is expected. > > BUG= 618693 > > Committed: https://crrev.com/4990c8699c14f2c7226b901c11ea45a810d93c63 > Cr-Commit-Position: refs/heads/master@{#399010} TBR=xidachen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 618693 Review-Url: https://codereview.chromium.org/2057193002 Cr-Commit-Position: refs/heads/master@{#399189} [modify] https://crrev.com/5f0ab9c835e3f55e0d073239a75a4a73c1e61836/third_party/WebKit/LayoutTests/media/video-paint-test.js
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90e90026d8045a112853f0c9c26b119f5fbb964a commit 90e90026d8045a112853f0c9c26b119f5fbb964a Author: jbroman <jbroman@chromium.org> Date: Fri Jun 10 16:59:35 2016 Replace expected pixel result for video-layer-crash.html on Mac Retina. It looks like this was already flaky before my patch, but the rebaseline bot had the misfortune of grabbing a bad expectation. If so, hopefully committing the good expectation will fix things. BUG= 618693 Review-Url: https://codereview.chromium.org/2056343002 Cr-Commit-Position: refs/heads/master@{#399213} [modify] https://crrev.com/90e90026d8045a112853f0c9c26b119f5fbb964a/third_party/WebKit/LayoutTests/platform/mac-retina/media/video-layer-crash-expected.png [modify] https://crrev.com/90e90026d8045a112853f0c9c26b119f5fbb964a/third_party/WebKit/LayoutTests/platform/mac-retina/media/video-layer-crash-expected.txt
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16788ccba5871bd6a6b0deeb80151e7c0009e040 commit 16788ccba5871bd6a6b0deeb80151e7c0009e040 Author: jbroman <jbroman@chromium.org> Date: Fri Jun 10 19:54:32 2016 Remove [ Failure Pass ] expectation for video-layer-crash.html. It was mildly flaky before my patch, so in all likelihood this trouble was caused only by the rebaseline bot picking a bad run on Retina (there are flaky-but-pass-on-retry failures before and after my original patch on the flakiness dashboard, and it's not obvious why this test is flaky). BUG= 618693 Review-Url: https://codereview.chromium.org/2059903002 Cr-Commit-Position: refs/heads/master@{#399256} [modify] https://crrev.com/16788ccba5871bd6a6b0deeb80151e7c0009e040/third_party/WebKit/LayoutTests/TestExpectations |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by xidac...@chromium.org
, Jun 9 2016