Issue 618672 link

Starred by 2 users

Issue metadata

Status:	Assigned
Owner:	yukishiino@chromium.org
Cc:	lfg@chromium.org
Components:	Blink>Bindings
EstimatedDays:	----
NextAction:	----
OS:	All
Pri:	2
Type:	Bug

Web-platfrom features must run with the relevant realm of the platform object.

Project Member Reported by yukishiino@chromium.org, Jun 9 2016

Issue description

The binding layer is now passing the current realm to the API implementations, but it's wrong.  Except for a few cases, all the operations about DOM objects must be run with the relevant realm of the platform object.  We should switch from the current realm to the relevant realm of the platform object.

Project Member

Comment 1 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36f52aca24a7fdf60ff33ada980e663e550b622b

commit 36f52aca24a7fdf60ff33ada980e663e550b622b
Author: yukishiino <yukishiino@chromium.org>
Date: Fri Jul 22 11:49:26 2016

binding: Uses the relevant realm instead of the current realm (1 of ?)

There are many places where we're passing the current realm instead of
the relevant realm of the platform object, and it's wrong.  This CL
fixes most of those but not all.  Following CLs may fix the rest.

BUG=618672, 560308 

Review-Url: https://codereview.chromium.org/2049493005
Cr-Commit-Position: refs/heads/master@{#407133}

[modify] https://crrev.com/36f52aca24a7fdf60ff33ada980e663e550b622b/third_party/WebKit/LayoutTests/fast/dom/Window/timeout-callback-scope-expected.txt
[modify] https://crrev.com/36f52aca24a7fdf60ff33ada980e663e550b622b/third_party/WebKit/LayoutTests/fast/dom/Window/timeout-callback-scope.html
[modify] https://crrev.com/36f52aca24a7fdf60ff33ada980e663e550b622b/third_party/WebKit/Source/bindings/core/v8/ScriptState.h
[modify] https://crrev.com/36f52aca24a7fdf60ff33ada980e663e550b622b/third_party/WebKit/Source/bindings/templates/attributes.cpp
[modify] https://crrev.com/36f52aca24a7fdf60ff33ada980e663e550b622b/third_party/WebKit/Source/bindings/templates/methods.cpp
[modify] https://crrev.com/36f52aca24a7fdf60ff33ada980e663e550b622b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp
[modify] https://crrev.com/36f52aca24a7fdf60ff33ada980e663e550b622b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.cpp
[modify] https://crrev.com/36f52aca24a7fdf60ff33ada980e663e550b622b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.cpp
[modify] https://crrev.com/36f52aca24a7fdf60ff33ada980e663e550b622b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp
[modify] https://crrev.com/36f52aca24a7fdf60ff33ada980e663e550b622b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp
[modify] https://crrev.com/36f52aca24a7fdf60ff33ada980e663e550b622b/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp
[modify] https://crrev.com/36f52aca24a7fdf60ff33ada980e663e550b622b/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp

Comment 2 by yukishiino@chromium.org, Jul 29 2016

FYI, a design doc is here.

"Context-handling in V8-Blink binding layer"
https://docs.google.com/document/d/1J7OkRPvJreTYBtsEb5Hx5-3tqDue0kVuPpXjDBSHlGY/edit?usp=sharing

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72fe6ccc8889f01f4c6d60fb54e76c6fa964277a

commit 72fe6ccc8889f01f4c6d60fb54e76c6fa964277a
Author: yukishiino <yukishiino@chromium.org>
Date: Tue Aug 09 03:50:10 2016

binding: Updates a layout test for exception's creation context.

I'm planning to make a change so that Exceptions are always created
in the current context.  Before doing that, I'd like to improve
an existing layout test so that we can clearly see the coming change.

BUG=618672

Review-Url: https://codereview.chromium.org/2225023002
Cr-Commit-Position: refs/heads/master@{#410569}

[modify] https://crrev.com/72fe6ccc8889f01f4c6d60fb54e76c6fa964277a/third_party/WebKit/LayoutTests/fast/dom/cross-frame-accessor-throw-expected.txt
[modify] https://crrev.com/72fe6ccc8889f01f4c6d60fb54e76c6fa964277a/third_party/WebKit/LayoutTests/fast/dom/cross-frame-accessor-throw.html

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d375d0327f654294eeb1e0d7bcae0829dcd89ae4

commit d375d0327f654294eeb1e0d7bcae0829dcd89ae4
Author: yukishiino <yukishiino@chromium.org>
Date: Wed Aug 10 10:06:44 2016

binding: Always throws an exception in the current realm.

Rewrote V8ThrowException, plus made it throws exceptions always in
the current realm.  Exceptions shouldn't be thrown in the relevant
realm for the context object.

BUG=618672

Review-Url: https://codereview.chromium.org/2209203002
Cr-Commit-Position: refs/heads/master@{#411016}

[modify] https://crrev.com/d375d0327f654294eeb1e0d7bcae0829dcd89ae4/third_party/WebKit/LayoutTests/fast/dom/cross-frame-accessor-throw-expected.txt
[modify] https://crrev.com/d375d0327f654294eeb1e0d7bcae0829dcd89ae4/third_party/WebKit/Source/bindings/core/v8/ExceptionState.cpp
[modify] https://crrev.com/d375d0327f654294eeb1e0d7bcae0829dcd89ae4/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp
[modify] https://crrev.com/d375d0327f654294eeb1e0d7bcae0829dcd89ae4/third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h
[modify] https://crrev.com/d375d0327f654294eeb1e0d7bcae0829dcd89ae4/third_party/WebKit/Source/bindings/core/v8/V8ThrowException.cpp
[modify] https://crrev.com/d375d0327f654294eeb1e0d7bcae0829dcd89ae4/third_party/WebKit/Source/bindings/core/v8/V8ThrowException.h
[modify] https://crrev.com/d375d0327f654294eeb1e0d7bcae0829dcd89ae4/third_party/WebKit/Source/bindings/core/v8/custom/V8IntersectionObserverCustom.cpp
[modify] https://crrev.com/d375d0327f654294eeb1e0d7bcae0829dcd89ae4/third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp
[modify] https://crrev.com/d375d0327f654294eeb1e0d7bcae0829dcd89ae4/third_party/WebKit/Source/bindings/modules/v8/custom/V8IDBObserverCustom.cpp
[modify] https://crrev.com/d375d0327f654294eeb1e0d7bcae0829dcd89ae4/third_party/WebKit/Source/bindings/templates/methods.cpp
[modify] https://crrev.com/d375d0327f654294eeb1e0d7bcae0829dcd89ae4/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexed.cpp
[modify] https://crrev.com/d375d0327f654294eeb1e0d7bcae0829dcd89ae4/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedGlobal.cpp
[modify] https://crrev.com/d375d0327f654294eeb1e0d7bcae0829dcd89ae4/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedPrimaryGlobal.cpp
[modify] https://crrev.com/d375d0327f654294eeb1e0d7bcae0829dcd89ae4/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp
[modify] https://crrev.com/d375d0327f654294eeb1e0d7bcae0829dcd89ae4/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.cpp
[modify] https://crrev.com/d375d0327f654294eeb1e0d7bcae0829dcd89ae4/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor3.cpp
[modify] https://crrev.com/d375d0327f654294eeb1e0d7bcae0829dcd89ae4/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp
[modify] https://crrev.com/d375d0327f654294eeb1e0d7bcae0829dcd89ae4/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor2.cpp
[modify] https://crrev.com/d375d0327f654294eeb1e0d7bcae0829dcd89ae4/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp
[modify] https://crrev.com/d375d0327f654294eeb1e0d7bcae0829dcd89ae4/third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp
[modify] https://crrev.com/d375d0327f654294eeb1e0d7bcae0829dcd89ae4/third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp
[modify] https://crrev.com/d375d0327f654294eeb1e0d7bcae0829dcd89ae4/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface2Partial.cpp
[modify] https://crrev.com/d375d0327f654294eeb1e0d7bcae0829dcd89ae4/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/611954a8adb1321a8cbf21b1065f62f3504a3119

commit 611954a8adb1321a8cbf21b1065f62f3504a3119
Author: yukishiino <yukishiino@chromium.org>
Date: Tue Aug 16 07:15:53 2016

binding: ExceptionState no longer takes |creationContext|.

Since V8ThrowException no longer takes |creationContext|, there is
no need for ExceptionState to take |creationContext|, too.

This CL also adds new constructors of ExceptionState that take
v8::Isolate* as the first argument.  These new constructors will be
used later.

BUG=618672

Review-Url: https://codereview.chromium.org/2249593002
Cr-Commit-Position: refs/heads/master@{#412183}

[modify] https://crrev.com/611954a8adb1321a8cbf21b1065f62f3504a3119/third_party/WebKit/Source/bindings/core/v8/ExceptionState.cpp
[modify] https://crrev.com/611954a8adb1321a8cbf21b1065f62f3504a3119/third_party/WebKit/Source/bindings/core/v8/ExceptionState.h

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ffd879eb8bcc2d15521ec42293811f3d78b5527

commit 6ffd879eb8bcc2d15521ec42293811f3d78b5527
Author: yukishiino <yukishiino@chromium.org>
Date: Wed Oct 26 07:40:05 2016

binding: Makes event listener attributes use the relevant realm.

Makes onxxx attributes use the relevant realm for the context
object.  In my investigation, the realm used here shouldn't be
observable by user script, but anyway we'd like to replace
ScriptState::current() with either of forFunctionObject or
forReceiverObject.

BUG=618672

Review-Url: https://codereview.chromium.org/2449103002
Cr-Commit-Position: refs/heads/master@{#427629}

[modify] https://crrev.com/6ffd879eb8bcc2d15521ec42293811f3d78b5527/third_party/WebKit/Source/bindings/core/v8/ScriptState.h
[modify] https://crrev.com/6ffd879eb8bcc2d15521ec42293811f3d78b5527/third_party/WebKit/Source/bindings/scripts/v8_attributes.py
[modify] https://crrev.com/6ffd879eb8bcc2d15521ec42293811f3d78b5527/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp
[modify] https://crrev.com/6ffd879eb8bcc2d15521ec42293811f3d78b5527/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp
[modify] https://crrev.com/6ffd879eb8bcc2d15521ec42293811f3d78b5527/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c5aa5f5af6a2246bb55a29862e6d9f42256c43a

commit 1c5aa5f5af6a2246bb55a29862e6d9f42256c43a
Author: bashi <bashi@chromium.org>
Date: Thu Oct 27 02:17:20 2016

bindings: Store ScriptState in generated callback functions

As the spec says[1], we should store "callback context" (which is ScriptState
in Blink) when creating callback impl instances and use it to invoke
v8 functions, instead of passing ScriptState at invoke time.

[1] https://heycam.github.io/webidl/#es-callback-function

BUG=618672

Review-Url: https://codereview.chromium.org/2458573002
Cr-Commit-Position: refs/heads/master@{#427918}

[modify] https://crrev.com/1c5aa5f5af6a2246bb55a29862e6d9f42256c43a/third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp
[modify] https://crrev.com/1c5aa5f5af6a2246bb55a29862e6d9f42256c43a/third_party/WebKit/Source/bindings/modules/v8/custom/V8IDBObserverCustom.cpp
[modify] https://crrev.com/1c5aa5f5af6a2246bb55a29862e6d9f42256c43a/third_party/WebKit/Source/bindings/scripts/v8_callback_function.py
[modify] https://crrev.com/1c5aa5f5af6a2246bb55a29862e6d9f42256c43a/third_party/WebKit/Source/bindings/scripts/v8_types.py
[modify] https://crrev.com/1c5aa5f5af6a2246bb55a29862e6d9f42256c43a/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl
[modify] https://crrev.com/1c5aa5f5af6a2246bb55a29862e6d9f42256c43a/third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl
[modify] https://crrev.com/1c5aa5f5af6a2246bb55a29862e6d9f42256c43a/third_party/WebKit/Source/bindings/tests/results/core/AnyCallbackFunctionOptionalAnyArg.cpp
[modify] https://crrev.com/1c5aa5f5af6a2246bb55a29862e6d9f42256c43a/third_party/WebKit/Source/bindings/tests/results/core/AnyCallbackFunctionOptionalAnyArg.h
[modify] https://crrev.com/1c5aa5f5af6a2246bb55a29862e6d9f42256c43a/third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.cpp
[modify] https://crrev.com/1c5aa5f5af6a2246bb55a29862e6d9f42256c43a/third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.h
[modify] https://crrev.com/1c5aa5f5af6a2246bb55a29862e6d9f42256c43a/third_party/WebKit/Source/bindings/tests/results/core/StringSequenceCallbackFunctionLongSequenceArg.cpp
[modify] https://crrev.com/1c5aa5f5af6a2246bb55a29862e6d9f42256c43a/third_party/WebKit/Source/bindings/tests/results/core/StringSequenceCallbackFunctionLongSequenceArg.h
[modify] https://crrev.com/1c5aa5f5af6a2246bb55a29862e6d9f42256c43a/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp
[modify] https://crrev.com/1c5aa5f5af6a2246bb55a29862e6d9f42256c43a/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.cpp
[modify] https://crrev.com/1c5aa5f5af6a2246bb55a29862e6d9f42256c43a/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.h
[modify] https://crrev.com/1c5aa5f5af6a2246bb55a29862e6d9f42256c43a/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp
[modify] https://crrev.com/1c5aa5f5af6a2246bb55a29862e6d9f42256c43a/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.h
[modify] https://crrev.com/1c5aa5f5af6a2246bb55a29862e6d9f42256c43a/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionTypedef.cpp
[modify] https://crrev.com/1c5aa5f5af6a2246bb55a29862e6d9f42256c43a/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionTypedef.h
[modify] https://crrev.com/1c5aa5f5af6a2246bb55a29862e6d9f42256c43a/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp
[modify] https://crrev.com/1c5aa5f5af6a2246bb55a29862e6d9f42256c43a/third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.cpp
[modify] https://crrev.com/1c5aa5f5af6a2246bb55a29862e6d9f42256c43a/third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.h
[modify] https://crrev.com/1c5aa5f5af6a2246bb55a29862e6d9f42256c43a/third_party/WebKit/Source/core/testing/CallbackFunctionTest.cpp
[modify] https://crrev.com/1c5aa5f5af6a2246bb55a29862e6d9f42256c43a/third_party/WebKit/Source/core/testing/CallbackFunctionTest.h
[modify] https://crrev.com/1c5aa5f5af6a2246bb55a29862e6d9f42256c43a/third_party/WebKit/Source/core/testing/CallbackFunctionTest.idl
[modify] https://crrev.com/1c5aa5f5af6a2246bb55a29862e6d9f42256c43a/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp
[modify] https://crrev.com/1c5aa5f5af6a2246bb55a29862e6d9f42256c43a/third_party/WebKit/Source/core/timing/PerformanceObserver.cpp
[modify] https://crrev.com/1c5aa5f5af6a2246bb55a29862e6d9f42256c43a/third_party/WebKit/Source/core/timing/PerformanceObserverTest.cpp
[modify] https://crrev.com/1c5aa5f5af6a2246bb55a29862e6d9f42256c43a/third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp
[modify] https://crrev.com/1c5aa5f5af6a2246bb55a29862e6d9f42256c43a/third_party/WebKit/Source/modules/indexeddb/IDBObserver.h
[modify] https://crrev.com/1c5aa5f5af6a2246bb55a29862e6d9f42256c43a/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp
[modify] https://crrev.com/1c5aa5f5af6a2246bb55a29862e6d9f42256c43a/third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackTest.cpp

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05d7c9d9594f75024b20a53cfbb1d6a8f5deb938

commit 05d7c9d9594f75024b20a53cfbb1d6a8f5deb938
Author: yukishiino <yukishiino@chromium.org>
Date: Mon Nov 14 18:29:32 2016

binding: Replaces DictionaryHelper::get(ScriptValue) with get(Nullable<T>).

Replaces DictionaryHelper::get(dict, key, ScriptValue&) with
get(dict, key, Nullable<T>&).

The only client of get(ScriptValue&) is EffectInput.cpp and it
expects "double?" in IDL.  So, Nullable<T> should be better.

The motivation of this CL is to remove an use of
ScriptState::current() in order to make Blink use the correct
context.  Also we'd like to reduce usage of ScriptValue that
saves a ScriptState inside.

BUG=618672

Review-Url: https://codereview.chromium.org/2444363002
Cr-Commit-Position: refs/heads/master@{#431876}

[modify] https://crrev.com/05d7c9d9594f75024b20a53cfbb1d6a8f5deb938/third_party/WebKit/Source/bindings/core/v8/Dictionary.h
[modify] https://crrev.com/05d7c9d9594f75024b20a53cfbb1d6a8f5deb938/third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForBindings.h
[modify] https://crrev.com/05d7c9d9594f75024b20a53cfbb1d6a8f5deb938/third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp
[modify] https://crrev.com/05d7c9d9594f75024b20a53cfbb1d6a8f5deb938/third_party/WebKit/Source/core/animation/EffectInput.cpp

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c5231afadf1376cd206a64f0370fda8007254be

commit 1c5231afadf1376cd206a64f0370fda8007254be
Author: yukishiino <yukishiino@chromium.org>
Date: Fri Nov 18 11:30:17 2016

binding: Makes window/frames/self attributes return itself.

Per HTML spec[1], window, frames, and self attributes must return
the global proxy object.  This CL simply follows it.

Note that these attributes are expected to never return null.
We're currently breaking this assumption on detached frames.

[1] https://html.spec.whatwg.org/multipage/browsers.html#dom-window

BUG=618672

Review-Url: https://codereview.chromium.org/2501333002
Cr-Commit-Position: refs/heads/master@{#433178}

[modify] https://crrev.com/1c5231afadf1376cd206a64f0370fda8007254be/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-in-closure-after-navigation-expected.txt
[modify] https://crrev.com/1c5231afadf1376cd206a64f0370fda8007254be/third_party/WebKit/LayoutTests/fast/dom/Window/resources/property-access-in-closure-after-navigation-child.html
[modify] https://crrev.com/1c5231afadf1376cd206a64f0370fda8007254be/third_party/WebKit/Source/bindings/core/v8/V8Binding.h
[modify] https://crrev.com/1c5231afadf1376cd206a64f0370fda8007254be/third_party/WebKit/Source/core/frame/DOMWindow.cpp
[modify] https://crrev.com/1c5231afadf1376cd206a64f0370fda8007254be/third_party/WebKit/Source/core/frame/DOMWindow.h
[modify] https://crrev.com/1c5231afadf1376cd206a64f0370fda8007254be/third_party/WebKit/Source/core/frame/Window.idl

Project Member

Comment 10 by bugdroid1@chromium.org, Jan 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3e6b34d4b686ee9bc9addda6885750964638c39

commit a3e6b34d4b686ee9bc9addda6885750964638c39
Author: dcheng <dcheng@chromium.org>
Date: Wed Jan 18 22:35:25 2017

Revert "binding: Makes window/frames/self attributes return itself."

> Per HTML spec[1], window, frames, and self attributes must return
> the global proxy object.  This CL simply follows it.
>
> Note that these attributes are expected to never return null.
> We're currently breaking this assumption on detached frames.
>
> [1] https://html.spec.whatwg.org/multipage/browsers.html#dom-window

The current fix for this depends on a ScriptState being associated
with the window object. However, this prevents RemoteWindowProxy
from using v8::Context::NewRemoteContext(), as a RemoteWindowProxy
would then have no associated ScriptState.

BUG=618672, 527190 
R=haraken@chromium.org,yukishiino@chromium.org

Review-Url: https://codereview.chromium.org/2643613003
Cr-Commit-Position: refs/heads/master@{#444517}

[modify] https://crrev.com/a3e6b34d4b686ee9bc9addda6885750964638c39/third_party/WebKit/LayoutTests/external/wpt/resources/testharnessreport.js
[modify] https://crrev.com/a3e6b34d4b686ee9bc9addda6885750964638c39/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-in-closure-after-navigation-expected.txt
[modify] https://crrev.com/a3e6b34d4b686ee9bc9addda6885750964638c39/third_party/WebKit/LayoutTests/resources/testharnessreport.js
[modify] https://crrev.com/a3e6b34d4b686ee9bc9addda6885750964638c39/third_party/WebKit/Source/core/frame/DOMWindow.cpp
[modify] https://crrev.com/a3e6b34d4b686ee9bc9addda6885750964638c39/third_party/WebKit/Source/core/frame/DOMWindow.h
[modify] https://crrev.com/a3e6b34d4b686ee9bc9addda6885750964638c39/third_party/WebKit/Source/core/frame/Window.idl

►

Issue 618672 link

Issue metadata

Web-platfrom features must run with the relevant realm of the platform object.

Issue description

Comment 1 by bugdroid1@chromium.org, Jul 22 2016

Comment 1 Deleted

Comment 2 by yukishiino@chromium.org, Jul 29 2016

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Aug 9 2016

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Aug 10 2016

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Aug 16 2016

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Oct 26 2016

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Oct 27 2016

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Nov 14 2016

Comment 8 Deleted

Comment 9 by bugdroid1@chromium.org, Nov 18 2016

Comment 9 Deleted

Comment 10 by bugdroid1@chromium.org, Jan 18 2017

Comment 10 Deleted

Sign in to add a comment