New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 618657 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

HasBytecodeArray() in objects-inl.h

Project Member Reported by ClusterFuzz, Jun 9 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4517646326562816

Fuzzer: mbarbella_js_mutation
Job Type: linux_asan_d8_ignition_dbg
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  HasBytecodeArray() in objects-inl.h
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_d8_ignition_dbg&range=35871:35872

Minimized Testcase (0.05 Kb):
Download: https://cluster-fuzz.appspot.com/download/AMIfv97N1eZhTLK2xi4aMtohee3LrbnAnz16stxct7p5_nXZhsJ3Iw3MszkuNqOJ9w_RbSgaTd_d1KI9i713DTVI_iduy3EXo1BKLLWJHlKoK_B7YflTea5OnNhd7nHGpbb-vDGJbtFab39x2l6WB_wdQxkOW6A9MA
  function* g() { yield 1; }
  var __v_1 = g();


Filer: mstarzinger

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Cc: neis@chromium.org
The generators don't play nice with the --ignition-filter flag. Note that in this example we have --ignition-filter=f but the generator is called "g". I guess that is something we just have to live with. Georg, WDYT?
Owner: neis@chromium.org
Status: Assigned (was: Available)
Georg mentioned offline that the implementation should be flexible enough to handle this. He agreed to look into it. Thanks!
Reproduces as follows ...

$ ./out/x64.debug/d8 --ignition --ignition-generators --ignition-filter=f ~/Downloads/fuzz-00291.js
$ cat ~/Downloads/fuzz-00291.js
  function* g() { yield 1; }
  var __v_1 = g();

Comment 4 by neis@chromium.org, Jun 9 2016

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/54b405ce656873c894b702cbad95f5d374a94428

commit 54b405ce656873c894b702cbad95f5d374a94428
Author: neis <neis@chromium.org>
Date: Thu Jun 09 14:18:27 2016

[generators] Make runtime functions more robust.

Only look at the --ignition-generators flag when determining whether to use
Ignition (in compiler.cc).  In generator runtime functions, instead of looking
at the flag, determine the generator kind based on whether the generator has a
bytecode array.  This allows compiling some generator function using
full-codegen and others using Ignition, e.g when using --ignition-filter.

R=mstarzinger@chromium.org
BUG= chromium:618657 , v8:4907 

Review-Url: https://codereview.chromium.org/2052873002
Cr-Commit-Position: refs/heads/master@{#36864}

[modify] https://crrev.com/54b405ce656873c894b702cbad95f5d374a94428/src/runtime/runtime-generator.cc
[add] https://crrev.com/54b405ce656873c894b702cbad95f5d374a94428/test/mjsunit/regress/regress-618657.js

Comment 6 by neis@chromium.org, Jun 9 2016

Status: Fixed (was: Started)
Project Member

Comment 7 by ClusterFuzz, Jun 10 2016

ClusterFuzz has detected this issue as fixed in range 36863:36864.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4517646326562816

Fuzzer: mbarbella_js_mutation
Job Type: linux_asan_d8_ignition_dbg
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  HasBytecodeArray() in objects-inl.h
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_d8_ignition_dbg&range=35871:35872
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_d8_ignition_dbg&range=36863:36864

Minimized Testcase (0.05 Kb):
Download: https://cluster-fuzz.appspot.com/download/AMIfv97N1eZhTLK2xi4aMtohee3LrbnAnz16stxct7p5_nXZhsJ3Iw3MszkuNqOJ9w_RbSgaTd_d1KI9i713DTVI_iduy3EXo1BKLLWJHlKoK_B7YflTea5OnNhd7nHGpbb-vDGJbtFab39x2l6WB_wdQxkOW6A9MA
  function* g() { yield 1; }
  var __v_1 = g();


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

Comment 8 by ishell@chromium.org, Jun 13 2016

 Issue 619470  has been merged into this issue.
Project Member

Comment 9 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment